From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web10.5178.1654073386420471128
 for <devel@edk2.groups.io>;
 Wed, 01 Jun 2022 01:49:46 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aWO1ktRQ;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1654073385;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=mzj6U3VjSpZiASipCZ6vsxMFFBQoYfVR9pxbiJAmaVA=;
	b=aWO1ktRQFXhibL6VRBj7W9mTRnF1cN3D2fFIdDbfcMhbz4M6jCsFiEpIjAsL5VbCGN8AMT
	6OglQuPacdC7Sdm+ue3zNvEQEOa9rbybqpvAO+8/uqeG+FKvMi1lqxTxG6Dcc7x1VHbLLE
	y39lu2P6McOerrCamKS3hcCfivcX6C4=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-633-34aA2KZfPJKOPk2mSTc-2A-1; Wed, 01 Jun 2022 04:49:44 -0400
X-MC-Unique: 34aA2KZfPJKOPk2mSTc-2A-1
Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D38DF80159B;
	Wed,  1 Jun 2022 08:49:43 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.104])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id A2F2B492C3B;
	Wed,  1 Jun 2022 08:49:43 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 1E0A31800623; Wed,  1 Jun 2022 10:49:41 +0200 (CEST)
Date: Wed, 1 Jun 2022 10:49:41 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH 1/2] OvmfPkg: Fix TDVMCALL error in ApRunLoop.nasm
Message-ID: <20220601084941.byxi4anill2odhqn@sirius.home.kraxel.org>
References: <cover.1654007213.git.min.m.xu@intel.com>
 <7afc1c0752f09c2c53ff5b2c78c3e064838f3778.1654007213.git.min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <7afc1c0752f09c2c53ff5b2c78c3e064838f3778.1654007213.git.min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, May 31, 2022 at 10:31:16PM +0800, Min Xu wrote:
> According to GHCI Spec Table 2-1, in TDVMCALL R10 should be cleared
> to 0 in input operands, and be checked for the return result.
> https://cdrdv2.intel.com/v1/dl/getContent/726790
> 
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Signed-off-by: Min Xu <min.m.xu@intel.com>

Acked-by: Gerd Hoffmann <kraxel@redhat.com>