From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, min.m.xu@intel.com
Cc: Erdem Aktas <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH 2/2] OvmfPkg: Search EFI_RESOURCE_MEMORY_UNACCEPTED for Fw hoblist
Date: Wed, 1 Jun 2022 10:53:20 +0200 [thread overview]
Message-ID: <20220601085320.qqqrovk7nczezeot@sirius.home.kraxel.org> (raw)
In-Reply-To: <4a4fc3a0e4084dbadcacac95b11d246c6b3b7539.1654007213.git.min.m.xu@intel.com>
On Tue, May 31, 2022 at 10:31:17PM +0800, Min Xu wrote:
> In current TDVF implementation all unaccepted memory passed in Hoblist
> are tagged as EFI_RESOURCE_MEMORY_UNACCEPTED. They're all accepted before
> they can be accessed. After accepting memory region, the Hob ResourceType
> is unchanged (still be EFI_RESOURCE_MEMORY_UNACCEPTED).
>
> TDVF Config-B skip PEI phase and it tries to find a memory region which
> is the largest one below 4GB. Then this memory region will be used as the
> firmware hoblist.
>
> So we should walk thru the input hoblist and search for the memory region
> with the type of EFI_RESOURCE_MEMORY_UNACCEPTED.
>
> Because EFI_RESOURCE_MEMORY_UNACCEPTED has not been officially in PI spec.
> So it cannot be defined in MdePkg/Include/Pi/PiHob.h. As a temporary
> solution it is defined in Hob.c.
>
> There is a patch-set for lazy-accept very soon. In that patch-set
> EFI_RESOURCE_MEMORY_UNACCEPTED will be defined in MdeModulePkg.
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
take care,
Gerd
next prev parent reply other threads:[~2022-06-01 8:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 14:31 [PATCH 0/2] Fix 2 issues in TDVF Min Xu
2022-05-31 14:31 ` [PATCH 1/2] OvmfPkg: Fix TDVMCALL error in ApRunLoop.nasm Min Xu
2022-06-01 8:49 ` Gerd Hoffmann
2022-05-31 14:31 ` [PATCH 2/2] OvmfPkg: Search EFI_RESOURCE_MEMORY_UNACCEPTED for Fw hoblist Min Xu
2022-06-01 8:53 ` Gerd Hoffmann [this message]
2022-06-02 8:47 ` [PATCH 0/2] Fix 2 issues in TDVF Yao, Jiewen
[not found] ` <16F4C173DC6EFECF.9239@groups.io>
2022-06-02 9:12 ` [edk2-devel] " Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220601085320.qqqrovk7nczezeot@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox