public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io
Cc: Hao A Wu <hao.a.wu@intel.com>,
	Pawel Polawski <ppolawsk@redhat.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	mateusz.albecki@intel.com, Abner Chang <abner.chang@hpe.com>,
	Ray Ni <ray.ni@intel.com>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Oliver Steffen <osteffen@redhat.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Jian J Wang <jian.j.wang@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Ard Biesheuvel <ardb@kernel.org>
Subject: [PATCH v7 1/6] MdeModulePkg/PciHostBridge: io range is not mandatory
Date: Thu,  2 Jun 2022 10:42:11 +0200	[thread overview]
Message-ID: <20220602084216.159028-2-kraxel@redhat.com> (raw)
In-Reply-To: <20220602084216.159028-1-kraxel@redhat.com>

io range is not mandatory according to pcie spec, so allow
pcie host bridge configurations without io window in case
there are no io reservations.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
---
 MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c
index b20bcd310ad5..354be6dbb313 100644
--- a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c
+++ b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c
@@ -1085,6 +1085,12 @@ NotifyPhase (
               RootBridge->ResAllocNode[Index].Base   = BaseAddress;
               RootBridge->ResAllocNode[Index].Status = ResAllocated;
               DEBUG ((DEBUG_INFO, "Success\n"));
+            } else if ((Index == TypeIo) &&
+                       (RootBridge->Io.Base == MAX_UINT64) &&
+                       (RootBridge->ResAllocNode[Index].Length == 0))
+            {
+              /* I/O is optional on PCIe */
+              DEBUG ((DEBUG_INFO, "Success (PCIe NoIO)\n"));
             } else {
               ReturnStatus = EFI_OUT_OF_RESOURCES;
               DEBUG ((DEBUG_ERROR, "Out Of Resource!\n"));
-- 
2.36.1


  reply	other threads:[~2022-06-02  8:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-02  8:42 [PATCH v7 0/6] OvmfPkg/Microvm/pcie: add pcie support Gerd Hoffmann
2022-06-02  8:42 ` Gerd Hoffmann [this message]
2022-06-02 10:14   ` [PATCH v7 1/6] MdeModulePkg/PciHostBridge: io range is not mandatory Ni, Ray
2022-06-02 11:43     ` Ard Biesheuvel
2022-06-02 13:14       ` Gerd Hoffmann
2022-06-02 13:58         ` Ard Biesheuvel
2022-06-03  8:29           ` [edk2-devel] " Gerd Hoffmann
2022-06-03  8:30             ` Ard Biesheuvel
2022-06-02  8:42 ` [PATCH v7 2/6] OvmfPkg/FdtPciHostBridgeLib: " Gerd Hoffmann
2022-06-02  8:42 ` [PATCH v7 3/6] OvmfPkg/Platform: unfix PcdPciExpressBaseAddress Gerd Hoffmann
2022-06-02  8:42 ` [PATCH v7 4/6] OvmfPkg/Microvm/pcie: no vbeshim please Gerd Hoffmann
2022-06-02  8:42 ` [PATCH v7 5/6] OvmfPkg/Microvm/pcie: mPhysMemAddressWidth tweak Gerd Hoffmann
2022-06-02  8:42 ` [PATCH v7 6/6] OvmfPkg/Microvm/pcie: add pcie support Gerd Hoffmann
2022-06-03  9:12 ` [PATCH v7 0/6] " Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220602084216.159028-2-kraxel@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox