From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.5059.1654244980331105179 for ; Fri, 03 Jun 2022 01:29:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZetkNUDL; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654244979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JkR1loz70UU+HYNa9YK1yTsTuM5hLm5GgAHkaiiaGG8=; b=ZetkNUDLVdOD9bhO2kaLOnUvGvnmh8meJ9Y4iMN+K5DEuet2BcZT3kncCwptZ0UW8cOxUE OnrQEGHAqV0IFVQ9Th0ZcLFdacrN3wLBWkWbIJtOOVDNbPNfEzKK97uoGoXEBKqnDjFkc3 kbqkyw6oaUxPPUrahKnvECFvQgmaZAI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-663-X-B4n9noMIync1MW5rrqSw-1; Fri, 03 Jun 2022 04:29:34 -0400 X-MC-Unique: X-B4n9noMIync1MW5rrqSw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CED42811E76; Fri, 3 Jun 2022 08:29:33 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 80D031410F36; Fri, 3 Jun 2022 08:29:33 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id AB26418009C4; Fri, 3 Jun 2022 10:29:31 +0200 (CEST) Date: Fri, 3 Jun 2022 10:29:31 +0200 From: "Gerd Hoffmann" To: devel@edk2.groups.io, ardb@kernel.org Cc: "Ni, Ray" , "Wu, Hao A" , Pawel Polawski , Ard Biesheuvel , "Albecki, Mateusz" , "Chang, Abner" , Leif Lindholm , "Yao, Jiewen" , Oliver Steffen , "Gao, Liming" , "Wang, Jian J" , "Justen, Jordan L" Subject: Re: [edk2-devel] [PATCH v7 1/6] MdeModulePkg/PciHostBridge: io range is not mandatory Message-ID: <20220603082931.vaivi4vwetwrldnt@sirius.home.kraxel.org> References: <20220602084216.159028-1-kraxel@redhat.com> <20220602084216.159028-2-kraxel@redhat.com> <20220602131457.75zndaiipdosgiid@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, > This seems to be related to the padding logic, i.e., we are trying to > preserve some extra I/O space for the root port in case we hotplug > something that might need it. > --- a/OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c > +++ b/OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c > @@ -733,7 +733,7 @@ GetResourcePadding ( > } > } > > - if (DefaultIo) { > + if (DefaultIo && FALSE) { > // > // Request defaults. > // Oh, *there* it comes from. Given this is configurable already we can fix that one in qemu with a microvm tweak: diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c index 4b3b1dd262f1..f01d972f5d28 100644 --- a/hw/i386/microvm.c +++ b/hw/i386/microvm.c @@ -757,6 +757,12 @@ static void microvm_class_init(ObjectClass *oc, void *data) "Set off to disable adding virtio-mmio devices to the kernel cmdline"); machine_class_allow_dynamic_sysbus_dev(mc, TYPE_RAMFB_DEVICE); + + /* + * pcie host bridge (gpex) on microvm has no io address window, + * so reserving io space is not going to work. Turn it off. + */ + object_register_sugar_prop("pcie-root-port", "io-reserve", "0", true); } static const TypeInfo microvm_machine_info = { So, I think we can drop patch #1. Want me respin the series, or can you simply drop the patch on merge? thanks, Gerd