From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mx.groups.io with SMTP id smtpd.web09.3062.1654545238149979493 for ; Mon, 06 Jun 2022 12:53:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=hKIIoX3T; spf=pass (domain: gmail.com, ip: 209.85.215.169, mailfrom: kuqin12@gmail.com) Received: by mail-pg1-f169.google.com with SMTP id s68so13776557pgs.10 for ; Mon, 06 Jun 2022 12:53:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dUSreuFlBJCNeWeOoBG7O7tCDE3vJKP2C89h2y0lZac=; b=hKIIoX3TivFrPRRnw/eqn3ttIzqFFb6QuZ29zMHVKtxKGc/XerA0Tlf7oweWS7LThf ixucOZICpmMoEJmIjnGWAEJgiWp9pnBZHMv7AleMRw+eI2w4rFGkhJgjMzEvJAu0g30u t1fkd7sZvhuK5XaHyiOLejyA9L/Iktnw0w1tEEMVL1huUHsfPmn4k/cPpznUbo+7Y2fO dwtXbNkjZSXK5I0QoutGT79CSPA8qwj7hIAHV0zX87p4Ni6vRC0A2RoFaC4f5YzcpHEr GXUtGMkVkDGHDsda7ICEmZ9pQAYA/tdJ5daDmsp416mgZ7qxwhYeiijB60WOBG0LSkvS NxuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dUSreuFlBJCNeWeOoBG7O7tCDE3vJKP2C89h2y0lZac=; b=vYSHqWlJQERvVeO+KsUY31TSmTEWWmv1Gmy6xh6NBrWNkV386bu02M9vdqjWOAQztx UFvEZuISQnu8cyOwCsTOSJr0VzBIL1ycOeovegjUyibWxr4SB/mtlSgIkG1jWbOtnC0f n3vtVqQqmP6PY4yoYfC3xG9U73uG3nSZPwl6Ugp48mDnIuZO42Z4okm0cc7AuWm4qAe6 KpInFOOj8HNB6I2ieimePv4o2ZqFT58/0AcMpfdUT0W/e31QLA2CL6Pd7MVs74vQ0Vvg 7TPs1/iW/8Cs/3pHHC4SokkIcsHT95aH+loAdaamkJQ/n/2Cng5TcGhuZelneXiCiaUe 38lg== X-Gm-Message-State: AOAM530vMRxKwF82Tw/kQAevd/kBNndrnQxHGyTyPT0VIST8098ZFkWs JWkdM6D6SCs2omhh8s95OxhNtuhCTeoUPw== X-Google-Smtp-Source: ABdhPJwRiwqHtjGwcmo3Zlyw0wOfRc5tV2Pu6p00uxvAtVCB43qetMVDjNk3kVzZAxkOSt3bWvZABA== X-Received: by 2002:a62:b60f:0:b0:508:2a61:2c8b with SMTP id j15-20020a62b60f000000b005082a612c8bmr92825369pff.2.1654545237523; Mon, 06 Jun 2022 12:53:57 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([50.35.66.9]) by smtp.gmail.com with ESMTPSA id p2-20020a170902c70200b001617541c94fsm10911707plp.60.2022.06.06.12.53.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 12:53:57 -0700 (PDT) From: "Kun Qin" To: devel@edk2.groups.io Cc: Sean Brogan , Bret Barkelew , Michael D Kinney , Liming Gao , Michael Kubacki Subject: [PATCH V1 1/1] .pytool: UncrustifyCheck: Set IgnoreFiles path relative to package path Date: Mon, 6 Jun 2022 12:52:54 -0700 Message-Id: <20220606195254.348-2-kuqin12@gmail.com> X-Mailer: git-send-email 2.35.1.windows.2 In-Reply-To: <20220606195254.348-1-kuqin12@gmail.com> References: <20220606195254.348-1-kuqin12@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3942 `IgnoreFiles` tag is specified in the CI YAML files in each individual packages. The current logic for UncrustifyCheck script bases specified file paths from workspace, which requires the package name to be included in each entry. This change updates the ignore checking logic to be based on current package path in order to reduce redundancy. It also keeps the consistency of `IgnoreFiles` field other pytools such as SpellCheck and EccCheck. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Cc: Michael Kubacki Signed-off-by: Kun Qin --- .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py index 00d78864656f..8dc9ffe6945a 100644 --- a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py +++ b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py @@ -290,7 +290,7 @@ class UncrustifyCheck(ICiBuildPlugin): # This information is only used for reporting (not used here) and # the ignore lines are being passed directly as they are given to # this plugin. - return parse_gitignore_lines(ignored_files, "Package configuration file", self._abs_workspace_path) + return parse_gitignore_lines(ignored_files, "Package configuration file", self._abs_package_path) def _get_git_ignored_paths(self) -> List[str]: """" -- 2.35.1.windows.2