From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web11.10672.1654598092786904821
 for <devel@edk2.groups.io>;
 Tue, 07 Jun 2022 03:34:53 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=h7ZVLIZW;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1654598091;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=JdOuqNDbX9+3ILEJxiPwQzAKPGupqdFZk8DWRF+Rw+A=;
	b=h7ZVLIZWR9EG0YcETui0aP79qheG9gsf4MXybN6I7JNCtRscu1c9Vr5mJw72vxMDGG/L16
	i8nr458byYnnXygQBOsdRhexkIO9JfYYTbjqL2RcdKsTK7wzMY0jaqA6qPiIZHu8OCMzH3
	SBCqa6b2geJ3XqSJJ/JH4e2snLIiqwI=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-224-J3f1i_VBOx2NJJkqTADSfg-1; Tue, 07 Jun 2022 06:34:46 -0400
X-MC-Unique: J3f1i_VBOx2NJJkqTADSfg-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5F2203801151;
	Tue,  7 Jun 2022 10:34:46 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.40])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 2B17D2166B26;
	Tue,  7 Jun 2022 10:34:46 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 7DFC31800081; Tue,  7 Jun 2022 12:34:43 +0200 (CEST)
Date: Tue, 7 Jun 2022 12:34:43 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Jiewen Yao <jiewen.yao@intel.com>,
	Jian J Wang <jian.j.wang@intel.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH 0/3] Introduce SecTpmMeasurementLibTdx
Message-ID: <20220607103443.l2dmwr36ducf4xxx@sirius.home.kraxel.org>
References: <cover.1654390043.git.min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <cover.1654390043.git.min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Jun 05, 2022 at 09:02:45AM +0800, Min Xu wrote:
> SecTpmMeasurementLibTdx is an instance of TpmMeasurement lib in SEC phase.
> It provides RTMR based measurement functions for Intel Tdx guest.
> 
> Commit a708536dce introduces SecMeasurementLibTdx which provides the same
> functions. But it is not an instance of TpmMeasurementLib.
> We have updated DxeTpmMeasurementLib (which is an instance of
> TpmMeasurementLib) to support RTMR based measurement. To make the design
> consistent, SecTpmMeasurementLibTdx is introduced. After that
> SecMeasurementLibTdx is removed.

So, what is the difference?  Just make the calling convention compatible
with TpmMeasurementLib?

take care,
  Gerd