From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.10704.1654598375768937744 for ; Tue, 07 Jun 2022 03:39:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DeFMXLqR; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654598375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G/+JOBG2IKFikDUe5wuLhJocyh2AP1+zc02lY0kb2wc=; b=DeFMXLqRd1Dk1eXpQIIb9ez91UstSLC3KFZF5p/7mM4GvxafExWKXE/w1ILaHhO9UzmAiF 3DHaeufMsax3tXHqiBvlas/sL2/jiV+HZ9HPXt0ZfS9BK9HtKu6VMJeU/v2pC6x2j7lQAO xgBeXS/CE0jneNCzPJkUSIX4JwF3OuM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-329-W2K6e9t_N2GGGwzShfa_yg-1; Tue, 07 Jun 2022 06:39:33 -0400 X-MC-Unique: W2K6e9t_N2GGGwzShfa_yg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2642F18E005B; Tue, 7 Jun 2022 10:39:33 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CE00C40336A; Tue, 7 Jun 2022 10:39:32 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 6EB921800081; Tue, 7 Jun 2022 12:39:30 +0200 (CEST) Date: Tue, 7 Jun 2022 12:39:30 +0200 From: "Gerd Hoffmann" To: Min Xu Cc: devel@edk2.groups.io, Michael D Kinney , Liming Gao , Zhiguang Liu , Erdem Aktas , James Bottomley , Jiewen Yao , Tom Lendacky Subject: Re: [PATCH 02/14] MdePkg: Increase EFI_RESOURCE_MAX_MEMORY_TYPE Message-ID: <20220607103930.nx3jcln56ttorv3d@sirius.home.kraxel.org> References: <13769f246c324cdd21c7e22e42fa3f92cbaa6a1d.1654420875.git.min.m.xu@intel.com> MIME-Version: 1.0 In-Reply-To: <13769f246c324cdd21c7e22e42fa3f92cbaa6a1d.1654420875.git.min.m.xu@intel.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 06, 2022 at 10:59:50AM +0800, Min Xu wrote: > From: Min M Xu > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 > > EFI_RESOURCE_MEMORY_UNACCEPTED is defined for unaccepted memory. > But this defitinion has not been officially in the PI spec. Base > on the code-first we define EFI_RESOURCE_MEMORY_UNACCEPTED at > MdeModulePkg/Include/Pi/PrePiHob.h and update EFI_RESOURCE_MAX_MEMORY_TYPE > to 8. After EFI_RESOURCE_MEMORY_UNACCEPTED is officially published > in PI spec, we will re-visit here. > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Erdem Aktas > Cc: Gerd Hoffmann > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Tom Lendacky > Signed-off-by: Min Xu > --- > MdePkg/Include/Pi/PiHob.h | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/MdePkg/Include/Pi/PiHob.h b/MdePkg/Include/Pi/PiHob.h > index e9f0ab4309d1..9af2e957fee5 100644 > --- a/MdePkg/Include/Pi/PiHob.h > +++ b/MdePkg/Include/Pi/PiHob.h > @@ -232,7 +232,16 @@ typedef UINT32 EFI_RESOURCE_TYPE; > #define EFI_RESOURCE_MEMORY_MAPPED_IO_PORT 0x00000004 > #define EFI_RESOURCE_MEMORY_RESERVED 0x00000005 > #define EFI_RESOURCE_IO_RESERVED 0x00000006 > -#define EFI_RESOURCE_MAX_MEMORY_TYPE 0x00000007 > +// > +// EFI_RESOURCE_MEMORY_UNACCEPTED is defined for unaccepted memory. > +// But this defitinion has not been officially in the PI spec. Base > +// on the code-first we define EFI_RESOURCE_MEMORY_UNACCEPTED at > +// MdeModulePkg/Include/Pi/PrePiHob.h and update EFI_RESOURCE_MAX_MEMORY_TYPE > +// to 8. After EFI_RESOURCE_MEMORY_UNACCEPTED is officially published > +// in PI spec, we will re-visit here. > +// > +// #define EFI_RESOURCE_MEMORY_UNACCEPTED 0x00000007 > +#define EFI_RESOURCE_MAX_MEMORY_TYPE 0x00000008 Shouldn't this be handled in PrePiHob.h too? i.e. update EFI_RESOURCE_MAX_MEMORY_TYPE with #undef + #define there? take care, Gerd