From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.10972.1654600077345135908 for ; Tue, 07 Jun 2022 04:07:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=N9VCxRqt; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654600076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=j21gX3AYUgfOxqLY6ICX4yKaySQskB00Pj41m9cWCkE=; b=N9VCxRqtJI0BealZ+ci2i7knwTvh+UWqkF8OPyJsypfYcDzaYdE/LlJ6tsER/nG5e7TGzt f1ax/R4dJP32lCEyYRWecZFOzTrW+PnG3vRV0ggJSsdmmKeIFNQTvv/zJtgmw7pMvuS7Qd iCfMmYWsR5x76rfFCye5zYiR2iS6Z4E= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-259-TuZPEvQ7Plalfop9JEAshg-1; Tue, 07 Jun 2022 07:07:53 -0400 X-MC-Unique: TuZPEvQ7Plalfop9JEAshg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D647C2999B3D; Tue, 7 Jun 2022 11:07:52 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A75E6492C3B; Tue, 7 Jun 2022 11:07:52 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id F2FDF1800081; Tue, 7 Jun 2022 13:07:49 +0200 (CEST) Date: Tue, 7 Jun 2022 13:07:49 +0200 From: "Gerd Hoffmann" To: Jiri Slaby Cc: devel@edk2.groups.io Subject: Re: [edk2-devel] ovmf miscompiles with gcc-12 Message-ID: <20220607110749.wyg7trlelht3cag5@sirius.home.kraxel.org> References: <887c3f4f-c279-bd59-d92d-25922faae6dc@kernel.org> <20220607103120.zvgofggypzhdms5m@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 07, 2022 at 12:38:46PM +0200, Jiri Slaby wrote: > Hi, > > On 07. 06. 22, 12:31, Gerd Hoffmann wrote: > > > The reason is TemporaryRamMigration() overwrites rbp unconditionally -- it > > > adds an offset to rbp even if rbp is NOT used as a frame pointer > > > > > Now, what is the right way to fix this? Do the SetJump/LongJump in assembly > > > and wrap it into push rbp/pop rbp? > > > > push/pop rbp will break in case frame pointers are used, no? > > Yes, see the downstream bug at: > > https://bugzilla.suse.com/show_bug.cgi?id=1199597#c45 > > and read further. > > > I think essentially the code needs to know whenever frame pointers are > > used or not and then update (or not) rbp depending on that. Update > > compiler flags to explicitly set -f(no-)omit-frame-pointer, also add > > -D OMIT_FRAME_POINTER=1, the compile conditionally on OMIT_FRAME_POINTER? > > Yes, the comment above mentions this too (cf. CONFIG_FRAME_POINTER in the > kernel). So see the downstream bugzilla for discussion. Ok. So what is the status here? Someone working on patches? > The upstream bugzilla needs an account which I don't have and cannot create > automatically. It needs manual intervention and I am too lazy to do so. It's just an email though: https://github.com/tianocore/tianocore.github.io/wiki/Reporting-Issues Used to be open in the past, as far I know it was closed to get the bugzilla spam bots under control, not to exclude people ... take care, Gerd