From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web09.13404.1654613134671530308
 for <devel@edk2.groups.io>;
 Tue, 07 Jun 2022 07:45:34 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=K43EUDjg;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1654613133;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=uhF+z67FDJTxdyWR7cME3TPLbVxwr8DnaDLddyWN0TA=;
	b=K43EUDjgs8TTmhnugTlA7Zx1LR1z5wERMXGbI0JECE0a+uoCn5tZnxMtSjPFUVQrzrT2D6
	tMsH6OjfsbXqbcl6NPJumprhJcP8JrbqAadRvkss5TCCaY01yO/7ADUU/vRlSwWo6mUnIb
	ueNErKHfoJx3I4NUiiwhIBf/XQJ/wKY=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-641-jQsjdk3LOuSfO4lTbLsRXg-1; Tue, 07 Jun 2022 10:45:31 -0400
X-MC-Unique: jQsjdk3LOuSfO4lTbLsRXg-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B6B4338173C7;
	Tue,  7 Jun 2022 14:45:30 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.40])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 65BEC2166B29;
	Tue,  7 Jun 2022 14:45:30 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id CC64C1800081; Tue,  7 Jun 2022 16:45:25 +0200 (CEST)
Date: Tue, 7 Jun 2022 16:45:25 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	Pawel Polawski <ppolawsk@redhat.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Oliver Steffen <osteffen@redhat.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	"Aktas, Erdem" <erdemaktas@google.com>,
	"Feng, Bob C" <bob.c.feng@intel.com>,
	"Chen, Christine" <yuwei.chen@intel.com>,
	"Gao, Liming" <gaoliming@byosoft.com.cn>,
	"Xu, Min M" <min.m.xu@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [edk2-devel] [PATCH v4 1/1] OvmfPkg/Sec: fix stack switch
Message-ID: <20220607144525.r625m3fe2koyqiyn@sirius.home.kraxel.org>
References: <20220607123905.2980161-1-kraxel@redhat.com>
 <MW4PR11MB5872125C32033C49632E63AA8CA59@MW4PR11MB5872.namprd11.prod.outlook.com>
MIME-Version: 1.0
In-Reply-To: <MW4PR11MB5872125C32033C49632E63AA8CA59@MW4PR11MB5872.namprd11.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jun 07, 2022 at 01:43:00PM +0000, Yao, Jiewen wrote:
> Hello
> As far as I know the TemporaryRamMigration() is an optional PPI according to PI spec, I forget why we add it in the beginning.

git log isn't very helpful here either, seems to date back to pre-git
times without descriptive commit messages.

just commenting it out doesn't work, so probably there is some reason
which is valid still ...

take care,
  Gerd