From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, jiewen.yao@intel.com
Cc: Pawel Polawski <ppolawsk@redhat.com>,
Brijesh Singh <brijesh.singh@amd.com>,
Oliver Steffen <osteffen@redhat.com>,
James Bottomley <jejb@linux.ibm.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
"Aktas, Erdem" <erdemaktas@google.com>,
"Feng, Bob C" <bob.c.feng@intel.com>,
"Chen, Christine" <yuwei.chen@intel.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>,
"Xu, Min M" <min.m.xu@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [edk2-devel] [PATCH v4 1/1] OvmfPkg/Sec: fix stack switch
Date: Wed, 8 Jun 2022 10:59:23 +0200 [thread overview]
Message-ID: <20220608085923.iujk4al6etnowm4l@sirius.home.kraxel.org> (raw)
In-Reply-To: <MW4PR11MB58721566133D48CB1E13A5C18CA49@MW4PR11MB5872.namprd11.prod.outlook.com>
On Wed, Jun 08, 2022 at 06:54:05AM +0000, Yao, Jiewen wrote:
> Hey Gerd
> CI failed - https://github.com/tianocore/edk2/pull/2954
Oh.
> Have you run the CI before you submit the patch?
Nope.
According to the gcc man page -fomit-frame-pointer is enabled by default
for -O1 (and higher levels), so I expected -fomit-frame-pointer being
used already implicitly. Added it explicitly more for documentation and
clarity than for an actual change.
Apparently this not the case though. Maybe older gcc versions have
different defaults. I'll investigate.
take care,
Gerd
next prev parent reply other threads:[~2022-06-08 8:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 12:39 [PATCH v4 1/1] OvmfPkg/Sec: fix stack switch Gerd Hoffmann
2022-06-07 13:43 ` [edk2-devel] " Yao, Jiewen
2022-06-07 14:45 ` Gerd Hoffmann
2022-06-07 14:58 ` Yao, Jiewen
2022-06-08 6:54 ` Yao, Jiewen
2022-06-08 8:59 ` Gerd Hoffmann [this message]
2022-06-08 10:09 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220608085923.iujk4al6etnowm4l@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox