From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.4164.1654678773156735746 for ; Wed, 08 Jun 2022 01:59:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=awVz0ieh; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654678772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Alv8HD0+2TSWA8o8J5PIRkNbVTZ0g6bIupA3XKO5mCY=; b=awVz0iehbJ2Y3XWM40j3FMRPpSI3BsU8dybbLIlaRHj0bvvD4fZjfTZnjk+AoSBSn2RdDI DY2eTU927mTgQ5JPdtv7sdPykQLde0CGQRQdH6l8DahnYTCzFK7QWC/h+HbYt/n+s5Xps2 fWzB55lqQ2J9w0cdrkBhPZrL9wBSdKQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-335-hi7mZ0RLPh-uWikVB85NOw-1; Wed, 08 Jun 2022 04:59:27 -0400 X-MC-Unique: hi7mZ0RLPh-uWikVB85NOw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 69748804196; Wed, 8 Jun 2022 08:59:26 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DFFA31415100; Wed, 8 Jun 2022 08:59:25 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id DEE1E18003AA; Wed, 8 Jun 2022 10:59:23 +0200 (CEST) Date: Wed, 8 Jun 2022 10:59:23 +0200 From: "Gerd Hoffmann" To: devel@edk2.groups.io, jiewen.yao@intel.com Cc: Pawel Polawski , Brijesh Singh , Oliver Steffen , James Bottomley , Ard Biesheuvel , "Aktas, Erdem" , "Feng, Bob C" , "Chen, Christine" , "Gao, Liming" , "Xu, Min M" , Tom Lendacky , "Justen, Jordan L" , Jiri Slaby Subject: Re: [edk2-devel] [PATCH v4 1/1] OvmfPkg/Sec: fix stack switch Message-ID: <20220608085923.iujk4al6etnowm4l@sirius.home.kraxel.org> References: <20220607123905.2980161-1-kraxel@redhat.com> <20220607144525.r625m3fe2koyqiyn@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 08, 2022 at 06:54:05AM +0000, Yao, Jiewen wrote: > Hey Gerd > CI failed - https://github.com/tianocore/edk2/pull/2954 Oh. > Have you run the CI before you submit the patch? Nope. According to the gcc man page -fomit-frame-pointer is enabled by default for -O1 (and higher levels), so I expected -fomit-frame-pointer being used already implicitly. Added it explicitly more for documentation and clarity than for an actual change. Apparently this not the case though. Maybe older gcc versions have different defaults. I'll investigate. take care, Gerd