public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Ni, Ray" <ray.ni@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Wang, Jian J" <jian.j.wang@intel.com>,
	"Wu, Jiaxin" <jiaxin.wu@intel.com>,
	Sean Brogan <sean.brogan@microsoft.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	"Liu, Zhiguang" <zhiguang.liu@intel.com>,
	"Lu, Xiaoyu1" <xiaoyu1.lu@intel.com>,
	Pawel Polawski <ppolawsk@redhat.com>,
	Sami Mujawar <sami.mujawar@arm.com>,
	Maciej Rabeda <maciej.rabeda@linux.intel.com>,
	"Feng, Bob C" <bob.c.feng@intel.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	Andrew Fish <afish@apple.com>,
	Bret Barkelew <Bret.Barkelew@microsoft.com>,
	Alexei Fedorov <Alexei.Fedorov@arm.com>,
	"Dong, Guo" <guo.dong@intel.com>,
	"kilian_kegel@hotmail.com" <kilian_kegel@hotmail.com>,
	Maurice Ma <maurice.ma@intel.com>,
	Siyuan Fu <siyuan.fu@intel.com>,
	"Chang, Abner" <abner.chang@hpe.com>,
	"Gao, Zhichao" <zhichao.gao@intel.com>,
	"Xu, Wei6" <wei6.xu@intel.com>,
	Supreeth Venkatesh <supreeth.venkatesh@arm.com>,
	Julien Grall <julien@xen.org>,
	"Schaefer, Daniel" <daniel.schaefer@hpe.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	"Jiang, Guomin" <guomin.jiang@intel.com>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	Oliver Steffen <osteffen@redhat.com>,
	"Boeuf, Sebastien" <sebastien.boeuf@intel.com>,
	"You, Benjamin" <benjamin.you@intel.com>,
	"Xu, Min M" <min.m.xu@intel.com>,
	Rebecca Cran <rebecca@bsdio.com>,
	"Wang, Nickle" <nickle.wang@hpe.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Peter Grehan <grehan@freebsd.org>,
	"Aktas, Erdem" <erdemaktas@google.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	James Bottomley <jejb@linux.ibm.com>,
	"Chen, Christine" <yuwei.chen@intel.com>,
	"Gao, Liming" <gaoliming@byosoft.com.cn>,
	Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH v4 4/9] MdePkg/CompilerIntrinsicsLib: move ia32 intrinsics and strcmp
Date: Thu, 9 Jun 2022 12:41:48 +0200	[thread overview]
Message-ID: <20220609104148.fbx44ggajmxpqmre@sirius.home.kraxel.org> (raw)
In-Reply-To: <MWHPR11MB16316DA02F0BC13BFEF3DBB08CA79@MWHPR11MB1631.namprd11.prod.outlook.com>

On Thu, Jun 09, 2022 at 09:34:10AM +0000, Ni, Ray wrote:
> Do you think maybe creating a CompilerIntrinsicLib.h in MdePkg/Include/Library/ helps people understand how many intrinsic functions are provided for different ARCH?

Documenting the intrinsics supported looks useful to me.

Not sure a header file would be the best choice for that though given
that those calls are generated by the compiler not written into source
code.

take care,
  Gerd


  reply	other threads:[~2022-06-09 10:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-03 12:26 [PATCH v4 0/9] consolidate compiler intrinsics Gerd Hoffmann
2022-06-03 12:26 ` [PATCH v4 1/9] MdePkg: promote CompilerIntrinsicsLib from ArmPkg to MdePkg Gerd Hoffmann
2022-06-03 12:26 ` [PATCH v4 2/9] MdePkg/CompilerIntrinsicsLib: fix msft sources for x64 Gerd Hoffmann
2022-06-03 12:26 ` [PATCH v4 3/9] MdePkg/CompilerIntrinsicsLib: move size_t typedef to header file Gerd Hoffmann
2022-06-03 12:26 ` [PATCH v4 4/9] MdePkg/CompilerIntrinsicsLib: move ia32 intrinsics and strcmp Gerd Hoffmann
2022-06-09  3:57   ` Ni, Ray
2022-06-09  6:33     ` Gerd Hoffmann
2022-06-09  9:34       ` Ni, Ray
2022-06-09 10:41         ` Gerd Hoffmann [this message]
2022-06-03 12:26 ` [PATCH v4 5/9] MdePkg/CompilerIntrinsicsLib: copy over intrinsics from edk2-libc repo Gerd Hoffmann
2022-06-03 12:26 ` [PATCH v4 6/9] MdePkg/CompilerIntrinsicsLib: drop include from Gcc.c Gerd Hoffmann
2022-06-03 12:26 ` [PATCH v4 7/9] MdePkg/CompilerIntrinsicsLib: drop debug logging " Gerd Hoffmann
2022-06-03 12:26 ` [PATCH v4 8/9] MdePkg/CompilerIntrinsicsLib: remove duplicate functions " Gerd Hoffmann
2022-06-03 12:26 ` [PATCH v4 9/9] MdePkg/CompilerIntrinsicsLib: add new sources to CompilerIntrinsicsLib.inf Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220609104148.fbx44ggajmxpqmre@sirius.home.kraxel.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox