From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web08.9683.1654771317085598093 for ; Thu, 09 Jun 2022 03:41:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PxszSyrA; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654771316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=smDkD14mKTOg2y4VwFZ78U2fuBIGqMmqH0TJ4JC8Pe4=; b=PxszSyrA+qpooD7oL2K62y2zQjeL1PMNVmWW0wC91OsFRhCuDgt3HAbwprqve1GEBlbTOa JxZbZfnMISeJoQorMs77utuPJVLXxSSwDYzE96lpF7oAP9el4pOHnY9XboRizDr0/tYgCq BJsJSZE/5VYT/ywCCBaKn+75GH2oaXs= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-447-exLOy30NMyGsdOKwmF1gFQ-1; Thu, 09 Jun 2022 06:41:52 -0400 X-MC-Unique: exLOy30NMyGsdOKwmF1gFQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 54D4A1C0514E; Thu, 9 Jun 2022 10:41:50 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B2F1DC53360; Thu, 9 Jun 2022 10:41:49 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 502F61800094; Thu, 9 Jun 2022 12:41:48 +0200 (CEST) Date: Thu, 9 Jun 2022 12:41:48 +0200 From: "Gerd Hoffmann" To: "Ni, Ray" Cc: "devel@edk2.groups.io" , "Wang, Jian J" , "Wu, Jiaxin" , Sean Brogan , Anthony Perard , Leif Lindholm , "Liu, Zhiguang" , "Lu, Xiaoyu1" , Pawel Polawski , Sami Mujawar , Maciej Rabeda , "Feng, Bob C" , "Yao, Jiewen" , Andrew Fish , Bret Barkelew , Alexei Fedorov , "Dong, Guo" , "kilian_kegel@hotmail.com" , Maurice Ma , Siyuan Fu , "Chang, Abner" , "Gao, Zhichao" , "Xu, Wei6" , Supreeth Venkatesh , Julien Grall , "Schaefer, Daniel" , Ard Biesheuvel , "Jiang, Guomin" , "Justen, Jordan L" , Oliver Steffen , "Boeuf, Sebastien" , "You, Benjamin" , "Xu, Min M" , Rebecca Cran , "Wang, Nickle" , "Kinney, Michael D" , Tom Lendacky , Peter Grehan , "Aktas, Erdem" , Brijesh Singh , James Bottomley , "Chen, Christine" , "Gao, Liming" , Ard Biesheuvel Subject: Re: [PATCH v4 4/9] MdePkg/CompilerIntrinsicsLib: move ia32 intrinsics and strcmp Message-ID: <20220609104148.fbx44ggajmxpqmre@sirius.home.kraxel.org> References: <20220603122638.1547060-1-kraxel@redhat.com> <20220603122638.1547060-5-kraxel@redhat.com> <20220609063339.wwme7adu6hl27nsq@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 09, 2022 at 09:34:10AM +0000, Ni, Ray wrote: > Do you think maybe creating a CompilerIntrinsicLib.h in MdePkg/Include/Library/ helps people understand how many intrinsic functions are provided for different ARCH? Documenting the intrinsics supported looks useful to me. Not sure a header file would be the best choice for that though given that those calls are generated by the compiler not written into source code. take care, Gerd