public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Pranav Madhu" <pranav.madhu@arm.com>
To: devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Sami Mujawar <sami.mujawar@arm.com>
Subject: [edk2-platforms][PATCH V1 7/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-N2-Cfg1
Date: Thu,  9 Jun 2022 23:49:55 +0530	[thread overview]
Message-ID: <20220609181955.3018033-8-pranav.madhu@arm.com> (raw)
In-Reply-To: <20220609181955.3018033-1-pranav.madhu@arm.com>

RD-N2-Cfg1 platform supports only the platform co-ordinated LPI. So fix
the LPI Level ID value accordingly.

Additionally, as this platform does not support residency counter, clear
the residency counter frequency from _LPI object's control method. As
the cpus are directly connected to the interconnect on this platform,
remove the cluster _LPI control method as well.

Signed-off-by: Pranav Madhu <pranav.madhu@arm.com>
---
 Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Dsdt.asl | 54 ++------------------
 1 file changed, 4 insertions(+), 50 deletions(-)

diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Dsdt.asl b/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Dsdt.asl
index b6decc77f480..2e9e588806c6 100644
--- a/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Dsdt.asl
+++ b/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Dsdt.asl
@@ -68,38 +68,16 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", "ARMSGI",
       Return (Arg3)
     }
 
-    Name (CLPI, Package () {  /* LPI for Cluster, support 1 LPI state */
-      0,                      // Version
-      0,                      // Level Index
-      1,                      // Count
-      Package () {            // Power Gating state for Cluster
-        2500,                 // Min residency (uS)
-        1150,                 // Wake latency (uS)
-        1,                    // Flags
-        1,                    // Arch Context Flags
-        100,                  // Residency Counter Frequency
-        0,                    // No Parent State
-        0x00000020,           // Integer Entry method
-        ResourceTemplate () { // Null Residency Counter
-          Register (SystemMemory, 0, 0, 0, 0)
-        },
-        ResourceTemplate () { // Null Usage Counter
-          Register (SystemMemory, 0, 0, 0, 0)
-        },
-        "LPI2-Cluster"
-      },
-    })
-
     Name (PLPI, Package () {  /* LPI for Processor, support 2 LPI states */
       0,                      // Version
-      1,                      // Level Index
+      0,                      // Level Index
       2,                      // Count
       Package () {            // WFI for CPU
         1,                    // Min residency (uS)
         1,                    // Wake latency (uS)
         1,                    // Flags
         0,                    // Arch Context lost Flags (no loss)
-        100,                  // Residency Counter Frequency
+        0,                    // Residency Counter Frequency
         0,                    // No parent state
         ResourceTemplate () { // Register Entry method
           Register (FFixedHW,
@@ -122,8 +100,8 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", "ARMSGI",
         350,                  // Wake latency (uS)
         1,                    // Flags
         1,                    // Arch Context lost Flags (Core context lost)
-        100,                  // Residency Counter Frequency
-        1,                    // Parent node can be in any shallower state
+        0,                    // Residency Counter Frequency
+        0,                    // No parent state
         ResourceTemplate () { // Register Entry method
           Register (FFixedHW,
             32,               // Bit Width
@@ -145,9 +123,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", "ARMSGI",
     Device (CL00) {   // Cluster 0
       Name (_HID, "ACPI0010")
       Name (_UID, 0)
-      Method (_LPI, 0, NotSerialized) {
-        Return (\_SB.CLPI)
-      }
 
       Device (CP00) { // Neoverse N2 core 0
         Name (_HID, "ACPI0007")
@@ -172,9 +147,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", "ARMSGI",
     Device (CL01) {   // Cluster 1
       Name (_HID, "ACPI0010")
       Name (_UID, 1)
-      Method (_LPI, 0, NotSerialized) {
-        Return (\_SB.CLPI)
-      }
 
       Device (CP01) { // Neoverse N2 core 1
         Name (_HID, "ACPI0007")
@@ -199,9 +171,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", "ARMSGI",
     Device (CL02) {   // Cluster 2
       Name (_HID, "ACPI0010")
       Name (_UID, 2)
-      Method (_LPI, 0, NotSerialized) {
-        Return (\_SB.CLPI)
-      }
 
       Device (CP02) { // Neoverse N2 core 2
         Name (_HID, "ACPI0007")
@@ -226,9 +195,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", "ARMSGI",
     Device (CL03) {   // Cluster 3
       Name (_HID, "ACPI0010")
       Name (_UID, 3)
-      Method (_LPI, 0, NotSerialized) {
-        Return (\_SB.CLPI)
-      }
 
       Device (CP03) { // Neoverse N2 core 3
         Name (_HID, "ACPI0007")
@@ -253,9 +219,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", "ARMSGI",
     Device (CL04) {   // Cluster 4
       Name (_HID, "ACPI0010")
       Name (_UID, 4)
-      Method (_LPI, 0, NotSerialized) {
-        Return (\_SB.CLPI)
-      }
 
       Device (CP04) { // Neoverse N2 core 4
         Name (_HID, "ACPI0007")
@@ -280,9 +243,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", "ARMSGI",
     Device (CL05) {   // Cluster 5
       Name (_HID, "ACPI0010")
       Name (_UID, 5)
-      Method (_LPI, 0, NotSerialized) {
-        Return (\_SB.CLPI)
-      }
 
       Device (CP05) { // Neoverse N2 core 5
         Name (_HID, "ACPI0007")
@@ -307,9 +267,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", "ARMSGI",
     Device (CL06) {   // Cluster 6
       Name (_HID, "ACPI0010")
       Name (_UID, 6)
-      Method (_LPI, 0, NotSerialized) {
-        Return (\_SB.CLPI)
-      }
 
       Device (CP06) { // Neoverse N2 core 6
         Name (_HID, "ACPI0007")
@@ -334,9 +291,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", "ARMSGI",
     Device (CL07) {   // Cluster 7
       Name (_HID, "ACPI0010")
       Name (_UID, 7)
-      Method (_LPI, 0, NotSerialized) {
-        Return (\_SB.CLPI)
-      }
 
       Device (CP07) { // Neoverse N2 core 7
         Name (_HID, "ACPI0007")
-- 
2.25.1


  parent reply	other threads:[~2022-06-09 18:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-09 18:19 [edk2-platforms][PATCH V1 0/7] Fix ACPI Low Power Idle states for RD platforms Pranav Madhu
2022-06-09 18:19 ` [edk2-platforms][PATCH V1 1/7] Platform/Sgi: Fix ACPI Low Power Idle states for SGI575 Pranav Madhu
2022-06-09 18:19 ` [edk2-platforms][PATCH V1 2/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-N1-Edge Pranav Madhu
2022-06-09 18:19 ` [edk2-platforms][PATCH V1 3/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-N1-Edge-X2 Pranav Madhu
2022-06-09 18:19 ` [edk2-platforms][PATCH V1 4/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-V1 Pranav Madhu
2022-06-09 18:19 ` [edk2-platforms][PATCH V1 5/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-V1-MC Pranav Madhu
2022-06-09 18:19 ` [edk2-platforms][PATCH V1 6/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-N2 Pranav Madhu
2022-06-09 18:19 ` Pranav Madhu [this message]
2022-06-11 20:46 ` [edk2-devel] [edk2-platforms][PATCH V1 0/7] Fix ACPI Low Power Idle states for RD platforms Thomas Abraham
2022-06-20 16:53   ` Pranav Madhu
2022-06-21  8:44     ` PierreGondois
2022-06-22  5:39       ` Pranav Madhu
2022-06-23  8:45         ` PierreGondois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220609181955.3018033-8-pranav.madhu@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox