From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io
Cc: Oliver Steffen <osteffen@redhat.com>,
James Bottomley <jejb@linux.ibm.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Yuwei Chen <yuwei.chen@intel.com>,
Brijesh Singh <brijesh.singh@amd.com>,
Erdem Aktas <erdemaktas@google.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Pawel Polawski <ppolawsk@redhat.com>,
Bob Feng <bob.c.feng@intel.com>, Min Xu <min.m.xu@intel.com>
Subject: [PATCH v6 0/3] Fix stack switching, this time for real.
Date: Fri, 10 Jun 2022 13:02:43 +0200 [thread overview]
Message-ID: <20220610110246.2031470-1-kraxel@redhat.com> (raw)
My testing was busted, ran the tests with outdated tools_def
so I didn't notice the patch had zero effect ...
So, revert the broken patch, drop two lines which are not used
anywhere to reduce confusion, then just disable omit-frame-pointers
for ia32 and x64 to get the source tree back into working state
with minimum fuss.
Not fully sure yet how to go forward with that longer-term. Enabling
omit-frame-pointers unconditionally makes the NOOPT noticeable larger,
which is probably the reason why the gcc enables that by default only
for -O1 and higher. So maybe we need different cflags for NOOPT vs.
DEBUG/RELEASE builds.
Or go for a completely different approach, like integrating
DebugAgentLib support into the Pei Dispatcher, so the need to
have a custom TemporaryRamMigration() for that goes away ...
Comments?
take care,
Gerd
Gerd Hoffmann (3):
Revert "OvmfPkg/Sec: fix stack switch"
tools_def: remove GCC_IA32_CC_FLAGS/GCC_X64_CC_FLAGS
tools_def: add -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS
OvmfPkg/Sec/SecMain.c | 4 ----
BaseTools/Conf/tools_def.template | 8 +++-----
2 files changed, 3 insertions(+), 9 deletions(-)
--
2.36.1
next reply other threads:[~2022-06-10 11:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 11:02 Gerd Hoffmann [this message]
2022-06-10 11:02 ` [PATCH v6 1/3] Revert "OvmfPkg/Sec: fix stack switch" Gerd Hoffmann
2022-06-10 13:12 ` [edk2-devel] " Yao, Jiewen
2022-06-10 11:02 ` [PATCH v6 2/3] tools_def: remove GCC_IA32_CC_FLAGS/GCC_X64_CC_FLAGS Gerd Hoffmann
2022-06-10 11:02 ` [PATCH v6 3/3] tools_def: add -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220610110246.2031470-1-kraxel@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox