From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.25745.1654858975927728502 for ; Fri, 10 Jun 2022 04:02:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QsDmP97A; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654858974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JjTVxmMmwBemxmIxjVrgLwJ/yTJloAaRN38aI70+E8Y=; b=QsDmP97Acg+wXyWb7C0ZpUKSZNvEXPI6j6GSHxgz8lZQ9VumNatCrLDfOGdspLWtHbRm9Q 6I+TMnHVwZlMiW5XoBV+mHvqZgUyfi09oMEDEwXjod2ILr715ceOJBlptJYQDUAvtiP7W/ jANFzZRe4A65C92/ty3u21emEj93UL0= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-653-FhLGbdtHOY23y6SnYoPCqA-1; Fri, 10 Jun 2022 07:02:50 -0400 X-MC-Unique: FhLGbdtHOY23y6SnYoPCqA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 410EC39F9CAC; Fri, 10 Jun 2022 11:02:50 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EF87640CF8EF; Fri, 10 Jun 2022 11:02:49 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id C87AB18000AA; Fri, 10 Jun 2022 13:02:46 +0200 (CEST) From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: Oliver Steffen , James Bottomley , Tom Lendacky , Gerd Hoffmann , Jordan Justen , Yuwei Chen , Brijesh Singh , Erdem Aktas , Jiewen Yao , Liming Gao , Ard Biesheuvel , Pawel Polawski , Bob Feng , Min Xu Subject: [PATCH v6 0/3] Fix stack switching, this time for real. Date: Fri, 10 Jun 2022 13:02:43 +0200 Message-Id: <20220610110246.2031470-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit My testing was busted, ran the tests with outdated tools_def so I didn't notice the patch had zero effect ... So, revert the broken patch, drop two lines which are not used anywhere to reduce confusion, then just disable omit-frame-pointers for ia32 and x64 to get the source tree back into working state with minimum fuss. Not fully sure yet how to go forward with that longer-term. Enabling omit-frame-pointers unconditionally makes the NOOPT noticeable larger, which is probably the reason why the gcc enables that by default only for -O1 and higher. So maybe we need different cflags for NOOPT vs. DEBUG/RELEASE builds. Or go for a completely different approach, like integrating DebugAgentLib support into the Pei Dispatcher, so the need to have a custom TemporaryRamMigration() for that goes away ... Comments? take care, Gerd Gerd Hoffmann (3): Revert "OvmfPkg/Sec: fix stack switch" tools_def: remove GCC_IA32_CC_FLAGS/GCC_X64_CC_FLAGS tools_def: add -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS OvmfPkg/Sec/SecMain.c | 4 ---- BaseTools/Conf/tools_def.template | 8 +++----- 2 files changed, 3 insertions(+), 9 deletions(-) -- 2.36.1