From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web08.27001.1654867347159875039
 for <devel@edk2.groups.io>;
 Fri, 10 Jun 2022 06:22:27 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ASOm5W9w;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1654867346;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ww80DCi8+2Oa9ysy7WVtU+bzKtTWarDeKI+UPHMQpHE=;
	b=ASOm5W9wSHzAFXxUknah/M/zl8VFOwZgsNVYbqZu2/h2gjVW3w2JhbCAAAfMrU+5q0WQ9N
	hHxOdGM+88EVuxjA4+5daGSiQQAwtjRkbCSBXSBMTVv+fJ8eXYeQCkZvpmF2pYg7lxyTyH
	XWpIRVCId7EfvG3tLYY60fAUbpiZvek=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-645-y0JxW6vlONKJ3zYSZsxXUw-1; Fri, 10 Jun 2022 09:22:22 -0400
X-MC-Unique: y0JxW6vlONKJ3zYSZsxXUw-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3290C3801156;
	Fri, 10 Jun 2022 13:22:22 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.40])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id E142B40D2827;
	Fri, 10 Jun 2022 13:22:21 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id DFF1E18000AA; Fri, 10 Jun 2022 15:22:10 +0200 (CEST)
Date: Fri, 10 Jun 2022 15:22:10 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V4 5/9] OvmfPkg/IntelTdx: Measure Td HobList and Configuration FV
Message-ID: <20220610132210.54deaotdn32pidui@sirius.home.kraxel.org>
References: <cover.1652686674.git.min.m.xu@intel.com>
 <b54541c4faf455a4360abd112a9bfd11c9ce3583.1652686674.git.min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <b54541c4faf455a4360abd112a9bfd11c9ce3583.1652686674.git.min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, May 16, 2022 at 03:42:19PM +0800, Min Xu wrote:
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853
> 
> TdHobList and Configuration FV are external data provided by Host VMM.
> These are not trusted in Td guest. So they should be validated , measured
> and extended to Td RTMR registers. In the meantime 2 EFI_CC_EVENT_HOB are
> created. These 2 GUIDed HOBs carry the hash value of TdHobList and
> Configuration FV. In DXE phase EFI_CC_EVENT can be created based on these
> 2 GUIDed HOBs.

This breaks booting the IntelTdx build without tdx:

ASSERT /home/kraxel/projects/edk2/SecurityPkg/Library/HashLibTdx/HashLibTdx.c(189): TdIsEnabled ()

take care,
  Gerd