From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by mx.groups.io with SMTP id smtpd.web11.7810.1655314967532670867 for ; Wed, 15 Jun 2022 10:42:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=YroMtGu0; spf=pass (domain: gmail.com, ip: 209.85.222.178, mailfrom: benjamin.doron00@gmail.com) Received: by mail-qk1-f178.google.com with SMTP id b142so9293898qkg.2 for ; Wed, 15 Jun 2022 10:42:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HrInEmMTGi1uoeZGlioisx7vnk0uWrOe8x10+iPVFaU=; b=YroMtGu0h/NnMSqRYn6Fze9aXppXRMnQHwhdBbNFS68ntiQMV2/dZfjnkgyYkP58FP e29FfRUjKuNnWjgHev7POSTHrg3BQjnUfEvVU2TLtQFUeWXtHSm/tZ8Dhqtaq0rwIoMh KfoSvIKURkkfKig2R4+20vwYDeDRDwD18n1J+Mt6NO7CuARbtLAnKXDlZ9NJXkPU5DnC sGLKtQyOBZ8tnFCA9kakJA+yfn+nvi331k19ib2qC8ICBMLgFyVgEvz8IYrBR+4vAIJx 7MCtj9loibPR8SKgm0KEQkWp8AQW43dZ952uhBuhcMcbMWw6M++IVh0jjpYMfDu98Vkx ZkBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HrInEmMTGi1uoeZGlioisx7vnk0uWrOe8x10+iPVFaU=; b=SnMQ6alsWo8LoeK6Nnm3Ard9Pgd1b5Mhux7W+VBem3CNlpTDtDpdbGZJG/zfT24a+d LYAVcJg4flLvSs3zd8pTmFhOcojExD5co/LEFwkc80ABs5ASXN90kRwgR98PP55u0SCq A6Q39NG0yQJujKpvBeIkn0zJ51ZUIt1SOLPo270qkeBQE73SLODTjlJT4iGXm1HCUmat wagnvI0JU35gnY33hdgkZYot8cLXzTYcN+p2d1rSLb6FWabUBPEX+KQLxeEcLb0sGe8c D3nKs+aEwrVfiksbSxeDZEdG7RNaUjCTopYotsaXSwWrCT2PIVPQc7RSaMTVHSHlWsQV LmKw== X-Gm-Message-State: AJIora9Bij9EsguEyXzsw0+22Yabxtm51ARbgkBuCJQkzhpOyyh8zQh5 nPehQWocxmP+OMoDxRcRb4wt38u06/sRDw== X-Google-Smtp-Source: AGRyM1teLBd9joiVsveqondfzoom6IeVpw2vfDNwGz1aE9bDWh0hekX2/HpY9q9sUG/Lr9SM7IYodA== X-Received: by 2002:a05:620a:25c6:b0:699:bc86:6c82 with SMTP id y6-20020a05620a25c600b00699bc866c82mr725727qko.44.1655314966292; Wed, 15 Jun 2022 10:42:46 -0700 (PDT) Return-Path: Received: from aturtleortwo-benjamindomain.. ([2607:f2c0:e98c:e:419d:696a:47d6:732a]) by smtp.gmail.com with ESMTPSA id n22-20020ac85a16000000b00304e2e4bf1esm10138290qta.88.2022.06.15.10.42.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jun 2022 10:42:45 -0700 (PDT) From: "Benjamin Doron" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Isaac Oram , Liming Gao , Eric Dong , Ankit Sinha Subject: [edk2-platforms][PATCH v1] MinPlatformPkg: Update FADT-related PCD defaults to restore behaviour Date: Wed, 15 Jun 2022 13:41:54 -0400 Message-Id: <20220615174154.417436-1-benjamin.doron00@gmail.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Commit f427247 (MinPlatformPkg: Add PCDs to update FADT entries from board package) modified AcpiPlatform flow, altering the FADT for all platforms. Now, because `FadtHeader->Gpe0BlkLen =3D=3D 0`, the Linux kernel prints "irq 9: nobody cared ..." - GPE status cannot be retrieved and at least ACPI SCIs cannot be handled correctly. As the size of this register is the same on Skylake/Kabylake and TigerLake, update the PCD default value. Several FADT register block AccessSize PCDs are updated as well. These fields too are the same between Skylake/Kabylake and TigerLake. However, other fields differ between platforms, such as GPE0 address and the removal of PM{1,2}* addresses, which should be handled in a follow-up. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Cc: Ankit Sinha Signed-off-by: Benjamin Doron --- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec b/Platform/In= tel/MinPlatformPkg/MinPlatformPkg.dec index 68ab1d702d6a..9549c355b122 100644 --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec @@ -123,18 +123,18 @@ gMinPlatformPkgTokenSpaceGuid.PcdAcpiPm2ControlBlockAddress|0x1850|UINT1= 6|0x00010039=0D gMinPlatformPkgTokenSpaceGuid.PcdAcpiPmTimerBlockAddress|0x1808|UINT16|0= x0001003A=0D gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockAddress|0x1880|UINT16|0x00= 01003B=0D - gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockLength|0x00|UINT8|0x000100= 3C=0D + gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockLength|0x20|UINT8|0x000100= 3C=0D gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1BlockAddress|0x0000|UINT16|0x00= 01003D=0D gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1Base|0x00|UINT8|0x00010040=0D - gMinPlatformPkgTokenSpaceGuid.PcdAcpiResetRegAccessSize|0x00|UINT8|0x000= 10042=0D + gMinPlatformPkgTokenSpaceGuid.PcdAcpiResetRegAccessSize|0x01|UINT8|0x000= 10042=0D =0D - gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aEvtBlkAccessSize|0x00|UINT8|0x= 00010043=0D + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aEvtBlkAccessSize|0x02|UINT8|0x= 00010043=0D gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1bEvtBlkAccessSize|0x00|UINT8|0x= 00010044=0D - gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aCntBlkAccessSize|0x00|UINT8|0x= 00010045=0D + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aCntBlkAccessSize|0x02|UINT8|0x= 00010045=0D gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1bCntBlkAccessSize|0x00|UINT8|0x= 00010046=0D gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm2CntBlkAccessSize|0x00|UINT8|0x0= 0010047=0D - gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPmTmrBlkAccessSize|0x00|UINT8|0x00= 010048=0D - gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe0BlkAccessSize|0x00|UINT8|0x000= 10049=0D + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPmTmrBlkAccessSize|0x03|UINT8|0x00= 010048=0D + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe0BlkAccessSize|0x01|UINT8|0x000= 10049=0D gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkAccessSize|0x00|UINT8|0x000= 1004A=0D =0D gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegAddressSpaceId|0x00|= UINT8|0x0001004B=0D --=20 2.36.1