From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, zhiguang.liu@intel.com
Cc: Guo Dong <guo.dong@intel.com>, Ray Ni <ray.ni@intel.com>,
Maurice Ma <maurice.ma@intel.com>,
Benjamin You <benjamin.you@intel.com>,
Sean Rhodes <sean@starlabs.systems>
Subject: Re: [edk2-devel] [PATCH v2] UefiPayloadPkg: Always split page table entry to 4K if it covers stack.
Date: Mon, 20 Jun 2022 12:43:30 +0200 [thread overview]
Message-ID: <20220620104330.nvdw2ogvj6w3r3q6@sirius.home.kraxel.org> (raw)
In-Reply-To: <20220617082803.4428-1-zhiguang.liu@intel.com>
On Fri, Jun 17, 2022 at 04:28:03PM +0800, Zhiguang Liu wrote:
> We observed page fault in the following situation:
> 1.PayloadEntry uses 2M entry in page table to cover DXE stack range.
> 2.In DXE phase, image protection code needs to mark some sub-range in
> this 2M entry as readonly. So the the 2M page table entry is split to
> 512 4K entries, and some of the entries are marked as readonly.
> (the entries covering stack still remain R/W)
> 3.Page fault exception happens when trying to access stack.
>
> Always split the page table entry to 4K if it covers stack to avoid this
> issue.
> More discussion about this issue can be seen at below link
> https://edk2.groups.io/g/devel/topic/91446026
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
prev parent reply other threads:[~2022-06-20 10:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 8:28 [PATCH v2] UefiPayloadPkg: Always split page table entry to 4K if it covers stack Zhiguang Liu
2022-06-20 1:53 ` Ni, Ray
2022-06-20 10:43 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220620104330.nvdw2ogvj6w3r3q6@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox