Re: [PATCH 3/3] OvmfPkg: Initialize NvVarStore with Configuration FV in Td guest

["Gerd Hoffmann" <kraxel@redhat.com>]

> +  UINT8                 *CfvBase;
> +  UINT32                CfvSize;
>  
>    DEBUG ((DEBUG_INFO, "EMU Variable FVB Started\n"));
>  
> @@ -774,6 +776,23 @@ FvbInitialize (
>  
>    mEmuVarsFvb.BufferPtr = Ptr;
>  
> +  //
> +  // In Tdx guest the VarNvStore content should be initialized by the Configuration FV (CFV).
> +  // Integrity of the CFV has been validated by TdxValidateCfv (@PlatformInitLib)
> +  //
> +  if (TdIsEnabled ()) {
> +    CfvBase = (UINT8 *)(UINTN)PcdGet32 (PcdCfvBase);
> +    CfvSize = (UINT32)PcdGet32 (PcdCfvRawDataSize);
> +
> +    if (CfvSize > mEmuVarsFvb.Size) {
> +      DEBUG ((DEBUG_ERROR, "Size of CFV is larger than the EMU Variable FVB.\n"));
> +      ASSERT (FALSE);
> +    } else {
> +      CopyMem (Ptr, CfvBase, CfvSize);
> +      Initialize = FALSE;
> +    }
> +  }

There is PcdEmuVariableNvStoreReserved for that.  How about just
copying the store to ram, then set PcdEmuVariableNvStoreReserved
to the location and let the existing logic handle it?

Also why limit this to tdx?

take care,
  Gerd