From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Xu, Min M" <min.m.xu@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Aktas, Erdem" <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH 3/3] OvmfPkg: Initialize NvVarStore with Configuration FV in Td guest
Date: Thu, 23 Jun 2022 09:23:55 +0200 [thread overview]
Message-ID: <20220623072355.5an4p6gzuxbygokg@sirius.home.kraxel.org> (raw)
In-Reply-To: <PH0PR11MB5064EA95BAAD6A3D694492A1C5B59@PH0PR11MB5064.namprd11.prod.outlook.com>
> > The flag is already there ;)
> SECURE_BOOT_ENABLE is not a build-flag. It can only works in .dsc files.
> The build-flag(SECURE_BOOT_FEATURE_ENABLED) would be defined in .dsc:
> [BuildOptions]
> !if $(SECURE_BOOT_ENABLE) == TRUE
> MSFT:*_*_*_CC_FLAGS = /D SECURE_BOOT_FEATURE_ENABLED
> INTEL:*_*_*_CC_FLAGS = /D SECURE_BOOT_FEATURE_ENABLED
> GCC:*_*_*_CC_FLAGS = -D SECURE_BOOT_FEATURE_ENABLED
> !endif
Ah, I see.
I've expected that to happen automatically, similar to the the linux
kernel, where all CONFIG_* variables are available to both build system
and C source code.
take care,
Gerd
prev parent reply other threads:[~2022-06-23 7:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-18 2:32 [PATCH 0/3] Enable Secure-Boot in Tdx guest Min Xu
2022-06-18 2:32 ` [PATCH 1/3] OvmfPkg: Move TdxValidateCfv from PeilessStartupLib to PlatformInitLib Min Xu
2022-06-18 2:32 ` [PATCH 2/3] OvmfPkg: Validate Cfv integrity in Tdx guest Min Xu
2022-06-18 2:32 ` [PATCH 3/3] OvmfPkg: Initialize NvVarStore with Configuration FV in Td guest Min Xu
2022-06-20 11:01 ` Gerd Hoffmann
2022-06-22 2:02 ` Min Xu
2022-06-22 7:01 ` Gerd Hoffmann
2022-06-22 8:14 ` Min Xu
2022-06-22 9:22 ` Gerd Hoffmann
2022-06-23 0:40 ` Min Xu
2022-06-23 7:23 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220623072355.5an4p6gzuxbygokg@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox