From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web11.4649.1655969042891373468
 for <devel@edk2.groups.io>;
 Thu, 23 Jun 2022 00:24:03 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CV8pucEw;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1655969042;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=+5sdvAkNGLmn4gpU9pB/JWUPo61+8za2b6Spi8hXjmA=;
	b=CV8pucEwg5KUxhJNgMDVGschKOY5O8Ap3BjVyfakM4P/JIs6ZcGiTjSUqdbWkdcH7LZdv/
	sB+oXJR5FUCDsBOde3ZbSgbitnlkCBbUdyyt0Gzbi0kAPL+1gw5Ws9hf2BEWh+zDv9gznq
	fL/XXJQN8MVd2Iy3mpVNyK11ScRJ4Fs=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-230-Uf8psi_APb2YaG8vHmLQ4A-1; Thu, 23 Jun 2022 03:23:57 -0400
X-MC-Unique: Uf8psi_APb2YaG8vHmLQ4A-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3B15F3C11729;
	Thu, 23 Jun 2022 07:23:57 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.27])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 07F4E815B;
	Thu, 23 Jun 2022 07:23:57 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 93EE81800098; Thu, 23 Jun 2022 09:23:55 +0200 (CEST)
Date: Thu, 23 Jun 2022 09:23:55 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Xu, Min M" <min.m.xu@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Aktas, Erdem" <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH 3/3] OvmfPkg: Initialize NvVarStore with Configuration FV in Td guest
Message-ID: <20220623072355.5an4p6gzuxbygokg@sirius.home.kraxel.org>
References: <cover.1655518585.git.min.m.xu@intel.com>
 <b0125a87568f6ab9ae681dcf806e910dd0c41fbd.1655518585.git.min.m.xu@intel.com>
 <20220620110124.s4sutzqnsvlmvdg5@sirius.home.kraxel.org>
 <PH0PR11MB506414BF55D3BF3AB07B362AC5B29@PH0PR11MB5064.namprd11.prod.outlook.com>
 <20220622070127.toheatopvja6lrhd@sirius.home.kraxel.org>
 <PH0PR11MB5064F942BD68490119E668F1C5B29@PH0PR11MB5064.namprd11.prod.outlook.com>
 <20220622092233.qnalik3mu4uishmh@sirius.home.kraxel.org>
 <PH0PR11MB5064EA95BAAD6A3D694492A1C5B59@PH0PR11MB5064.namprd11.prod.outlook.com>
MIME-Version: 1.0
In-Reply-To: <PH0PR11MB5064EA95BAAD6A3D694492A1C5B59@PH0PR11MB5064.namprd11.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

> > The flag is already there ;)
> SECURE_BOOT_ENABLE is not a build-flag. It can only works in .dsc files. 
> The build-flag(SECURE_BOOT_FEATURE_ENABLED) would be defined in .dsc:
> [BuildOptions]
> !if $(SECURE_BOOT_ENABLE) == TRUE
>   MSFT:*_*_*_CC_FLAGS = /D SECURE_BOOT_FEATURE_ENABLED
>   INTEL:*_*_*_CC_FLAGS = /D SECURE_BOOT_FEATURE_ENABLED
>   GCC:*_*_*_CC_FLAGS = -D SECURE_BOOT_FEATURE_ENABLED
> !endif

Ah, I see.

I've expected that to happen automatically, similar to the the linux
kernel, where all CONFIG_* variables are available to both build system
and C source code.

take care,
  Gerd