From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web12.39577.1656321014943147475
 for <devel@edk2.groups.io>;
 Mon, 27 Jun 2022 02:10:15 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XZ7JejIm;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1656321014;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=awkEETVoCzepphMcXE3FjrIT41Cl+qsjOCKoximqtFY=;
	b=XZ7JejImscrYZUOuCIhYfBqoaL+tJjZCHdnHyw37GatItwszNegrNsEpY3Sx07QRIpANqG
	kSerXhLRfmBIilV2aHxsjPP/b1MEMIvtGs48p+kyxIfTBYPINprXX2Sa38vmesQBXmVp6a
	IsTM1ts5PDclJ2Fey/zFhQebO0vKZgE=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-551-9X_SxQtiOnSY0w6KrxmORA-1; Mon, 27 Jun 2022 05:10:09 -0400
X-MC-Unique: 9X_SxQtiOnSY0w6KrxmORA-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7030529DD981;
	Mon, 27 Jun 2022 09:10:08 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.27])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 36C40C23DBF;
	Mon, 27 Jun 2022 09:10:08 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id CE9BC1800084; Mon, 27 Jun 2022 11:10:06 +0200 (CEST)
Date: Mon, 27 Jun 2022 11:10:06 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V2 4/8] OvmfPkg/PlatformInitLib: Add functions for EmuVariableNvStore
Message-ID: <20220627091006.gyih3pdwnjvkdgek@sirius.home.kraxel.org>
References: <cover.1656210686.git.min.m.xu@intel.com>
 <ef666ac24b3b64cf730790a789976b89708b7831.1656210686.git.min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <ef666ac24b3b64cf730790a789976b89708b7831.1656210686.git.min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

> +VOID *
> +EFIAPI
> +PlatformReserveEmuVariableNvStore (
> +  VOID
> +  )

> +  DEBUG ((
> +    DEBUG_INFO,
> +    "Reserved variable store memory: 0x%p; size: %dkb\n",
> +    VariableStore,
> +    VarStoreSize / 1024
> +    ));

> +EFI_STATUS
> +EFIAPI
> +PlatformInitEmuVariableNvStore (
> +  IN VOID  *EmuVariableNvStore
> +  )
> +{

I think it would be good to add a log message to this function too,
to make it easier to check variable initialization actually works
the way it is supposed to work.

take care,
  Gerd