public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V2 5/8] OvmfPkg/PlatformPei: Update ReserveEmuVariableNvStore
Date: Mon, 27 Jun 2022 11:14:16 +0200	[thread overview]
Message-ID: <20220627091416.7jun2rh4wy4e54h5@sirius.home.kraxel.org> (raw)
In-Reply-To: <93072b2c22fbd173b6732baaf0dee9d22a3e5db8.1656210686.git.min.m.xu@intel.com>

  Hi,

> + #ifdef SECURE_BOOT_FEATURE_ENABLED
> +  PlatformInitEmuVariableNvStore ((VOID *)(UINTN)VariableStore);
> + #endif

OvmfPkg/Library/NvVarsFileLib/ allows loading variables into emulated
varstore from a on-disk NvVars file.  We can't allow that when secure
boot is active.  I think we need a simliar check there.  Shortcutting
the ConnectNvVarsToFileSystem() function with a

#ifdef SECURE_BOOT_FEATURE_ENABLED
	return EFI_NOT_SUPPORTED;
#endif

should do the trick I think.

thanks,
  Gerd


  reply	other threads:[~2022-06-27  9:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-26  3:05 [PATCH V2 0/8] Enable secure-boot when lauch OVMF with -bios parameter Min Xu
2022-06-26  3:05 ` [PATCH V2 1/8] OvmfPkg: Move TdxValidateCfv from PeilessStartupLib to PlatformInitLib Min Xu
2022-06-27  7:02   ` Gerd Hoffmann
2022-06-27  8:04     ` Min Xu
2022-06-27  8:41       ` [edk2-devel] " Gerd Hoffmann
2022-06-29  5:16         ` Min Xu
2022-06-26  3:05 ` [PATCH V2 2/8] OvmfPkg: Validate Cfv integrity in Tdx guest Min Xu
2022-06-26  3:05 ` [PATCH V2 3/8] EmbeddedPkg: Add AllocateRuntimePages in PrePiMemoryAllocationLib Min Xu
2022-07-20  8:49   ` Min Xu
2022-08-03  2:26     ` Min Xu
2022-08-03  6:22   ` [edk2-devel] " Ard Biesheuvel
2022-06-26  3:05 ` [PATCH V2 4/8] OvmfPkg/PlatformInitLib: Add functions for EmuVariableNvStore Min Xu
2022-06-27  9:10   ` Gerd Hoffmann
2022-06-29  5:16     ` [edk2-devel] " Min Xu
2022-06-26  3:05 ` [PATCH V2 5/8] OvmfPkg/PlatformPei: Update ReserveEmuVariableNvStore Min Xu
2022-06-27  9:14   ` Gerd Hoffmann [this message]
2022-06-29  5:17     ` [edk2-devel] " Min Xu
2022-06-26  3:05 ` [PATCH V2 6/8] OvmfPkg: Reserve and init EmuVariableNvStore in Pei-less Startup Min Xu
2022-06-26  3:05 ` [PATCH V2 7/8] OvmfPkg/TdxDxe: Set PcdEmuVariableNvStoreReserved Min Xu
2022-06-26  3:05 ` [PATCH V2 8/8] OvmfPkg: Add build-flag SECURE_BOOT_FEATURE_ENABLED Min Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220627091416.7jun2rh4wy4e54h5@sirius.home.kraxel.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox