From: "Kun Qin" <kuqin12@gmail.com>
To: devel@edk2.groups.io
Cc: Jiewen Yao <jiewen.yao@intel.com>,
Jian J Wang <jian.j.wang@intel.com>,
Qi Zhang <qi1.zhang@intel.com>,
Rahul Kumar <rahul1.kumar@intel.com>,
Andrew Fish <afish@apple.com>, Leif Lindholm <leif@nuviainc.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Zhiguang Liu <zhiguang.liu@intel.com>
Subject: [edk2-staging][PATCH v1 0/7] Add TPM subclass definition
Date: Tue, 5 Jul 2022 20:38:11 -0700 [thread overview]
Message-ID: <20220706033818.1493-1-kuqin12@gmail.com> (raw)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3966
>From PI Specification v1.7 Errata A, EFI_PERIPHERAL_DOCKING is defined as
0xD0000 (as well as included in PiStatusCode.h).
However, subclass employed as PCD for TPM peripheral in SecurityPkg is
also defined as 0xD0000. The TPM subclass code was used in TcgPei.c when
reporting error codes.
The collision of subclass definition could cause the parsing of reported
errors being ambiguous.
This patch series add EFI_PERIPHERAL_TPM as a spec-defined value and
removed potential usages in the SecurityPkg.
Patch v1 branch: https://github.com/kuqin12/edk2/tree/BZ3966-add_tpm_subclass
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Qi Zhang <qi1.zhang@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Kun Qin (7):
EDK2 Code First: PI Specification: New peripheral subclass for TPM
MdePkg: MmCommunication: Add TPM subclass definition to MdePkg
SecurityPkg: Tcg2Dxe: Replace PcdStatusCodeSubClassTpmDevice
SecurityPkg: Tcg2Pei: Replace PcdStatusCodeSubClassTpmDevice
SecurityPkg: TcgDxe: Replace PcdStatusCodeSubClassTpmDevice
SecurityPkg: TcgPei: Replace PcdStatusCodeSubClassTpmDevice
SecurityPkg: SubClassTpm: Updated default value
SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 4 +-
SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 4 +-
SecurityPkg/Tcg/TcgDxe/TcgDxe.c | 2 +-
SecurityPkg/Tcg/TcgPei/TcgPei.c | 4 +-
CodeFirst/BZ3966-SpecChange.md | 60 ++++++++++++++++++++
MdePkg/Include/Pi/PiStatusCode.h | 1 +
SecurityPkg/SecurityPkg.dec | 6 +-
SecurityPkg/SecurityPkg.uni | 2 +-
SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf | 1 -
SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 1 -
SecurityPkg/Tcg/TcgDxe/TcgDxe.inf | 1 -
SecurityPkg/Tcg/TcgPei/TcgPei.inf | 1 -
12 files changed, 72 insertions(+), 15 deletions(-)
create mode 100644 CodeFirst/BZ3966-SpecChange.md
--
2.35.1.windows.2
next reply other threads:[~2022-07-06 3:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 3:38 Kun Qin [this message]
2022-07-06 3:38 ` [edk2-staging][PATCH v1 1/7] EDK2 Code First: PI Specification: New peripheral subclass for TPM Kun Qin
2022-07-06 3:38 ` [edk2-staging][PATCH v1 2/7] MdePkg: MmCommunication: Add TPM subclass definition to MdePkg Kun Qin
2022-07-06 3:38 ` [edk2-staging][PATCH v1 3/7] SecurityPkg: Tcg2Dxe: Replace PcdStatusCodeSubClassTpmDevice Kun Qin
2022-07-06 3:38 ` [edk2-staging][PATCH v1 4/7] SecurityPkg: Tcg2Pei: " Kun Qin
2022-07-06 3:38 ` [edk2-staging][PATCH v1 5/7] SecurityPkg: TcgDxe: " Kun Qin
2022-07-06 3:38 ` [edk2-staging][PATCH v1 6/7] SecurityPkg: TcgPei: " Kun Qin
2022-07-06 3:38 ` [edk2-staging][PATCH v1 7/7] SecurityPkg: SubClassTpm: Updated default value Kun Qin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220706033818.1493-1-kuqin12@gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox