public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: <devel@edk2.groups.io>
Cc: Sami Mujawar <sami.mujawar@arm.com>, <Alexei.Fedorov@arm.com>,
	<pierre.gondois@arm.com>, <Matteo.Carlini@arm.com>,
	<Akanksha.Jain2@arm.com>, <Ben.Adderson@arm.com>,
	<ray.ni@intel.com>, <zhichao.gao@intel.com>, <nd@arm.com>
Subject: [PATCH v4 2/8] ShellPkg: Acpiview: Abbreviate field names to preserve alignment
Date: Wed, 6 Jul 2022 10:56:25 +0100	[thread overview]
Message-ID: <20220706095631.27196-3-sami.mujawar@arm.com> (raw)
In-Reply-To: <20220706095631.27196-1-sami.mujawar@arm.com>

Some field names in the IORT table parser were longer than the
OUTPUT_FIELD_COLUMN_WIDTH plus indentation, resulting in loss of
the output print alignment. Therefore, abbreviate the field names.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
---

Notes:
    v4:
      - No code change since v1. Including r-b and resending   [SAMI]
        with v4 series.
    
    v3:
      - No code change since v1. Include r-b received          [SAMI]
        from v2 series.
        Ref: https://edk2.groups.io/g/devel/topic/83600717#7665
    v2:
      - No code change since v1. Re-sending with v2 series.    [SAMI]

 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
index 81bfacd83added87a867cf365a56d4b7a1410ef2..44d633c5282463078a4cc990bb24ca1992f95634 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
@@ -1,11 +1,14 @@
 /** @file
   IORT table parser
 
-  Copyright (c) 2016 - 2020, ARM Limited. All rights reserved.
+  Copyright (c) 2016 - 2021, Arm Limited. All rights reserved.
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
   @par Reference(s):
-    - IO Remapping Table, Platform Design Document, Revision D, March 2018
+  - IO Remapping Table, Platform Design Document, Revision D, March 2018
+
+  @par Glossary:
+    - Ref  - Reference
 **/
 
 #include <IndustryStandard/IoRemappingTable.h>
@@ -144,15 +147,15 @@ STATIC CONST ACPI_PARSER  IortNodeSmmuV1V2Parser[] = {
   { L"Span",                          8,    24,  L"0x%lx", NULL, NULL, NULL, NULL },
   { L"Model",                         4,    32,  L"%d",    NULL, NULL, NULL, NULL },
   { L"Flags",                         4,    36,  L"0x%x",  NULL, NULL, NULL, NULL },
-  { L"Reference to Global Interrupt Array",4,    40,  L"0x%x",  NULL, NULL, NULL,
+  { L"Global Interrupt Array Ref",    4,    40,  L"0x%x",  NULL, NULL, NULL,
     NULL },
   { L"Number of context interrupts",  4,    44,  L"%d",    NULL,
     (VOID **)&InterruptContextCount,  NULL, NULL },
-  { L"Reference to Context Interrupt Array",4,    48,  L"0x%x",  NULL,
+  { L"Context Interrupt Array Ref",   4,    48,  L"0x%x",  NULL,
     (VOID **)&InterruptContextOffset, NULL, NULL },
   { L"Number of PMU Interrupts",      4,    52,  L"%d",    NULL,
     (VOID **)&PmuInterruptCount,      NULL, NULL },
-  { L"Reference to PMU Interrupt Array",4,    56,  L"0x%x",  NULL,
+  { L"PMU Interrupt Array Ref",       4,    56,  L"0x%x",  NULL,
     (VOID **)&PmuInterruptOffset,     NULL, NULL },
 
   // Interrupt Array
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'


  parent reply	other threads:[~2022-07-06  9:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06  9:56 [PATCH v4 0/8] IORT Rev E.d specification updates Sami Mujawar
2022-07-06  9:56 ` [PATCH v4 1/8] MdePkg: IORT header update for IORT Rev E.d spec Sami Mujawar
2022-07-06 15:44   ` [edk2-devel] " Sami Mujawar
2022-07-07  1:51     ` 回复: " gaoliming
2022-07-07 10:31       ` Sami Mujawar
2022-07-07  6:05   ` Jon Nettleton
2022-07-07 11:02     ` Sami Mujawar
2022-07-06  9:56 ` Sami Mujawar [this message]
2022-07-06  9:56 ` [PATCH 3/8] ShellPkg: Acpiview: IORT parser " Sami Mujawar
2022-07-06  9:56 ` [PATCH v4 4/8] DynamicTablesPkg: Handle error when IdMappingToken is NULL Sami Mujawar
2022-07-06  9:56 ` [PATCH v4 5/8] DynamicTablesPkg: IORT set reference to Id array only if present Sami Mujawar
2022-07-06  9:56 ` [PATCH v4 6/8] DynamicTablesPkg: IORT set reference to interrupt array " Sami Mujawar
2022-07-06  9:56 ` [PATCH v4 7/8] DynamicTablesPkg: Update ArmNameSpaceObjects for IORT Rev E.d Sami Mujawar
2022-07-06  9:56 ` [PATCH 8/8] DynamicTablesPkg: IORT generator updates for Rev E.d spec Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220706095631.27196-3-sami.mujawar@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox