[PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro

[PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro

[Sami Mujawar]

This v3 patch series renames the EFI_ACPI_IO_REMAPPING_TABLE_REV0
macro to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00 based on the
feedback received. It also includes an additional patch that fixes
the build break in CelloBoard due to missing VariablePolicyHelperLib
dependency.

The v2 patch series fixes the build break in Ampere/Jade and
Pythium/FT2000-4 due to missing VariableFlashInfoLib dependency
and also updates the IORT revision macro.

The IORT Rev E.d specification updates the IORT table revision
to 5. Following this the IORT table revision macro 
EFI_ACPI_IO_REMAPPING_TABLE_REVISION which was at Rev 0 has
been renamed to EFI_ACPI_IO_REMAPPING_TABLE_REV0. Therefore,
this series updates the following platforms to reflect this
renaming:
 - FVP
 - Morello FVP
 - SGI
 - AMD/Styx
 - Socionext/SynQuacer
 - RaspberryPi
 - N1SDP
 - Ampere/Jade
 - Pythium/FT2000-4

Note: This patch series is dependent on the edk2 patch series:
  "[PATCH v5 0/8] IORT Rev E.d specification updates"
  (https://edk2.groups.io/g/devel/message/91264), which must
  be merged in edk2 before this patch series can be integrated.

The changes can be seen at:
https://github.com/samimujawar/edk2-platforms/tree/1527_iort_rev_ed_platforms_v3

Sami Mujawar (12):
  Platform/ARM: FVP: Update for IORT revision macro renaming
  Platform/ARM: Morello: Update for IORT revision macro renaming
  Platform/ARM: SGI: Update for IORT revision macro renaming
  Silicon/AMD/Styx: Update for IORT revision macro renaming
  Silicon/Socionext/SynQuacer: Update for IORT revision macro renaming
  Platform/RaspberryPi: Update for IORT revision macro renaming
  Platform/ARM: N1SDP: Update for IORT revision macro renaming
  Silicon/Ampere: Add VariableFlashInfoLib
  Platform/Ampere: JadePkg: Update for IORT revision macro renaming
  Silicon/Phytium: Add VariableFlashInfoLib
  Silicon/Phytium: FT2000-4Pkg: Update for IORT revision macro renaming
  Platform/LeMaker: Fix missing dependency on VariablePolicyHelperLib

 Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c  | 2 +-
 Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c       | 2 +-
 Platform/ARM/SgiPkg/AcpiTables/Iort.aslc                                                     | 2 +-
 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +-
 Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c                                   | 2 +-
 Platform/LeMaker/CelloBoard/CelloBoard.dsc                                                   | 1 +
 Platform/RaspberryPi/AcpiTables/Iort.aslc                                                    | 2 +-
 Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc                                           | 2 +-
 Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc                                         | 1 +
 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc                                     | 2 +-
 Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc                                    | 1 +
 Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc                                             | 2 +-
 12 files changed, 12 insertions(+), 9 deletions(-)

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v3 01/12] Platform/ARM: FVP: Update for IORT revision macro renaming

[Sami Mujawar]

The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the Configuration Manager for FVP platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index 0ba854610becff7d2544e26ec67a331783bbe75f..58a4bf9890bc2a701dab558a1987f9a51662481a 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -82,7 +82,7 @@ EDKII_PLATFORM_REPOSITORY_INFO VExpressPlatRepositoryInfo = {
     // IORT Table - FVP RevC
     {
       EFI_ACPI_6_3_IO_REMAPPING_TABLE_SIGNATURE,
-      EFI_ACPI_IO_REMAPPING_TABLE_REVISION,
+      EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00,
       CREATE_STD_ACPI_TABLE_GEN_ID (EStdAcpiTableIdIort),
       NULL
     },
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v3 02/12] Platform/ARM: Morello: Update for IORT revision macro renaming

[Sami Mujawar]

The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the Configuration Manager for Morello FVP to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c b/Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c
index ed2fdfeff9a02b13729cdd5d6f334f7bcabe679f..85b0d390598ffd9739059d1ee1c7aae312aba48c 100644
--- a/Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c
+++ b/Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c
@@ -76,7 +76,7 @@ EDKII_FVP_PLATFORM_REPOSITORY_INFO MorelloFvpRepositoryInfo = {
     // IORT Table
     {
       EFI_ACPI_6_3_IO_REMAPPING_TABLE_SIGNATURE,
-      EFI_ACPI_IO_REMAPPING_TABLE_REVISION,
+      EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00,
       CREATE_STD_ACPI_TABLE_GEN_ID (EStdAcpiTableIdIort),
       NULL
     },
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v3 03/12] Platform/ARM: SGI: Update for IORT revision macro renaming

[Sami Mujawar]

The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for SGI platforms to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 Platform/ARM/SgiPkg/AcpiTables/Iort.aslc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc b/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc
index fcc28a71c82eb0c78c96d60c9d9eb1554adb41a3..a7ad92622a905f5b1fd725d5d673a2643685f9af 100644
--- a/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc
+++ b/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc
@@ -50,7 +50,7 @@ ARM_EFI_ACPI_6_0_IO_REMAPPING_TABLE Iort =
      (
        EFI_ACPI_6_2_IO_REMAPPING_TABLE_SIGNATURE,
        ARM_EFI_ACPI_6_0_IO_REMAPPING_TABLE,
-       EFI_ACPI_IO_REMAPPING_TABLE_REVISION
+       EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00
      ),
      3,  // NumNodes
      sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE),  // NodeOffset
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v3 04/12] Silicon/AMD/Styx: Update for IORT revision macro renaming

[Sami Mujawar]

The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for Styx platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc b/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc
index b81f87b7794eec47042910d77efcb609563991a8..27d443494bd312ab7d96d8072a9f4c1e9a98b1ae 100644
--- a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc
+++ b/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc
@@ -139,7 +139,7 @@ STATIC STYX_IO_REMAPPING_STRUCTURE AcpiIort = {
   {
     AMD_ACPI_HEADER(EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE,
                     STYX_IO_REMAPPING_STRUCTURE,
-                    EFI_ACPI_IO_REMAPPING_TABLE_REVISION),
+                    EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00),
     11,                                             // NumNodes
     sizeof(EFI_ACPI_6_0_IO_REMAPPING_TABLE),        // NodeOffset
     0                                               // Reserved
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v3 05/12] Silicon/Socionext/SynQuacer: Update for IORT revision macro renaming

[Sami Mujawar]

The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for SynQuacer platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc b/Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc
index 4627347028132395de757ff7c81b00848057632d..293888cbbe21686e9061e988c036ff487d7b35cb 100644
--- a/Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc
+++ b/Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc
@@ -56,7 +56,7 @@ STATIC SYNQUACER_IO_REMAPPING_STRUCTURE Iort = {
   {
     __ACPI_HEADER(EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE,
                   SYNQUACER_IO_REMAPPING_STRUCTURE,
-                  EFI_ACPI_IO_REMAPPING_TABLE_REVISION),
+                  EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00),
     6,                                              // NumNodes
     sizeof(EFI_ACPI_6_0_IO_REMAPPING_TABLE),        // NodeOffset
     0                                               // Reserved
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v3 06/12] Platform/RaspberryPi: Update for IORT revision macro renaming

[Sami Mujawar]

The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for RaspberryPi platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>
---
 Platform/RaspberryPi/AcpiTables/Iort.aslc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/RaspberryPi/AcpiTables/Iort.aslc b/Platform/RaspberryPi/AcpiTables/Iort.aslc
index 810307ae376f7d24790775f499daa09e3137fe6c..78efabb94739862275199bdac3d678f3586d9b94 100644
--- a/Platform/RaspberryPi/AcpiTables/Iort.aslc
+++ b/Platform/RaspberryPi/AcpiTables/Iort.aslc
@@ -28,7 +28,7 @@ STATIC RPI4_IO_REMAPPING_STRUCTURE Iort = {
   {
     ACPI_HEADER (EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE,
                  RPI4_IO_REMAPPING_STRUCTURE,
-                 EFI_ACPI_IO_REMAPPING_TABLE_REVISION),
+                 EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00),
     3,                                              // NumNodes
     sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE),       // NodeOffset
     0                                               // Reserved
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v3 07/12] Platform/ARM: N1SDP: Update for IORT revision macro renaming

[Sami Mujawar]

The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for N1SDP platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index f50623ae3faccc862eef1968674dee8bd33fbdd6..a6b4cb0ef482541da2c9244c1135f10ccbbfbaf9 100644
--- a/Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -90,7 +90,7 @@ EDKII_PLATFORM_REPOSITORY_INFO N1sdpRepositoryInfo = {
     // IORT Table
     {
       EFI_ACPI_6_3_IO_REMAPPING_TABLE_SIGNATURE,
-      EFI_ACPI_IO_REMAPPING_TABLE_REVISION,
+      EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00,
       CREATE_STD_ACPI_TABLE_GEN_ID (EStdAcpiTableIdIort),
       NULL
     },
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v3 08/12] Silicon/Ampere: Add VariableFlashInfoLib

[Sami Mujawar]

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479

Add an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This allows the variable
driver to build successfully as it has a dependency on this
library class.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
index f4007d654ec81297d4bbe002b2671c211129d819..d4c29c3c338cc8abefd84cbb3ff14d1727bd4fe4 100644
--- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
+++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
@@ -154,6 +154,7 @@ [LibraryClasses.common]
   AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
 !endif
   VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
+  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
 
   #
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v3 09/12] Platform/Ampere: JadePkg: Update for IORT revision macro renaming

[Sami Mujawar]

The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for SynQuacer platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c
index 97be85c51f253422851ba139ee60bc8fc681aa87..958708810a4918b1683ecc5fb021b59a7191e207 100644
--- a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c
+++ b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c
@@ -87,7 +87,7 @@ EFI_ACPI_6_0_IO_REMAPPING_TABLE mIortHeader = {
   .Header = __ACPI_HEADER (
               EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE,
               AC01_IO_REMAPPING_STRUCTURE,
-              EFI_ACPI_IO_REMAPPING_TABLE_REVISION
+              EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00
               ),
   .NumNodes = 0,  // To be filled
   .NodeOffset = sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE),
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v3 10/12] Silicon/Phytium: Add VariableFlashInfoLib

[Sami Mujawar]

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479

Add an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This allows the variable
driver to build successfully as it has a dependency on this
library class.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc b/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
index 2565b8ac626abc2073d201ad43e057f2fbbf4cbc..a7ca630be7b98e784261bc9a7543fdcc71151337 100644
--- a/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
+++ b/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
@@ -98,6 +98,7 @@ [LibraryClasses.common]
   UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
 
   VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
+  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
 
   #
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v3 11/12] Silicon/Phytium: FT2000-4Pkg: Update for IORT revision macro renaming

[Sami Mujawar]

The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for SynQuacer platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc b/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc
index 4239499b68e5923604625e05a0425fc11ab6664e..9c3a5eea72cbeb20ef48450789630a15094f0372 100644
--- a/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc
+++ b/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc
@@ -42,7 +42,7 @@ STATIC PHYTIUM_IO_REMAPPING_STRUCTURE Iort = {
   {
     PHYTIUM_ACPI_HEADER (EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE,
                   PHYTIUM_IO_REMAPPING_STRUCTURE,
-                  EFI_ACPI_IO_REMAPPING_TABLE_REVISION),
+                  EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00),
     2,                                              // NumNodes
     sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE),       // NodeOffset
     0                                               // Reserved
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v3 12/12] Platform/LeMaker: Fix missing dependency on VariablePolicyHelperLib

[Sami Mujawar]

The CelloBoard platform firmware build breaks due to the missing
dependency on VariablePolicyHelperLib.

Therefore, to satisfy the dependency include VariablePolicyHelperLib
in the LibraryClasses.common section.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
index 6be8062e60f6a83a357edbdbbbdf7a35dc10f044..0b98d976f9c47da6864889ef558fc73f8a820498 100644
--- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc
+++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
@@ -121,6 +121,7 @@ [LibraryClasses.common]
 
   VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
+  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
   CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
   UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
   BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

Re: [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro

[PierreGondois]

Hi Sami,
I think
   Silicon/NXP/NxpQoriqLs.dsc.inc
also requires the VariableFlashInfoLib library. Otherwise:

Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>


On 7/12/22 16:40, Sami Mujawar wrote:
> This v3 patch series renames the EFI_ACPI_IO_REMAPPING_TABLE_REV0
> macro to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00 based on the
> feedback received. It also includes an additional patch that fixes
> the build break in CelloBoard due to missing VariablePolicyHelperLib
> dependency.
> 
> The v2 patch series fixes the build break in Ampere/Jade and
> Pythium/FT2000-4 due to missing VariableFlashInfoLib dependency
> and also updates the IORT revision macro.
> 
> The IORT Rev E.d specification updates the IORT table revision
> to 5. Following this the IORT table revision macro
> EFI_ACPI_IO_REMAPPING_TABLE_REVISION which was at Rev 0 has
> been renamed to EFI_ACPI_IO_REMAPPING_TABLE_REV0. Therefore,
> this series updates the following platforms to reflect this
> renaming:
>   - FVP
>   - Morello FVP
>   - SGI
>   - AMD/Styx
>   - Socionext/SynQuacer
>   - RaspberryPi
>   - N1SDP
>   - Ampere/Jade
>   - Pythium/FT2000-4
> 
> Note: This patch series is dependent on the edk2 patch series:
>    "[PATCH v5 0/8] IORT Rev E.d specification updates"
>    (https://edk2.groups.io/g/devel/message/91264), which must
>    be merged in edk2 before this patch series can be integrated.
> 
> The changes can be seen at:
> https://github.com/samimujawar/edk2-platforms/tree/1527_iort_rev_ed_platforms_v3
> 
> Sami Mujawar (12):
>    Platform/ARM: FVP: Update for IORT revision macro renaming
>    Platform/ARM: Morello: Update for IORT revision macro renaming
>    Platform/ARM: SGI: Update for IORT revision macro renaming
>    Silicon/AMD/Styx: Update for IORT revision macro renaming
>    Silicon/Socionext/SynQuacer: Update for IORT revision macro renaming
>    Platform/RaspberryPi: Update for IORT revision macro renaming
>    Platform/ARM: N1SDP: Update for IORT revision macro renaming
>    Silicon/Ampere: Add VariableFlashInfoLib
>    Platform/Ampere: JadePkg: Update for IORT revision macro renaming
>    Silicon/Phytium: Add VariableFlashInfoLib
>    Silicon/Phytium: FT2000-4Pkg: Update for IORT revision macro renaming
>    Platform/LeMaker: Fix missing dependency on VariablePolicyHelperLib
> 
>   Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c  | 2 +-
>   Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c       | 2 +-
>   Platform/ARM/SgiPkg/AcpiTables/Iort.aslc                                                     | 2 +-
>   Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +-
>   Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c                                   | 2 +-
>   Platform/LeMaker/CelloBoard/CelloBoard.dsc                                                   | 1 +
>   Platform/RaspberryPi/AcpiTables/Iort.aslc                                                    | 2 +-
>   Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc                                           | 2 +-
>   Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc                                         | 1 +
>   Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc                                     | 2 +-
>   Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc                                    | 1 +
>   Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc                                             | 2 +-
>   12 files changed, 12 insertions(+), 9 deletions(-)
> 

Re: [PATCH edk2-platforms v3 08/12] Silicon/Ampere: Add VariableFlashInfoLib

[Nhi Pham]

Hi Sami,

Could you help update for 
Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc as well?

Thanks,
Nhi

On 12/07/2022 21:40, Sami Mujawar wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
>
> Add an instance for the library class VariableFlashInfoLib that
> was recently introduced in MdeModulePkg. This allows the variable
> driver to build successfully as it has a dependency on this
> library class.
>
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
>   Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
> index f4007d654ec81297d4bbe002b2671c211129d819..d4c29c3c338cc8abefd84cbb3ff14d1727bd4fe4 100644
> --- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
> +++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
> @@ -154,6 +154,7 @@ [LibraryClasses.common]
>     AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
>   !endif
>     VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
> +  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
>     VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>   
>     #

Re: [PATCH edk2-platforms v3 09/12] Platform/Ampere: JadePkg: Update for IORT revision macro renaming

[Nhi Pham]

Reviewed-by: Nhi Pham <nhi@os.amperecomputing.com>

Thanks,
Nhi

On 12/07/2022 21:40, Sami Mujawar wrote:
> The IORT Specification E.d updates the IORT table revision to 5. To
> reflect this change the IORT header file has been updated to rename
> the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
> EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
>
> Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
> macro in the IORT table for SynQuacer platform to
> EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
>
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
>   Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c
> index 97be85c51f253422851ba139ee60bc8fc681aa87..958708810a4918b1683ecc5fb021b59a7191e207 100644
> --- a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c
> +++ b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c
> @@ -87,7 +87,7 @@ EFI_ACPI_6_0_IO_REMAPPING_TABLE mIortHeader = {
>     .Header = __ACPI_HEADER (
>                 EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE,
>                 AC01_IO_REMAPPING_STRUCTURE,
> -              EFI_ACPI_IO_REMAPPING_TABLE_REVISION
> +              EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00
>                 ),
>     .NumNodes = 0,  // To be filled
>     .NodeOffset = sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE),

Re: [edk2-devel] [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro

[Masahisa Kojima]

Hi Sami,

Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
also requires the VariableFlashInfoLib library.
I have checked that the build error is fixed with the following modification.

--- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
+++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
@@ -111,7 +111,7 @@ [LibraryClasses]

   NorFlashInfoLib|EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf
   NorFlashPlatformLib|Silicon/Socionext/SynQuacer/Library/NorFlashSynQuacerLib/NorFlashSynQuacerLib.inf
-
+  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf

Thanks,
Masahisa Kojima

On Wed, 13 Jul 2022 at 22:19, PierreGondois <pierre.gondois@arm.com> wrote:
>
> Hi Sami,
> I think
>    Silicon/NXP/NxpQoriqLs.dsc.inc
> also requires the VariableFlashInfoLib library. Otherwise:
>
> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
>
>
> On 7/12/22 16:40, Sami Mujawar wrote:
> > This v3 patch series renames the EFI_ACPI_IO_REMAPPING_TABLE_REV0
> > macro to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00 based on the
> > feedback received. It also includes an additional patch that fixes
> > the build break in CelloBoard due to missing VariablePolicyHelperLib
> > dependency.
> >
> > The v2 patch series fixes the build break in Ampere/Jade and
> > Pythium/FT2000-4 due to missing VariableFlashInfoLib dependency
> > and also updates the IORT revision macro.
> >
> > The IORT Rev E.d specification updates the IORT table revision
> > to 5. Following this the IORT table revision macro
> > EFI_ACPI_IO_REMAPPING_TABLE_REVISION which was at Rev 0 has
> > been renamed to EFI_ACPI_IO_REMAPPING_TABLE_REV0. Therefore,
> > this series updates the following platforms to reflect this
> > renaming:
> >   - FVP
> >   - Morello FVP
> >   - SGI
> >   - AMD/Styx
> >   - Socionext/SynQuacer
> >   - RaspberryPi
> >   - N1SDP
> >   - Ampere/Jade
> >   - Pythium/FT2000-4
> >
> > Note: This patch series is dependent on the edk2 patch series:
> >    "[PATCH v5 0/8] IORT Rev E.d specification updates"
> >    (https://edk2.groups.io/g/devel/message/91264), which must
> >    be merged in edk2 before this patch series can be integrated.
> >
> > The changes can be seen at:
> > https://github.com/samimujawar/edk2-platforms/tree/1527_iort_rev_ed_platforms_v3
> >
> > Sami Mujawar (12):
> >    Platform/ARM: FVP: Update for IORT revision macro renaming
> >    Platform/ARM: Morello: Update for IORT revision macro renaming
> >    Platform/ARM: SGI: Update for IORT revision macro renaming
> >    Silicon/AMD/Styx: Update for IORT revision macro renaming
> >    Silicon/Socionext/SynQuacer: Update for IORT revision macro renaming
> >    Platform/RaspberryPi: Update for IORT revision macro renaming
> >    Platform/ARM: N1SDP: Update for IORT revision macro renaming
> >    Silicon/Ampere: Add VariableFlashInfoLib
> >    Platform/Ampere: JadePkg: Update for IORT revision macro renaming
> >    Silicon/Phytium: Add VariableFlashInfoLib
> >    Silicon/Phytium: FT2000-4Pkg: Update for IORT revision macro renaming
> >    Platform/LeMaker: Fix missing dependency on VariablePolicyHelperLib
> >
> >   Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c  | 2 +-
> >   Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c       | 2 +-
> >   Platform/ARM/SgiPkg/AcpiTables/Iort.aslc                                                     | 2 +-
> >   Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +-
> >   Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c                                   | 2 +-
> >   Platform/LeMaker/CelloBoard/CelloBoard.dsc                                                   | 1 +
> >   Platform/RaspberryPi/AcpiTables/Iort.aslc                                                    | 2 +-
> >   Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc                                           | 2 +-
> >   Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc                                         | 1 +
> >   Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc                                     | 2 +-
> >   Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc                                    | 1 +
> >   Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc                                             | 2 +-
> >   12 files changed, 12 insertions(+), 9 deletions(-)
> >
>
>
> 
>
>

Re: [PATCH edk2-platforms v3 08/12] Silicon/Ampere: Add VariableFlashInfoLib

[Sami Mujawar]

Hi Nhi,

I will do that no problem. However, we really need an edk2-platforms CI 
to catch such issues.

Regards,

Sami Mujawar

On 14/07/2022 04:34 am, Nhi Pham wrote:
> Hi Sami,
>
> Could you help update for 
> Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc as well?
>
> Thanks,
> Nhi
>
> On 12/07/2022 21:40, Sami Mujawar wrote:
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
>>
>> Add an instance for the library class VariableFlashInfoLib that
>> was recently introduced in MdeModulePkg. This allows the variable
>> driver to build successfully as it has a dependency on this
>> library class.
>>
>> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
>> ---
>>   Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc 
>> b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
>> index 
>> f4007d654ec81297d4bbe002b2671c211129d819..d4c29c3c338cc8abefd84cbb3ff14d1727bd4fe4 
>> 100644
>> --- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
>> +++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
>> @@ -154,6 +154,7 @@ [LibraryClasses.common]
>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
>>   !endif
>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
>> + 
>> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>>       #

Re: [edk2-devel] [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro

[Sami Mujawar]

Hi Masahisa,

Please find my response inline marked [SAMI].

Regards,

Sami Mujawar

On 14/07/2022 07:38 am, Masahisa Kojima wrote:
> Hi Sami,
>
> Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
> also requires the VariableFlashInfoLib library.
> I have checked that the build error is fixed with the following modification.
>
> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
> @@ -111,7 +111,7 @@ [LibraryClasses]
>
>     NorFlashInfoLib|EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf
>     NorFlashPlatformLib|Silicon/Socionext/SynQuacer/Library/NorFlashSynQuacerLib/NorFlashSynQuacerLib.inf
> -
> +  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
>     VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf

[SAMI] I think this change should have been part of the series at 
https://edk2.groups.io/g/devel/message/89156. However, I will include 
this change im my series.

The platforms in edk2-platforms repository are frequently broken by 
changes in edk2 repository. I believe this is due to the lack of 
edk2-platforms CI and we really need to fix that.

[/SAMI]

> Thanks,
> Masahisa Kojima
>
> On Wed, 13 Jul 2022 at 22:19, PierreGondois <pierre.gondois@arm.com> wrote:
>> Hi Sami,
>> I think
>>     Silicon/NXP/NxpQoriqLs.dsc.inc
>> also requires the VariableFlashInfoLib library. Otherwise:
>>
>> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
>>
>>
>> On 7/12/22 16:40, Sami Mujawar wrote:
>>> This v3 patch series renames the EFI_ACPI_IO_REMAPPING_TABLE_REV0
>>> macro to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00 based on the
>>> feedback received. It also includes an additional patch that fixes
>>> the build break in CelloBoard due to missing VariablePolicyHelperLib
>>> dependency.
>>>
>>> The v2 patch series fixes the build break in Ampere/Jade and
>>> Pythium/FT2000-4 due to missing VariableFlashInfoLib dependency
>>> and also updates the IORT revision macro.
>>>
>>> The IORT Rev E.d specification updates the IORT table revision
>>> to 5. Following this the IORT table revision macro
>>> EFI_ACPI_IO_REMAPPING_TABLE_REVISION which was at Rev 0 has
>>> been renamed to EFI_ACPI_IO_REMAPPING_TABLE_REV0. Therefore,
>>> this series updates the following platforms to reflect this
>>> renaming:
>>>    - FVP
>>>    - Morello FVP
>>>    - SGI
>>>    - AMD/Styx
>>>    - Socionext/SynQuacer
>>>    - RaspberryPi
>>>    - N1SDP
>>>    - Ampere/Jade
>>>    - Pythium/FT2000-4
>>>
>>> Note: This patch series is dependent on the edk2 patch series:
>>>     "[PATCH v5 0/8] IORT Rev E.d specification updates"
>>>     (https://edk2.groups.io/g/devel/message/91264), which must
>>>     be merged in edk2 before this patch series can be integrated.
>>>
>>> The changes can be seen at:
>>> https://github.com/samimujawar/edk2-platforms/tree/1527_iort_rev_ed_platforms_v3
>>>
>>> Sami Mujawar (12):
>>>     Platform/ARM: FVP: Update for IORT revision macro renaming
>>>     Platform/ARM: Morello: Update for IORT revision macro renaming
>>>     Platform/ARM: SGI: Update for IORT revision macro renaming
>>>     Silicon/AMD/Styx: Update for IORT revision macro renaming
>>>     Silicon/Socionext/SynQuacer: Update for IORT revision macro renaming
>>>     Platform/RaspberryPi: Update for IORT revision macro renaming
>>>     Platform/ARM: N1SDP: Update for IORT revision macro renaming
>>>     Silicon/Ampere: Add VariableFlashInfoLib
>>>     Platform/Ampere: JadePkg: Update for IORT revision macro renaming
>>>     Silicon/Phytium: Add VariableFlashInfoLib
>>>     Silicon/Phytium: FT2000-4Pkg: Update for IORT revision macro renaming
>>>     Platform/LeMaker: Fix missing dependency on VariablePolicyHelperLib
>>>
>>>    Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c  | 2 +-
>>>    Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c       | 2 +-
>>>    Platform/ARM/SgiPkg/AcpiTables/Iort.aslc                                                     | 2 +-
>>>    Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +-
>>>    Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c                                   | 2 +-
>>>    Platform/LeMaker/CelloBoard/CelloBoard.dsc                                                   | 1 +
>>>    Platform/RaspberryPi/AcpiTables/Iort.aslc                                                    | 2 +-
>>>    Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc                                           | 2 +-
>>>    Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc                                         | 1 +
>>>    Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc                                     | 2 +-
>>>    Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc                                    | 1 +
>>>    Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc                                             | 2 +-
>>>    12 files changed, 12 insertions(+), 9 deletions(-)
>>>
>>
>> 
>>
>>

Re: [edk2-devel] [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro

[Sami Mujawar]

Hi Pierre,

Thank you for the review.

I have some comments marked inline as [SAMI].

Regards,

Sami Mujawar

On 14/07/2022 09:01 am, Sami Mujawar wrote:
> Hi Masahisa,
>
> Please find my response inline marked [SAMI].
>
> Regards,
>
> Sami Mujawar
>
> On 14/07/2022 07:38 am, Masahisa Kojima wrote:
>> Hi Sami,
>>
>> Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
>> also requires the VariableFlashInfoLib library.
>> I have checked that the build error is fixed with the following 
>> modification.
>>
>> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
>> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
>> @@ -111,7 +111,7 @@ [LibraryClasses]
>>
>> NorFlashInfoLib|EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf
>> NorFlashPlatformLib|Silicon/Socionext/SynQuacer/Library/NorFlashSynQuacerLib/NorFlashSynQuacerLib.inf
>> -
>> + 
>> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>
> [SAMI] I think this change should have been part of the series at 
> https://edk2.groups.io/g/devel/message/89156. However, I will include 
> this change im my series.
>
> The platforms in edk2-platforms repository are frequently broken by 
> changes in edk2 repository. I believe this is due to the lack of 
> edk2-platforms CI and we really need to fix that.
>
> [/SAMI]
>
>> Thanks,
>> Masahisa Kojima
>>
>> On Wed, 13 Jul 2022 at 22:19, PierreGondois <pierre.gondois@arm.com> 
>> wrote:
>>> Hi Sami,
>>> I think
>>>     Silicon/NXP/NxpQoriqLs.dsc.inc
>>> also requires the VariableFlashInfoLib library. Otherwise:
>>>
[SAMI] Looks like there is no end to this. I will fix this as well, but 
can we see what is blocking your series at 
https://edk2.groups.io/g/devel/message/83803, please?

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3509

Ref: https://github.com/tianocore/edk2-pytool-extensions/pull/279

[/SAMI]

>>> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
>>>
>>>
>>> On 7/12/22 16:40, Sami Mujawar wrote:
>>>> This v3 patch series renames the EFI_ACPI_IO_REMAPPING_TABLE_REV0
>>>> macro to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00 based on the
>>>> feedback received. It also includes an additional patch that fixes
>>>> the build break in CelloBoard due to missing VariablePolicyHelperLib
>>>> dependency.
>>>>
>>>> The v2 patch series fixes the build break in Ampere/Jade and
>>>> Pythium/FT2000-4 due to missing VariableFlashInfoLib dependency
>>>> and also updates the IORT revision macro.
>>>>
>>>> The IORT Rev E.d specification updates the IORT table revision
>>>> to 5. Following this the IORT table revision macro
>>>> EFI_ACPI_IO_REMAPPING_TABLE_REVISION which was at Rev 0 has
>>>> been renamed to EFI_ACPI_IO_REMAPPING_TABLE_REV0. Therefore,
>>>> this series updates the following platforms to reflect this
>>>> renaming:
>>>>    - FVP
>>>>    - Morello FVP
>>>>    - SGI
>>>>    - AMD/Styx
>>>>    - Socionext/SynQuacer
>>>>    - RaspberryPi
>>>>    - N1SDP
>>>>    - Ampere/Jade
>>>>    - Pythium/FT2000-4
>>>>
>>>> Note: This patch series is dependent on the edk2 patch series:
>>>>     "[PATCH v5 0/8] IORT Rev E.d specification updates"
>>>>     (https://edk2.groups.io/g/devel/message/91264), which must
>>>>     be merged in edk2 before this patch series can be integrated.
>>>>
>>>> The changes can be seen at:
>>>> https://github.com/samimujawar/edk2-platforms/tree/1527_iort_rev_ed_platforms_v3 
>>>>
>>>>
>>>> Sami Mujawar (12):
>>>>     Platform/ARM: FVP: Update for IORT revision macro renaming
>>>>     Platform/ARM: Morello: Update for IORT revision macro renaming
>>>>     Platform/ARM: SGI: Update for IORT revision macro renaming
>>>>     Silicon/AMD/Styx: Update for IORT revision macro renaming
>>>>     Silicon/Socionext/SynQuacer: Update for IORT revision macro 
>>>> renaming
>>>>     Platform/RaspberryPi: Update for IORT revision macro renaming
>>>>     Platform/ARM: N1SDP: Update for IORT revision macro renaming
>>>>     Silicon/Ampere: Add VariableFlashInfoLib
>>>>     Platform/Ampere: JadePkg: Update for IORT revision macro renaming
>>>>     Silicon/Phytium: Add VariableFlashInfoLib
>>>>     Silicon/Phytium: FT2000-4Pkg: Update for IORT revision macro 
>>>> renaming
>>>>     Platform/LeMaker: Fix missing dependency on 
>>>> VariablePolicyHelperLib
>>>>
>>>> Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c 
>>>> | 2 +-
>>>> Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c 
>>>> | 2 +-
>>>> Platform/ARM/SgiPkg/AcpiTables/Iort.aslc | 2 +-
>>>> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c 
>>>> | 2 +-
>>>> Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c | 2 +-
>>>> Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 +
>>>> Platform/RaspberryPi/AcpiTables/Iort.aslc | 2 +-
>>>> Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc | 2 +-
>>>> Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 +
>>>> Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc | 2 +-
>>>> Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc | 1 +
>>>> Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc | 2 +-
>>>>    12 files changed, 12 insertions(+), 9 deletions(-)
>>>>
>>>
>>> 
>>>
>>>

Re: [edk2-devel] [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro

[Masahisa Kojima]

Hi Sami,

On Thu, 14 Jul 2022 at 17:01, Sami Mujawar <sami.mujawar@arm.com> wrote:
>
> Hi Masahisa,
>
> Please find my response inline marked [SAMI].
>
> Regards,
>
> Sami Mujawar
>
> On 14/07/2022 07:38 am, Masahisa Kojima wrote:
> > Hi Sami,
> >
> > Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
> > also requires the VariableFlashInfoLib library.
> > I have checked that the build error is fixed with the following modification.
> >
> > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
> > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
> > @@ -111,7 +111,7 @@ [LibraryClasses]
> >
> >     NorFlashInfoLib|EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf
> >     NorFlashPlatformLib|Silicon/Socionext/SynQuacer/Library/NorFlashSynQuacerLib/NorFlashSynQuacerLib.inf
> > -
> > +  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
> >     VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>
> [SAMI] I think this change should have been part of the series at
> https://edk2.groups.io/g/devel/message/89156. However, I will include
> this change im my series.

Thank you very much for including the modification in your series.

Regards,
Masahisa Kojima

>
> The platforms in edk2-platforms repository are frequently broken by
> changes in edk2 repository. I believe this is due to the lack of
> edk2-platforms CI and we really need to fix that.
>
> [/SAMI]
>
> > Thanks,
> > Masahisa Kojima
> >
> > On Wed, 13 Jul 2022 at 22:19, PierreGondois <pierre.gondois@arm.com> wrote:
> >> Hi Sami,
> >> I think
> >>     Silicon/NXP/NxpQoriqLs.dsc.inc
> >> also requires the VariableFlashInfoLib library. Otherwise:
> >>
> >> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
> >>
> >>
> >> On 7/12/22 16:40, Sami Mujawar wrote:
> >>> This v3 patch series renames the EFI_ACPI_IO_REMAPPING_TABLE_REV0
> >>> macro to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00 based on the
> >>> feedback received. It also includes an additional patch that fixes
> >>> the build break in CelloBoard due to missing VariablePolicyHelperLib
> >>> dependency.
> >>>
> >>> The v2 patch series fixes the build break in Ampere/Jade and
> >>> Pythium/FT2000-4 due to missing VariableFlashInfoLib dependency
> >>> and also updates the IORT revision macro.
> >>>
> >>> The IORT Rev E.d specification updates the IORT table revision
> >>> to 5. Following this the IORT table revision macro
> >>> EFI_ACPI_IO_REMAPPING_TABLE_REVISION which was at Rev 0 has
> >>> been renamed to EFI_ACPI_IO_REMAPPING_TABLE_REV0. Therefore,
> >>> this series updates the following platforms to reflect this
> >>> renaming:
> >>>    - FVP
> >>>    - Morello FVP
> >>>    - SGI
> >>>    - AMD/Styx
> >>>    - Socionext/SynQuacer
> >>>    - RaspberryPi
> >>>    - N1SDP
> >>>    - Ampere/Jade
> >>>    - Pythium/FT2000-4
> >>>
> >>> Note: This patch series is dependent on the edk2 patch series:
> >>>     "[PATCH v5 0/8] IORT Rev E.d specification updates"
> >>>     (https://edk2.groups.io/g/devel/message/91264), which must
> >>>     be merged in edk2 before this patch series can be integrated.
> >>>
> >>> The changes can be seen at:
> >>> https://github.com/samimujawar/edk2-platforms/tree/1527_iort_rev_ed_platforms_v3
> >>>
> >>> Sami Mujawar (12):
> >>>     Platform/ARM: FVP: Update for IORT revision macro renaming
> >>>     Platform/ARM: Morello: Update for IORT revision macro renaming
> >>>     Platform/ARM: SGI: Update for IORT revision macro renaming
> >>>     Silicon/AMD/Styx: Update for IORT revision macro renaming
> >>>     Silicon/Socionext/SynQuacer: Update for IORT revision macro renaming
> >>>     Platform/RaspberryPi: Update for IORT revision macro renaming
> >>>     Platform/ARM: N1SDP: Update for IORT revision macro renaming
> >>>     Silicon/Ampere: Add VariableFlashInfoLib
> >>>     Platform/Ampere: JadePkg: Update for IORT revision macro renaming
> >>>     Silicon/Phytium: Add VariableFlashInfoLib
> >>>     Silicon/Phytium: FT2000-4Pkg: Update for IORT revision macro renaming
> >>>     Platform/LeMaker: Fix missing dependency on VariablePolicyHelperLib
> >>>
> >>>    Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c  | 2 +-
> >>>    Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c       | 2 +-
> >>>    Platform/ARM/SgiPkg/AcpiTables/Iort.aslc                                                     | 2 +-
> >>>    Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +-
> >>>    Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c                                   | 2 +-
> >>>    Platform/LeMaker/CelloBoard/CelloBoard.dsc                                                   | 1 +
> >>>    Platform/RaspberryPi/AcpiTables/Iort.aslc                                                    | 2 +-
> >>>    Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc                                           | 2 +-
> >>>    Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc                                         | 1 +
> >>>    Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc                                     | 2 +-
> >>>    Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc                                    | 1 +
> >>>    Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc                                             | 2 +-
> >>>    12 files changed, 12 insertions(+), 9 deletions(-)
> >>>
> >>
> >>
> >>
> >>
>
>
> 
>
>

Re: [edk2-devel] [PATCH edk2-platforms v3 08/12] Silicon/Ampere: Add VariableFlashInfoLib

[Sami Mujawar]

Hi Nhi,

Looks like the file 
Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc is not in 
upstream edk2-platforms.

See 
https://github.com/tianocore/edk2-platforms/tree/master/Silicon/Ampere/AmpereAltraPkg

Regards,

Sami Mujawar

On 14/07/2022 08:40 am, Sami Mujawar via groups.io wrote:
> Hi Nhi,
>
> I will do that no problem. However, we really need an edk2-platforms 
> CI to catch such issues.
>
> Regards,
>
> Sami Mujawar
>
> On 14/07/2022 04:34 am, Nhi Pham wrote:
>> Hi Sami,
>>
>> Could you help update for 
>> Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc as well?
>>
>> Thanks,
>> Nhi
>>
>> On 12/07/2022 21:40, Sami Mujawar wrote:
>>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
>>>
>>> Add an instance for the library class VariableFlashInfoLib that
>>> was recently introduced in MdeModulePkg. This allows the variable
>>> driver to build successfully as it has a dependency on this
>>> library class.
>>>
>>> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
>>> ---
>>>   Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc 
>>> b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
>>> index 
>>> f4007d654ec81297d4bbe002b2671c211129d819..d4c29c3c338cc8abefd84cbb3ff14d1727bd4fe4 
>>> 100644
>>> --- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
>>> +++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
>>> @@ -154,6 +154,7 @@ [LibraryClasses.common]
>>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf 
>>>
>>>   !endif
>>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf 
>>>
>>> + 
>>> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
>>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf 
>>>
>>>       #
>
>
> 
>
>

Re: [edk2-devel] [PATCH edk2-platforms v3 08/12] Silicon/Ampere: Add VariableFlashInfoLib

[Nhi Pham]

Oops, sorry. I just realized :)

Reviewed-by: Nhi Pham <nhi@os.amperecomputing.com>

Thanks,
-Nhi

On 14/07/2022 16:06, Sami Mujawar wrote:
> Hi Nhi,
>
> Looks like the file 
> Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc is not 
> in upstream edk2-platforms.
>
> See 
> https://github.com/tianocore/edk2-platforms/tree/master/Silicon/Ampere/AmpereAltraPkg
>
> Regards,
>
> Sami Mujawar
>
> On 14/07/2022 08:40 am, Sami Mujawar via groups.io wrote:
>> Hi Nhi,
>>
>> I will do that no problem. However, we really need an edk2-platforms 
>> CI to catch such issues.
>>
>> Regards,
>>
>> Sami Mujawar
>>
>> On 14/07/2022 04:34 am, Nhi Pham wrote:
>>> Hi Sami,
>>>
>>> Could you help update for 
>>> Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc as well?
>>>
>>> Thanks,
>>> Nhi
>>>
>>> On 12/07/2022 21:40, Sami Mujawar wrote:
>>>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
>>>>
>>>> Add an instance for the library class VariableFlashInfoLib that
>>>> was recently introduced in MdeModulePkg. This allows the variable
>>>> driver to build successfully as it has a dependency on this
>>>> library class.
>>>>
>>>> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
>>>> ---
>>>>   Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 +
>>>>   1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc 
>>>> b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
>>>> index 
>>>> f4007d654ec81297d4bbe002b2671c211129d819..d4c29c3c338cc8abefd84cbb3ff14d1727bd4fe4 
>>>> 100644
>>>> --- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
>>>> +++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
>>>> @@ -154,6 +154,7 @@ [LibraryClasses.common]
>>>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf 
>>>>
>>>>   !endif
>>>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf 
>>>>
>>>> + 
>>>> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
>>>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf 
>>>>
>>>>       #
>>
>>
>> 
>>
>>

Re: [PATCH edk2-platforms v3 03/12] Platform/ARM: SGI: Update for IORT revision macro renaming

[Thomas Abraham]

On 12/07/2022 15:40, Sami Mujawar wrote:
> The IORT Specification E.d updates the IORT table revision to 5. To
> reflect this change the IORT header file has been updated to rename
> the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
> EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
> 
> Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
> macro in the IORT table for SGI platforms to
> EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
> 
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
>   Platform/ARM/SgiPkg/AcpiTables/Iort.aslc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc b/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc
> index fcc28a71c82eb0c78c96d60c9d9eb1554adb41a3..a7ad92622a905f5b1fd725d5d673a2643685f9af 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc
> +++ b/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc
> @@ -50,7 +50,7 @@ ARM_EFI_ACPI_6_0_IO_REMAPPING_TABLE Iort =
>        (
>          EFI_ACPI_6_2_IO_REMAPPING_TABLE_SIGNATURE,
>          ARM_EFI_ACPI_6_0_IO_REMAPPING_TABLE,
> -       EFI_ACPI_IO_REMAPPING_TABLE_REVISION
> +       EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00
>        ),
>        3,  // NumNodes
>        sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE),  // NodeOffset

Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>

Thanks.