From: "Kun Qin" <kuqin12@gmail.com>
To: devel@edk2.groups.io
Cc: Jiewen Yao <jiewen.yao@intel.com>,
Jian J Wang <jian.j.wang@intel.com>,
Qi Zhang <qi1.zhang@intel.com>,
Rahul Kumar <rahul1.kumar@intel.com>
Subject: [edk2-staging][PATCH v2 3/3] SecurityPkg: SubClassTpm: Updated default value
Date: Wed, 13 Jul 2022 19:27:38 -0700 [thread overview]
Message-ID: <20220714022738.110-4-kuqin12@gmail.com> (raw)
In-Reply-To: <20220714022738.110-1-kuqin12@gmail.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3966
This change updated the default value of TPM device subclass PCD to
`0x010E0000` in order to match the definition of EFI_PERIPHERAL_TPM
from PI specification.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Qi Zhang <qi1.zhang@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Signed-off-by: Kun Qin <kuqin12@gmail.com>
---
Notes:
v2:
- No change
SecurityPkg/SecurityPkg.dec | 6 +++---
SecurityPkg/SecurityPkg.uni | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec
index 7ecf9565d98c..49fc030e2da3 100644
--- a/SecurityPkg/SecurityPkg.dec
+++ b/SecurityPkg/SecurityPkg.dec
@@ -315,10 +315,10 @@ [PcdsFixedAtBuild, PcdsPatchableInModule]
gEfiSecurityPkgTokenSpaceGuid.PcdTpmPlatformClass|0|UINT8|0x00000006
## Progress Code for TPM device subclass definitions.<BR><BR>
- # EFI_PERIPHERAL_TPM = (EFI_PERIPHERAL | 0x000D0000) = 0x010D0000<BR>
+ # EFI_PERIPHERAL_TPM = (EFI_PERIPHERAL | 0x000E0000) = 0x010E0000<BR>
# @Prompt Status Code for TPM device definitions
- # @ValidList 0x80000003 | 0x010D0000
- gEfiSecurityPkgTokenSpaceGuid.PcdStatusCodeSubClassTpmDevice|0x010D0000|UINT32|0x00000007
+ # @ValidList 0x80000003 | 0x010E0000
+ gEfiSecurityPkgTokenSpaceGuid.PcdStatusCodeSubClassTpmDevice|0x010E0000|UINT32|0x00000007
## Defines the IO port used to trigger a software System Management Interrupt (SMI).<BR><BR>
# Used as the SMI Command IO port by security functionality that triggers a software SMI such
diff --git a/SecurityPkg/SecurityPkg.uni b/SecurityPkg/SecurityPkg.uni
index 68587304d779..6c28b8021333 100644
--- a/SecurityPkg/SecurityPkg.uni
+++ b/SecurityPkg/SecurityPkg.uni
@@ -169,7 +169,7 @@
#string STR_gEfiSecurityPkgTokenSpaceGuid_PcdStatusCodeSubClassTpmDevice_PROMPT #language en-US "Status Code for TPM device definitions"
#string STR_gEfiSecurityPkgTokenSpaceGuid_PcdStatusCodeSubClassTpmDevice_HELP #language en-US "Progress Code for TPM device subclass definitions.<BR><BR>\n"
- "EFI_PERIPHERAL_TPM = (EFI_PERIPHERAL | 0x000D0000) = 0x010D0000<BR>"
+ "EFI_PERIPHERAL_TPM = (EFI_PERIPHERAL | 0x000E0000) = 0x010E0000<BR>"
#string STR_gEfiSecurityPkgTokenSpaceGuid_PcdRsa2048Sha256PublicKeyBuffer_PROMPT #language en-US "One or more SHA 256 Hashes of RSA 2048 bit public keys used to verify Recovery and Capsule Update images"
--
2.37.0.windows.1
next prev parent reply other threads:[~2022-07-14 2:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 2:27 [edk2-staging][PATCH v2 0/3] Add TPM subclass definition Kun Qin
2022-07-14 2:27 ` [edk2-staging][PATCH v2 1/3] EDK2 Code First: PI Specification: New peripheral subclass for TPM Kun Qin
2022-07-14 2:27 ` [edk2-staging][PATCH v2 2/3] MdePkg: MmCommunication: Add TPM subclass definition to MdePkg Kun Qin
2022-07-14 2:27 ` Kun Qin [this message]
2022-07-15 16:27 ` [edk2-devel] [edk2-staging][PATCH v2 0/3] Add TPM subclass definition Michael D Kinney
2022-07-15 16:35 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220714022738.110-4-kuqin12@gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox