[PATCH edk2-platforms v4 00/17] Fix build breaks and update IORT revision macro

[PATCH edk2-platforms v4 00/17] Fix build breaks and update IORT revision macro

[Sami Mujawar]

This v4 series includes 5 additional patches (13-17) that
fix various build breaks caused by changes in edk2 repo.
The patches 1-12 have not changed between v3 series, except
updates to the r-b received.

The v3 patch series renames the EFI_ACPI_IO_REMAPPING_TABLE_REV0
macro to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00 based on the
feedback received. It also includes an additional patch that fixes
the build break in CelloBoard due to missing VariablePolicyHelperLib
dependency.

The v2 patch series fixes the build break in Ampere/Jade and
Pythium/FT2000-4 due to missing VariableFlashInfoLib dependency
and also updates the IORT revision macro.

The IORT Rev E.d specification updates the IORT table revision
to 5. Following this the IORT table revision macro 
EFI_ACPI_IO_REMAPPING_TABLE_REVISION which was at Rev 0 has
been renamed to EFI_ACPI_IO_REMAPPING_TABLE_REV0. Therefore,
this series updates the following platforms to reflect this
renaming:
 - FVP
 - Morello FVP
 - SGI
 - AMD/Styx
 - Socionext/SynQuacer
 - RaspberryPi
 - N1SDP
 - Ampere/Jade
 - Pythium/FT2000-4

Note: This patch series is dependent on the edk2 patch series:
  "[PATCH v6 0/8] IORT Rev E.d specification updates"
  (https://edk2.groups.io/g/devel/message/91361), which must
  be merged in edk2 before this patch series can be integrated.

The changes can be seen at:
https://github.com/samimujawar/edk2-platforms/tree/1527_iort_rev_ed_platforms_v4

Sami Mujawar (17):
  Platform/ARM: FVP: Update for IORT revision macro renaming
  Platform/ARM: Morello: Update for IORT revision macro renaming
  Platform/ARM: SGI: Update for IORT revision macro renaming
  Silicon/AMD/Styx: Update for IORT revision macro renaming
  Silicon/Socionext/SynQuacer: Update for IORT revision macro renaming
  Platform/RaspberryPi: Update for IORT revision macro renaming
  Platform/ARM: N1SDP: Update for IORT revision macro renaming
  Silicon/Ampere: Add VariableFlashInfoLib
  Platform/Ampere: JadePkg: Update for IORT revision macro renaming
  Silicon/Phytium: Add VariableFlashInfoLib
  Silicon/Phytium: FT2000-4Pkg: Update for IORT revision macro renaming
  Platform/LeMaker: Fix missing dependency on VariablePolicyHelperLib
  Platform/Socionext: Fix missing dependency on VariableFlashInfoLib
  Silicon/NXP: Fix missing dependency on VariableFlashInfoLib
  Platform/NXP/LS1043aRdbPk: Fix build break due to change in
    ARM_CORE_INFO
  Platform/NXP/LS1046aFrwyPkg: Fix build break due to change in
    ARM_CORE_INFO
  Platform/NXP/LX2160aRdbPkg: Fix build break due to change in
    ARM_CORE_INFO

 Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c  | 2 +-
 Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c       | 2 +-
 Platform/ARM/SgiPkg/AcpiTables/Iort.aslc                                                     | 2 +-
 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +-
 Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c                                   | 2 +-
 Platform/LeMaker/CelloBoard/CelloBoard.dsc                                                   | 1 +
 Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c                           | 2 +-
 Platform/NXP/LS1046aFrwyPkg/Library/ArmPlatformLib/ArmPlatformLib.c                          | 2 +-
 Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c                           | 2 +-
 Platform/RaspberryPi/AcpiTables/Iort.aslc                                                    | 2 +-
 Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc                                         | 1 +
 Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc                                           | 2 +-
 Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc                                         | 1 +
 Silicon/NXP/NxpQoriqLs.dsc.inc                                                               | 1 +
 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc                                     | 2 +-
 Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc                                    | 1 +
 Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc                                             | 2 +-
 17 files changed, 17 insertions(+), 12 deletions(-)

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v4 01/17] Platform/ARM: FVP: Update for IORT revision macro renaming

[Sami Mujawar]

The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the Configuration Manager for FVP platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
---
 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index 0ba854610becff7d2544e26ec67a331783bbe75f..58a4bf9890bc2a701dab558a1987f9a51662481a 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -82,7 +82,7 @@ EDKII_PLATFORM_REPOSITORY_INFO VExpressPlatRepositoryInfo = {
     // IORT Table - FVP RevC
     {
       EFI_ACPI_6_3_IO_REMAPPING_TABLE_SIGNATURE,
-      EFI_ACPI_IO_REMAPPING_TABLE_REVISION,
+      EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00,
       CREATE_STD_ACPI_TABLE_GEN_ID (EStdAcpiTableIdIort),
       NULL
     },
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v4 02/17] Platform/ARM: Morello: Update for IORT revision macro renaming

[Sami Mujawar]

The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the Configuration Manager for Morello FVP to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
---
 Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c b/Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c
index ed2fdfeff9a02b13729cdd5d6f334f7bcabe679f..85b0d390598ffd9739059d1ee1c7aae312aba48c 100644
--- a/Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c
+++ b/Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c
@@ -76,7 +76,7 @@ EDKII_FVP_PLATFORM_REPOSITORY_INFO MorelloFvpRepositoryInfo = {
     // IORT Table
     {
       EFI_ACPI_6_3_IO_REMAPPING_TABLE_SIGNATURE,
-      EFI_ACPI_IO_REMAPPING_TABLE_REVISION,
+      EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00,
       CREATE_STD_ACPI_TABLE_GEN_ID (EStdAcpiTableIdIort),
       NULL
     },
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v4 03/17] Platform/ARM: SGI: Update for IORT revision macro renaming

[Sami Mujawar]

The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for SGI platforms to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>
---
 Platform/ARM/SgiPkg/AcpiTables/Iort.aslc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc b/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc
index fcc28a71c82eb0c78c96d60c9d9eb1554adb41a3..a7ad92622a905f5b1fd725d5d673a2643685f9af 100644
--- a/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc
+++ b/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc
@@ -50,7 +50,7 @@ ARM_EFI_ACPI_6_0_IO_REMAPPING_TABLE Iort =
      (
        EFI_ACPI_6_2_IO_REMAPPING_TABLE_SIGNATURE,
        ARM_EFI_ACPI_6_0_IO_REMAPPING_TABLE,
-       EFI_ACPI_IO_REMAPPING_TABLE_REVISION
+       EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00
      ),
      3,  // NumNodes
      sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE),  // NodeOffset
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v4 04/17] Silicon/AMD/Styx: Update for IORT revision macro renaming

[Sami Mujawar]

The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for Styx platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
---
 Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc b/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc
index b81f87b7794eec47042910d77efcb609563991a8..27d443494bd312ab7d96d8072a9f4c1e9a98b1ae 100644
--- a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc
+++ b/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc
@@ -139,7 +139,7 @@ STATIC STYX_IO_REMAPPING_STRUCTURE AcpiIort = {
   {
     AMD_ACPI_HEADER(EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE,
                     STYX_IO_REMAPPING_STRUCTURE,
-                    EFI_ACPI_IO_REMAPPING_TABLE_REVISION),
+                    EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00),
     11,                                             // NumNodes
     sizeof(EFI_ACPI_6_0_IO_REMAPPING_TABLE),        // NodeOffset
     0                                               // Reserved
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v4 05/17] Silicon/Socionext/SynQuacer: Update for IORT revision macro renaming

[Sami Mujawar]

The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for SynQuacer platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
---
 Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc b/Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc
index 4627347028132395de757ff7c81b00848057632d..293888cbbe21686e9061e988c036ff487d7b35cb 100644
--- a/Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc
+++ b/Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc
@@ -56,7 +56,7 @@ STATIC SYNQUACER_IO_REMAPPING_STRUCTURE Iort = {
   {
     __ACPI_HEADER(EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE,
                   SYNQUACER_IO_REMAPPING_STRUCTURE,
-                  EFI_ACPI_IO_REMAPPING_TABLE_REVISION),
+                  EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00),
     6,                                              // NumNodes
     sizeof(EFI_ACPI_6_0_IO_REMAPPING_TABLE),        // NodeOffset
     0                                               // Reserved
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v4 06/17] Platform/RaspberryPi: Update for IORT revision macro renaming

[Sami Mujawar]

The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for RaspberryPi platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
---
 Platform/RaspberryPi/AcpiTables/Iort.aslc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/RaspberryPi/AcpiTables/Iort.aslc b/Platform/RaspberryPi/AcpiTables/Iort.aslc
index 810307ae376f7d24790775f499daa09e3137fe6c..78efabb94739862275199bdac3d678f3586d9b94 100644
--- a/Platform/RaspberryPi/AcpiTables/Iort.aslc
+++ b/Platform/RaspberryPi/AcpiTables/Iort.aslc
@@ -28,7 +28,7 @@ STATIC RPI4_IO_REMAPPING_STRUCTURE Iort = {
   {
     ACPI_HEADER (EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE,
                  RPI4_IO_REMAPPING_STRUCTURE,
-                 EFI_ACPI_IO_REMAPPING_TABLE_REVISION),
+                 EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00),
     3,                                              // NumNodes
     sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE),       // NodeOffset
     0                                               // Reserved
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v4 07/17] Platform/ARM: N1SDP: Update for IORT revision macro renaming

[Sami Mujawar]

The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for N1SDP platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
---
 Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index f50623ae3faccc862eef1968674dee8bd33fbdd6..a6b4cb0ef482541da2c9244c1135f10ccbbfbaf9 100644
--- a/Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -90,7 +90,7 @@ EDKII_PLATFORM_REPOSITORY_INFO N1sdpRepositoryInfo = {
     // IORT Table
     {
       EFI_ACPI_6_3_IO_REMAPPING_TABLE_SIGNATURE,
-      EFI_ACPI_IO_REMAPPING_TABLE_REVISION,
+      EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00,
       CREATE_STD_ACPI_TABLE_GEN_ID (EStdAcpiTableIdIort),
       NULL
     },
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v4 08/17] Silicon/Ampere: Add VariableFlashInfoLib

[Sami Mujawar]

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479

Add an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This allows the variable
driver to build successfully as it has a dependency on this
library class.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
Reviewed-by: Nhi Pham <nhi@os.amperecomputing.com>
---
 Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
index f4007d654ec81297d4bbe002b2671c211129d819..d4c29c3c338cc8abefd84cbb3ff14d1727bd4fe4 100644
--- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
+++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
@@ -154,6 +154,7 @@ [LibraryClasses.common]
   AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
 !endif
   VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
+  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
 
   #
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v4 09/17] Platform/Ampere: JadePkg: Update for IORT revision macro renaming

[Sami Mujawar]

The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for SynQuacer platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
Reviewed-by: Nhi Pham <nhi@os.amperecomputing.com>
---
 Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c
index 97be85c51f253422851ba139ee60bc8fc681aa87..958708810a4918b1683ecc5fb021b59a7191e207 100644
--- a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c
+++ b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c
@@ -87,7 +87,7 @@ EFI_ACPI_6_0_IO_REMAPPING_TABLE mIortHeader = {
   .Header = __ACPI_HEADER (
               EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE,
               AC01_IO_REMAPPING_STRUCTURE,
-              EFI_ACPI_IO_REMAPPING_TABLE_REVISION
+              EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00
               ),
   .NumNodes = 0,  // To be filled
   .NodeOffset = sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE),
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v4 10/17] Silicon/Phytium: Add VariableFlashInfoLib

[Sami Mujawar]

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479

Add an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This allows the variable
driver to build successfully as it has a dependency on this
library class.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
---
 Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc b/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
index 2565b8ac626abc2073d201ad43e057f2fbbf4cbc..a7ca630be7b98e784261bc9a7543fdcc71151337 100644
--- a/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
+++ b/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
@@ -98,6 +98,7 @@ [LibraryClasses.common]
   UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
 
   VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
+  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
 
   #
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v4 11/17] Silicon/Phytium: FT2000-4Pkg: Update for IORT revision macro renaming

[Sami Mujawar]

The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for SynQuacer platform to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
---
 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc b/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc
index 4239499b68e5923604625e05a0425fc11ab6664e..9c3a5eea72cbeb20ef48450789630a15094f0372 100644
--- a/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc
+++ b/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc
@@ -42,7 +42,7 @@ STATIC PHYTIUM_IO_REMAPPING_STRUCTURE Iort = {
   {
     PHYTIUM_ACPI_HEADER (EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE,
                   PHYTIUM_IO_REMAPPING_STRUCTURE,
-                  EFI_ACPI_IO_REMAPPING_TABLE_REVISION),
+                  EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00),
     2,                                              // NumNodes
     sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE),       // NodeOffset
     0                                               // Reserved
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v4 12/17] Platform/LeMaker: Fix missing dependency on VariablePolicyHelperLib

[Sami Mujawar]

The CelloBoard platform firmware build breaks due to the missing
dependency on VariablePolicyHelperLib.

Therefore, to satisfy the dependency include VariablePolicyHelperLib
in the LibraryClasses.common section.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
---
 Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
index 6be8062e60f6a83a357edbdbbbdf7a35dc10f044..0b98d976f9c47da6864889ef558fc73f8a820498 100644
--- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc
+++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
@@ -121,6 +121,7 @@ [LibraryClasses.common]
 
   VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
+  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
   CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
   UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
   BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v4 13/17] Platform/Socionext: Fix missing dependency on VariableFlashInfoLib

[Sami Mujawar]

The DeveloperBox platform firmware build breaks due to the missing
dependency on VariableFlashInfoLib.

Therefore, to satisfy the dependency include VariableFlashInfoLib
in the LibraryClasses section.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
index c034c0a32cfdc9b30b169c7b051595dee1696ed6..d8524c438c2c64e9f4bb31a3f9b0127ecc1ddb2e 100644
--- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
+++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
@@ -112,6 +112,7 @@ [LibraryClasses]
   NorFlashInfoLib|EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf
   NorFlashPlatformLib|Silicon/Socionext/SynQuacer/Library/NorFlashSynQuacerLib/NorFlashSynQuacerLib.inf
 
+  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
 
 [LibraryClasses.common.UEFI_DRIVER, LibraryClasses.common.MM_STANDALONE]
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v4 14/17] Silicon/NXP: Fix missing dependency on VariableFlashInfoLib

[Sami Mujawar]

The NXP platform firmware build breaks due to the missing
dependency on VariableFlashInfoLib.

Therefore, to satisfy the dependency include VariableFlashInfoLib
in the LibraryClasses.common section.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 Silicon/NXP/NxpQoriqLs.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Silicon/NXP/NxpQoriqLs.dsc.inc b/Silicon/NXP/NxpQoriqLs.dsc.inc
index 99a317aba7e687d2a30ee78443c2a3dfe085ac05..80b26fc643c412a4e22046918e3cf105f58db9f5 100644
--- a/Silicon/NXP/NxpQoriqLs.dsc.inc
+++ b/Silicon/NXP/NxpQoriqLs.dsc.inc
@@ -91,6 +91,7 @@ [LibraryClasses.common]
   TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
   AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
   VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
+  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
   NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
   CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

[PATCH edk2-platforms v4 15/17] Platform/NXP/LS1043aRdbPk: Fix build break due to change in ARM_CORE_INFO

[Sami Mujawar]

The edk2 patch at 103fa647d159e3d76be2634d2653c2d215dd0d46
updated the ARM_CORE_INFO structure to remove the ClusterId
and CoreId fields in the ARM_CORE_INFO structure in favor of
a new Mpidr field.

Therefore, fix the ArmPlatformLibrary instance for
Platform/NXP/LS1043aRdbPkg accordingly.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c
index dc81e7ba3101902799bf6b6301113caafb4e1c89..4e7d7741a00b2198817a72c06aa977cc4e02c0ad 100644
--- a/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c
+++ b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c
@@ -94,7 +94,7 @@ ArmPlatformInitialize (
 ARM_CORE_INFO LS1043aMpCoreInfoCTA53x4[] = {
   {
     // Cluster 0, Core 0
-    0x0, 0x0,
+    0x0,

     // MP Core MailBox Set/Get/Clear Addresses and Clear Value
     (EFI_PHYSICAL_ADDRESS)0,
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

[PATCH edk2-platforms v4 16/17] Platform/NXP/LS1046aFrwyPkg: Fix build break due to change in ARM_CORE_INFO

[Sami Mujawar]

The edk2 patch at 103fa647d159e3d76be2634d2653c2d215dd0d46
updated the ARM_CORE_INFO structure to remove the ClusterId
and CoreId fields in the ARM_CORE_INFO structure in favor of
a new Mpidr field.

Therefore, fix the ArmPlatformLibrary instance for
Platform/NXP/LS1046aFrwyPkg accordingly.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 Platform/NXP/LS1046aFrwyPkg/Library/ArmPlatformLib/ArmPlatformLib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/NXP/LS1046aFrwyPkg/Library/ArmPlatformLib/ArmPlatformLib.c b/Platform/NXP/LS1046aFrwyPkg/Library/ArmPlatformLib/ArmPlatformLib.c
index ef404991add8345b1c5520c8989558e78906f518..8b8524b28203b76932d0a1533ef09d088a88f0f7 100644
--- a/Platform/NXP/LS1046aFrwyPkg/Library/ArmPlatformLib/ArmPlatformLib.c
+++ b/Platform/NXP/LS1046aFrwyPkg/Library/ArmPlatformLib/ArmPlatformLib.c
@@ -23,7 +23,7 @@
 ARM_CORE_INFO mLS1046aMpCoreInfoTable[] = {
   {
     // Cluster 0, Core 0
-    0x0, 0x0,
+    0x0,

     // MP Core MailBox Set/Get/Clear Addresses and Clear Value
     (EFI_PHYSICAL_ADDRESS)0,
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

[PATCH edk2-platforms v4 17/17] Platform/NXP/LX2160aRdbPkg: Fix build break due to change in ARM_CORE_INFO

[Sami Mujawar]

The edk2 patch at 103fa647d159e3d76be2634d2653c2d215dd0d46
updated the ARM_CORE_INFO structure to remove the ClusterId
and CoreId fields in the ARM_CORE_INFO structure in favor of
a new Mpidr field.

Therefore, fix the ArmPlatformLibrary instance for
Platform/NXP/LX2160aRdbPkg accordingly.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c b/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c
index f3f1e5b3f220a6b5c83a035539607d93c801260e..62e03daed6207668b98d12c5bd7c7ca4cef0184c 100644
--- a/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c
+++ b/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c
@@ -16,7 +16,7 @@
 ARM_CORE_INFO mLX2160aMpCoreInfoTable[] = {
   {
     // Cluster 0, Core 0
-    0x0, 0x0,
+    0x0,

     // MP Core MailBox Set/Get/Clear Addresses and Clear Value
     (EFI_PHYSICAL_ADDRESS)0,
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [PATCH edk2-platforms v4 00/17] Fix build breaks and update IORT revision macro

[Sami Mujawar]

Hi All,

The IORT Rev E.d seriesfor edk2 has received the r-b from the respective 
maintainers.

Can the following package maintainers review this series and provide 
feedback, please?

- Silicon/AMD/Styx

- Silicon/Socionext/SynQuacer

- Platform/LeMaker

- Platform/Socionext

- Silicon/NXP & Platform/NXP/*

Regards,

Sami Mujawar

On 14/07/2022 05:55 pm, Sami Mujawar wrote:
> This v4 series includes 5 additional patches (13-17) that
> fix various build breaks caused by changes in edk2 repo.
> The patches 1-12 have not changed between v3 series, except
> updates to the r-b received.
>
> The v3 patch series renames the EFI_ACPI_IO_REMAPPING_TABLE_REV0
> macro to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00 based on the
> feedback received. It also includes an additional patch that fixes
> the build break in CelloBoard due to missing VariablePolicyHelperLib
> dependency.
>
> The v2 patch series fixes the build break in Ampere/Jade and
> Pythium/FT2000-4 due to missing VariableFlashInfoLib dependency
> and also updates the IORT revision macro.
>
> The IORT Rev E.d specification updates the IORT table revision
> to 5. Following this the IORT table revision macro
> EFI_ACPI_IO_REMAPPING_TABLE_REVISION which was at Rev 0 has
> been renamed to EFI_ACPI_IO_REMAPPING_TABLE_REV0. Therefore,
> this series updates the following platforms to reflect this
> renaming:
>   - FVP
>   - Morello FVP
>   - SGI
>   - AMD/Styx
>   - Socionext/SynQuacer
>   - RaspberryPi
>   - N1SDP
>   - Ampere/Jade
>   - Pythium/FT2000-4
>
> Note: This patch series is dependent on the edk2 patch series:
>    "[PATCH v6 0/8] IORT Rev E.d specification updates"
>    (https://edk2.groups.io/g/devel/message/91361), which must
>    be merged in edk2 before this patch series can be integrated.
>
> The changes can be seen at:
> https://github.com/samimujawar/edk2-platforms/tree/1527_iort_rev_ed_platforms_v4
>
> Sami Mujawar (17):
>    Platform/ARM: FVP: Update for IORT revision macro renaming
>    Platform/ARM: Morello: Update for IORT revision macro renaming
>    Platform/ARM: SGI: Update for IORT revision macro renaming
>    Silicon/AMD/Styx: Update for IORT revision macro renaming
>    Silicon/Socionext/SynQuacer: Update for IORT revision macro renaming
>    Platform/RaspberryPi: Update for IORT revision macro renaming
>    Platform/ARM: N1SDP: Update for IORT revision macro renaming
>    Silicon/Ampere: Add VariableFlashInfoLib
>    Platform/Ampere: JadePkg: Update for IORT revision macro renaming
>    Silicon/Phytium: Add VariableFlashInfoLib
>    Silicon/Phytium: FT2000-4Pkg: Update for IORT revision macro renaming
>    Platform/LeMaker: Fix missing dependency on VariablePolicyHelperLib
>    Platform/Socionext: Fix missing dependency on VariableFlashInfoLib
>    Silicon/NXP: Fix missing dependency on VariableFlashInfoLib
>    Platform/NXP/LS1043aRdbPk: Fix build break due to change in
>      ARM_CORE_INFO
>    Platform/NXP/LS1046aFrwyPkg: Fix build break due to change in
>      ARM_CORE_INFO
>    Platform/NXP/LX2160aRdbPkg: Fix build break due to change in
>      ARM_CORE_INFO
>
>   Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c  | 2 +-
>   Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c       | 2 +-
>   Platform/ARM/SgiPkg/AcpiTables/Iort.aslc                                                     | 2 +-
>   Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +-
>   Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c                                   | 2 +-
>   Platform/LeMaker/CelloBoard/CelloBoard.dsc                                                   | 1 +
>   Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c                           | 2 +-
>   Platform/NXP/LS1046aFrwyPkg/Library/ArmPlatformLib/ArmPlatformLib.c                          | 2 +-
>   Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c                           | 2 +-
>   Platform/RaspberryPi/AcpiTables/Iort.aslc                                                    | 2 +-
>   Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc                                         | 1 +
>   Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc                                           | 2 +-
>   Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc                                         | 1 +
>   Silicon/NXP/NxpQoriqLs.dsc.inc                                                               | 1 +
>   Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc                                     | 2 +-
>   Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc                                    | 1 +
>   Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc                                             | 2 +-
>   17 files changed, 17 insertions(+), 12 deletions(-)
>

Re: [edk2-devel] [PATCH edk2-platforms v4 00/17] Fix build breaks and update IORT revision macro

[Sami Mujawar]

Hi All,

Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3458

The edk2 patch series for IORT Rev E.d updates has been submitted to the mailing list and has been reviewed at 
https://edk2.groups.io/g/devel/message/91361

The corresponding edk2-platforms series is posted on the mailing list at https://edk2.groups.io/g/devel/message/91543

The edk2-platforms series fixes a number of build breaks as well as makes the necessary updates to reflect the changes due to IORT Rev E.d updates.

I would prefer this patch series to be merged in the edk2-stable202208 tag. Therefore, requesting review for the edk2-platform patches from the respective maintainers for the following modules:
- Silicon/AMD/Styx
- Silicon/Socionext/SynQuacer
- Platform/LeMaker
- Platform/Socionext
- Silicon/NXP & Platform/NXP/*

Regards,

Sami Mujawar


On 19/07/2022, 17:24, "devel@edk2.groups.io on behalf of Sami Mujawar via groups.io" <devel@edk2.groups.io on behalf of sami.mujawar=arm.com@groups.io> wrote:

    Hi All,

    The IORT Rev E.d seriesfor edk2 has received the r-b from the respective 
    maintainers.

    Can the following package maintainers review this series and provide 
    feedback, please?

    - Silicon/AMD/Styx

    - Silicon/Socionext/SynQuacer

    - Platform/LeMaker

    - Platform/Socionext

    - Silicon/NXP & Platform/NXP/*

    Regards,

    Sami Mujawar

    On 14/07/2022 05:55 pm, Sami Mujawar wrote:
    > This v4 series includes 5 additional patches (13-17) that
    > fix various build breaks caused by changes in edk2 repo.
    > The patches 1-12 have not changed between v3 series, except
    > updates to the r-b received.
    >
    > The v3 patch series renames the EFI_ACPI_IO_REMAPPING_TABLE_REV0
    > macro to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00 based on the
    > feedback received. It also includes an additional patch that fixes
    > the build break in CelloBoard due to missing VariablePolicyHelperLib
    > dependency.
    >
    > The v2 patch series fixes the build break in Ampere/Jade and
    > Pythium/FT2000-4 due to missing VariableFlashInfoLib dependency
    > and also updates the IORT revision macro.
    >
    > The IORT Rev E.d specification updates the IORT table revision
    > to 5. Following this the IORT table revision macro
    > EFI_ACPI_IO_REMAPPING_TABLE_REVISION which was at Rev 0 has
    > been renamed to EFI_ACPI_IO_REMAPPING_TABLE_REV0. Therefore,
    > this series updates the following platforms to reflect this
    > renaming:
    >   - FVP
    >   - Morello FVP
    >   - SGI
    >   - AMD/Styx
    >   - Socionext/SynQuacer
    >   - RaspberryPi
    >   - N1SDP
    >   - Ampere/Jade
    >   - Pythium/FT2000-4
    >
    > Note: This patch series is dependent on the edk2 patch series:
    >    "[PATCH v6 0/8] IORT Rev E.d specification updates"
    >    (https://edk2.groups.io/g/devel/message/91361), which must
    >    be merged in edk2 before this patch series can be integrated.
    >
    > The changes can be seen at:
    > https://github.com/samimujawar/edk2-platforms/tree/1527_iort_rev_ed_platforms_v4
    >
    > Sami Mujawar (17):
    >    Platform/ARM: FVP: Update for IORT revision macro renaming
    >    Platform/ARM: Morello: Update for IORT revision macro renaming
    >    Platform/ARM: SGI: Update for IORT revision macro renaming
    >    Silicon/AMD/Styx: Update for IORT revision macro renaming
    >    Silicon/Socionext/SynQuacer: Update for IORT revision macro renaming
    >    Platform/RaspberryPi: Update for IORT revision macro renaming
    >    Platform/ARM: N1SDP: Update for IORT revision macro renaming
    >    Silicon/Ampere: Add VariableFlashInfoLib
    >    Platform/Ampere: JadePkg: Update for IORT revision macro renaming
    >    Silicon/Phytium: Add VariableFlashInfoLib
    >    Silicon/Phytium: FT2000-4Pkg: Update for IORT revision macro renaming
    >    Platform/LeMaker: Fix missing dependency on VariablePolicyHelperLib
    >    Platform/Socionext: Fix missing dependency on VariableFlashInfoLib
    >    Silicon/NXP: Fix missing dependency on VariableFlashInfoLib
    >    Platform/NXP/LS1043aRdbPk: Fix build break due to change in
    >      ARM_CORE_INFO
    >    Platform/NXP/LS1046aFrwyPkg: Fix build break due to change in
    >      ARM_CORE_INFO
    >    Platform/NXP/LX2160aRdbPkg: Fix build break due to change in
    >      ARM_CORE_INFO
    >
    >   Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c  | 2 +-
    >   Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c       | 2 +-
    >   Platform/ARM/SgiPkg/AcpiTables/Iort.aslc                                                     | 2 +-
    >   Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +-
    >   Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c                                   | 2 +-
    >   Platform/LeMaker/CelloBoard/CelloBoard.dsc                                                   | 1 +
    >   Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c                           | 2 +-
    >   Platform/NXP/LS1046aFrwyPkg/Library/ArmPlatformLib/ArmPlatformLib.c                          | 2 +-
    >   Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c                           | 2 +-
    >   Platform/RaspberryPi/AcpiTables/Iort.aslc                                                    | 2 +-
    >   Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc                                         | 1 +
    >   Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc                                           | 2 +-
    >   Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc                                         | 1 +
    >   Silicon/NXP/NxpQoriqLs.dsc.inc                                                               | 1 +
    >   Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc                                     | 2 +-
    >   Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc                                    | 1 +
    >   Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc                                             | 2 +-
    >   17 files changed, 17 insertions(+), 12 deletions(-)
    >


    

Re: [edk2-devel] [PATCH edk2-platforms v4 00/17] Fix build breaks and update IORT revision macro

[Ard Biesheuvel]

On Wed, 27 Jul 2022 at 02:21, Sami Mujawar <sami.mujawar@arm.com> wrote:
>
> Hi All,
>
> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3458
>
> The edk2 patch series for IORT Rev E.d updates has been submitted to the mailing list and has been reviewed at
> https://edk2.groups.io/g/devel/message/91361
>
> The corresponding edk2-platforms series is posted on the mailing list at https://edk2.groups.io/g/devel/message/91543
>
> The edk2-platforms series fixes a number of build breaks as well as makes the necessary updates to reflect the changes due to IORT Rev E.d updates.
>
> I would prefer this patch series to be merged in the edk2-stable202208 tag. Therefore, requesting review for the edk2-platform patches from the respective maintainers for the following modules:
> - Silicon/AMD/Styx
> - Silicon/Socionext/SynQuacer
> - Platform/LeMaker
> - Platform/Socionext
> - Silicon/NXP & Platform/NXP/*
>

For the associated fixes for all the above:

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

Feel free to push all of these changes when you feel it is appropriate.


> On 19/07/2022, 17:24, "devel@edk2.groups.io on behalf of Sami Mujawar via groups.io" <devel@edk2.groups.io on behalf of sami.mujawar=arm.com@groups.io> wrote:
>
>     Hi All,
>
>     The IORT Rev E.d seriesfor edk2 has received the r-b from the respective
>     maintainers.
>
>     Can the following package maintainers review this series and provide
>     feedback, please?
>
>     - Silicon/AMD/Styx
>
>     - Silicon/Socionext/SynQuacer
>
>     - Platform/LeMaker
>
>     - Platform/Socionext
>
>     - Silicon/NXP & Platform/NXP/*
>
>     Regards,
>
>     Sami Mujawar
>
>     On 14/07/2022 05:55 pm, Sami Mujawar wrote:
>     > This v4 series includes 5 additional patches (13-17) that
>     > fix various build breaks caused by changes in edk2 repo.
>     > The patches 1-12 have not changed between v3 series, except
>     > updates to the r-b received.
>     >
>     > The v3 patch series renames the EFI_ACPI_IO_REMAPPING_TABLE_REV0
>     > macro to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00 based on the
>     > feedback received. It also includes an additional patch that fixes
>     > the build break in CelloBoard due to missing VariablePolicyHelperLib
>     > dependency.
>     >
>     > The v2 patch series fixes the build break in Ampere/Jade and
>     > Pythium/FT2000-4 due to missing VariableFlashInfoLib dependency
>     > and also updates the IORT revision macro.
>     >
>     > The IORT Rev E.d specification updates the IORT table revision
>     > to 5. Following this the IORT table revision macro
>     > EFI_ACPI_IO_REMAPPING_TABLE_REVISION which was at Rev 0 has
>     > been renamed to EFI_ACPI_IO_REMAPPING_TABLE_REV0. Therefore,
>     > this series updates the following platforms to reflect this
>     > renaming:
>     >   - FVP
>     >   - Morello FVP
>     >   - SGI
>     >   - AMD/Styx
>     >   - Socionext/SynQuacer
>     >   - RaspberryPi
>     >   - N1SDP
>     >   - Ampere/Jade
>     >   - Pythium/FT2000-4
>     >
>     > Note: This patch series is dependent on the edk2 patch series:
>     >    "[PATCH v6 0/8] IORT Rev E.d specification updates"
>     >    (https://edk2.groups.io/g/devel/message/91361), which must
>     >    be merged in edk2 before this patch series can be integrated.
>     >
>     > The changes can be seen at:
>     > https://github.com/samimujawar/edk2-platforms/tree/1527_iort_rev_ed_platforms_v4
>     >
>     > Sami Mujawar (17):
>     >    Platform/ARM: FVP: Update for IORT revision macro renaming
>     >    Platform/ARM: Morello: Update for IORT revision macro renaming
>     >    Platform/ARM: SGI: Update for IORT revision macro renaming
>     >    Silicon/AMD/Styx: Update for IORT revision macro renaming
>     >    Silicon/Socionext/SynQuacer: Update for IORT revision macro renaming
>     >    Platform/RaspberryPi: Update for IORT revision macro renaming
>     >    Platform/ARM: N1SDP: Update for IORT revision macro renaming
>     >    Silicon/Ampere: Add VariableFlashInfoLib
>     >    Platform/Ampere: JadePkg: Update for IORT revision macro renaming
>     >    Silicon/Phytium: Add VariableFlashInfoLib
>     >    Silicon/Phytium: FT2000-4Pkg: Update for IORT revision macro renaming
>     >    Platform/LeMaker: Fix missing dependency on VariablePolicyHelperLib
>     >    Platform/Socionext: Fix missing dependency on VariableFlashInfoLib
>     >    Silicon/NXP: Fix missing dependency on VariableFlashInfoLib
>     >    Platform/NXP/LS1043aRdbPk: Fix build break due to change in
>     >      ARM_CORE_INFO
>     >    Platform/NXP/LS1046aFrwyPkg: Fix build break due to change in
>     >      ARM_CORE_INFO
>     >    Platform/NXP/LX2160aRdbPkg: Fix build break due to change in
>     >      ARM_CORE_INFO
>     >
>     >   Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c  | 2 +-
>     >   Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c       | 2 +-
>     >   Platform/ARM/SgiPkg/AcpiTables/Iort.aslc                                                     | 2 +-
>     >   Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +-
>     >   Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c                                   | 2 +-
>     >   Platform/LeMaker/CelloBoard/CelloBoard.dsc                                                   | 1 +
>     >   Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c                           | 2 +-
>     >   Platform/NXP/LS1046aFrwyPkg/Library/ArmPlatformLib/ArmPlatformLib.c                          | 2 +-
>     >   Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c                           | 2 +-
>     >   Platform/RaspberryPi/AcpiTables/Iort.aslc                                                    | 2 +-
>     >   Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc                                         | 1 +
>     >   Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc                                           | 2 +-
>     >   Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc                                         | 1 +
>     >   Silicon/NXP/NxpQoriqLs.dsc.inc                                                               | 1 +
>     >   Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc                                     | 2 +-
>     >   Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc                                    | 1 +
>     >   Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc                                             | 2 +-
>     >   17 files changed, 17 insertions(+), 12 deletions(-)
>     >
>
>
>
>
>
>
>
>
> 
>
>