From: "Judah Vang" <judah.vang@intel.com>
To: devel@edk2.groups.io
Subject: [PATCH v3 0/3] CryptoPkg bug fixes
Date: Thu, 14 Jul 2022 15:04:13 -0700 [thread overview]
Message-ID: <20220714220416.1660-1-judah.vang@intel.com> (raw)
https://bugzilla.tianocore.org/show_bug.cgi?id=3990
https://bugzilla.tianocore.org/show_bug.cgi?id=3991
https://bugzilla.tianocore.org/show_bug.cgi?id=3992
There is a memory leak issue with BaseMemAllocation.
It calls AllocatePool() and FreePool() but FreePool()
is not supported in PEI phase so this can cause a memory leak.
There is a #define to deprecate Sha1 functions but not
all the Sha1 function are wrapped around this #define causing
a build error. The fix is to wrap all Sha1 functions with
the #define.
Need crypto AES to be supported for PEI phase and need
crypto KDF to be supported for SMM phase.
Judah Vang (3):
CryptoPkg: Fix memoryleak in BaseMemAllocation
CryptoPkg: Sha1 functions causing build errors
CryptoPkg: Need to enable crypto functions
CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 2 +-
CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +-
CryptoPkg/Library/BaseCryptLib/SysCall/BaseMemAllocation.c | 11 ++++++-----
CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c | 14 +++++++++++++-
4 files changed, 21 insertions(+), 8 deletions(-)
--
2.35.1.windows.2
next reply other threads:[~2022-07-14 22:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 22:04 Judah Vang [this message]
2022-07-14 22:04 ` [PATCH v3 1/3] CryptoPkg: Fix memoryleak in BaseMemAllocation Judah Vang
2022-07-14 22:04 ` [PATCH v3 2/3] CryptoPkg: Sha1 functions causing build errors Judah Vang
2022-07-14 22:04 ` [PATCH v3 3/3] CryptoPkg: Need to enable crypto functions Judah Vang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220714220416.1660-1-judah.vang@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox