From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.2325.1657836288174243203 for ; Thu, 14 Jul 2022 15:04:48 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=AeecNR7+; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: judah.vang@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657836288; x=1689372288; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=ViJZsVfdEruwZNCom3uXXkYK1hTmyWobtVq8Fpw7KQk=; b=AeecNR7+v5hpCHNWFuJJIxmwBCazR/hEnplUz6L3Ygoq6pPkk+Q3FWns o+yWUm4ehky3NcDWFoBjXej1+y4pHSdJvCf2+JHIYwyRmrxZY1C799UDJ GpsDLndjxEFrPIHDM3FCNjS45PxU3RKd0W/tnmSt3XPdGj5uWF1Hi7KkT IqA6EZEXcNPLYGDGlRM9Rstb2u6Wbj9gM0rLFbiB5KjGLHX36fdoHX9l/ F8i3Yy5GoswJhPCQY/aMXr1LEhINDiqiLKy4j1jhUakZcmxdEl/AaKkzy 0i9OT2VSJ/m2Ae7c6O8suL3qOw7Njd9RHoj1aiVyUU/+hP2ZqpN8vftMh g==; X-IronPort-AV: E=McAfee;i="6400,9594,10408"; a="285661700" X-IronPort-AV: E=Sophos;i="5.92,272,1650956400"; d="scan'208";a="285661700" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2022 15:04:39 -0700 X-IronPort-AV: E=Sophos;i="5.92,272,1650956400"; d="scan'208";a="623600207" Received: from jvang-mobl.amr.corp.intel.com ([10.209.53.127]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2022 15:04:39 -0700 From: "Judah Vang" To: devel@edk2.groups.io Subject: [PATCH v3 0/3] CryptoPkg bug fixes Date: Thu, 14 Jul 2022 15:04:13 -0700 Message-Id: <20220714220416.1660-1-judah.vang@intel.com> X-Mailer: git-send-email 2.35.1.windows.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit https://bugzilla.tianocore.org/show_bug.cgi?id=3990 https://bugzilla.tianocore.org/show_bug.cgi?id=3991 https://bugzilla.tianocore.org/show_bug.cgi?id=3992 There is a memory leak issue with BaseMemAllocation. It calls AllocatePool() and FreePool() but FreePool() is not supported in PEI phase so this can cause a memory leak. There is a #define to deprecate Sha1 functions but not all the Sha1 function are wrapped around this #define causing a build error. The fix is to wrap all Sha1 functions with the #define. Need crypto AES to be supported for PEI phase and need crypto KDF to be supported for SMM phase. Judah Vang (3): CryptoPkg: Fix memoryleak in BaseMemAllocation CryptoPkg: Sha1 functions causing build errors CryptoPkg: Need to enable crypto functions CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 2 +- CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- CryptoPkg/Library/BaseCryptLib/SysCall/BaseMemAllocation.c | 11 ++++++----- CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c | 14 +++++++++++++- 4 files changed, 21 insertions(+), 8 deletions(-) -- 2.35.1.windows.2