From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by mx.groups.io with SMTP id smtpd.web12.40587.1658237237575132682 for ; Tue, 19 Jul 2022 06:27:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=q3VsU4BO; spf=pass (domain: gmail.com, ip: 209.85.208.181, mailfrom: aladyshev22@gmail.com) Received: by mail-lj1-f181.google.com with SMTP id o12so17370308ljc.3 for ; Tue, 19 Jul 2022 06:27:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CQohzXBPRAn3YlOG6ZU398Sh/1qcEIPM3RCX/Q2XibA=; b=q3VsU4BOGWqyyO7fv4uBe21VTVD7K2m2n71m690BTy1+xKXJ3jsJ6g2MH1v62ihYq/ qfoqnqgjijckQmISp055w1VhYrcbhQvjG4CxHwOIugp1aNkMkwq44JF6Nd5HFhJjOPMC vi9/AyqDka06XLAB0kVtQ+KU9em8RxBCEA3lLGzexml6KSyohDvkbpHtcf6nu3g11hv5 ZP5b9jTiVl4foVCXvxHdQ5bTZpCD3TX0tmBSF0AYgiS2uOy9iZv+/zKwZxoMiuRbBKEt N+K+IOqTCzLWykWPj3qYCtxK00LhAUlxv5RBsknF9Vz/29+mINieJQ/RzQpr35XhJmv6 drTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CQohzXBPRAn3YlOG6ZU398Sh/1qcEIPM3RCX/Q2XibA=; b=iN4HpeBoWfE81GDCS5kwmgpFgICF8nCTb63iVYjtLrF3PaiTNcbNao8JTVxdtQ8B8q zQWXbyT3H67FAVP8qBT/9lPT+av74wOCGbKPwlLNdfWyO9yepU6o3ivXzgw0qiEBG7RE MTKAc8Ai8lqw0auun36v0suYUg5KydCfKUID7/3yLdtfklY+toLyIabPR5ngMSTMkLh4 KGWgBg8nwTZRnHXjEqOmp6ewTwDNegCR8omWsUHRGt1oLZCfX8wMNTWGwNeJoKwMIY06 PwrhwxF4Mcbs66JIQjVF5ABk3m9A/8K8CKQmVL/SY6XL/tOpcjphwwm5wNxPXK2PKaJ/ mlLA== X-Gm-Message-State: AJIora8NQ+1NWG5fYLqVyBX4nu5eoIJPspaI1OrBipiikDZ41GbAC97C 6SeSWtO40fUQEa64cfOcbXk6tsloCaliUB9C X-Google-Smtp-Source: AGRyM1vljm6hqSYp3Tu6ZeZnCph84LxS5oiVIgUWMxUa6dTdaiLpukqIozbs7BfNFM2wUFTtQllnNA== X-Received: by 2002:a2e:bd0a:0:b0:25d:d2a3:7366 with SMTP id n10-20020a2ebd0a000000b0025dd2a37366mr362183ljq.35.1658237235494; Tue, 19 Jul 2022 06:27:15 -0700 (PDT) Return-Path: Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id b17-20020a2eb911000000b0025d61016a70sm2666312ljb.28.2022.07.19.06.27.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 06:27:15 -0700 (PDT) From: "Konstantin Aladyshev" To: devel@edk2.groups.io Cc: bob.c.feng@intel.com, gaoliming@byosoft.com.cn, yuwei.chen@intel.com, Konstantin Aladyshev Subject: [PATCH v2] BaseTools/VolInfo: Fix EFI_SECTION_GUID_DEFINED parsing Date: Tue, 19 Jul 2022 16:27:15 +0300 Message-Id: <20220719132715.6877-1-aladyshev22@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Currently 'PutFileImage' function is called with arguments that are not advanced on each section parsing. This would lead to an error if EFI_SECTION_GUID_DEFINED is not the first in a file. The same mistake is present in the parsing of CRC32 guided section case. Use correct arguments to fix the issue. Signed-off-by: Konstantin Aladyshev --- BaseTools/Source/C/VolInfo/VolInfo.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/BaseTools/Source/C/VolInfo/VolInfo.c b/BaseTools/Source/C/VolI= nfo/VolInfo.c index ed56587058..b550815765 100644 --- a/BaseTools/Source/C/VolInfo/VolInfo.c +++ b/BaseTools/Source/C/VolInfo/VolInfo.c @@ -2000,8 +2000,8 @@ Returns: Status =3D=0D PutFileImage (=0D ToolInputFile,=0D - (CHAR8*) SectionBuffer + DataOffset,=0D - BufferLength - DataOffset=0D + (CHAR8*)Ptr + DataOffset,=0D + SectionLength - DataOffset=0D );=0D =0D system (SystemCommand);=0D @@ -2043,8 +2043,8 @@ Returns: // CRC32 guided section=0D //=0D Status =3D ParseSection (=0D - SectionBuffer + DataOffset,=0D - BufferLength - DataOffset=0D + Ptr + DataOffset,=0D + SectionLength - DataOffset=0D );=0D if (EFI_ERROR (Status)) {=0D Error (NULL, 0, 0003, "parse of CRC32 GUIDED section failed", NU= LL);=0D --=20 2.25.1