public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Oliver Steffen" <osteffen@redhat.com>
To: devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Chasel Chiu <chasel.chiu@intel.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Nate DeSimone <nathaniel.l.desimone@intel.com>,
	Sami Mujawar <sami.mujawar@arm.com>,
	Star Zeng <star.zeng@intel.com>, Andrew Fish <afish@apple.com>,
	Oliver Steffen <osteffen@redhat.com>
Subject: [PATCH 0/3] ArmPlatformPkg, ArmVirtPkg: Add early hello message
Date: Tue, 26 Jul 2022 09:28:45 +0200	[thread overview]
Message-ID: <20220726072848.640026-1-osteffen@redhat.com> (raw)


Add the ability to print an early hello message independent of debug
mask to the serial port when the firmware starts. Introduce a PCD entry
to set the message text (ArmPlatformPkg). If the message text is empty
(default) then nothing is printed.

The message is useful for debugging boot problems, especially with
silent firmware builds. It can take some seconds until the first line is
printed when booting the firmware, for example when running ArmVirt in
Qemu.

Use the above in ArmVirtPkg by defining a message text.

These changes have already been proposed by Laszlo Ersek in 2015.
I am reposting because I find this useful.


Example of a VM starting up, AARCH64, Qemu on X64). First line is the
new message. (Timestamp in seconds).

-VM start-
0000.094 | UEFI firmware starting.
00004.06 | BdsDxe: failed to load Boot0001 "UEFI Misc Device" from VenHw(93E34C7E-B50E-11DF-9223-2443DFD72085,00): Not Found
00004.08 | BdsDxe: loading Boot0002 "UEFI Misc Device 2" from PciRoot(0x0)/Pci(0x2,0x0)
00004.08 | BdsDxe: starting Boot0002 "UEFI Misc Device 2" from PciRoot(0x0)/Pci(0x2,0x0)
00004.11 | System BootOrder not found.  Initializing defaults.
00004.11 | Creating boot entry "Boot0005" with label "Red Hat Enterprise Linux" for file "\EFI\redhat\shimaa64.efi"
00004.15 |
00008.39 | EFI stub: Booting Linux Kernel...
[...]


PR: https://github.com/tianocore/edk2/pull/3140

Signed-off-by: Oliver Steffen <osteffen@redhat.com>

# Everything here is editable! You can modify the patch name, author,
# date, commit message, and the diff (if --diff was given).
# Lines starting with '#' will be ignored, and an empty message
# aborts the edit.

Laszlo Ersek (3):
  ArmPlatformPkg: introduce fixed PCD for early hello message
  ArmPlatformPkg: PrePeiCore: write early hello message to the serial
    port
  ArmVirtPkg: set early hello message

 ArmPlatformPkg/ArmPlatformPkg.dec               | 7 +++++++
 ArmVirtPkg/ArmVirtQemu.dsc                      | 1 +
 ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf  | 2 ++
 ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 2 ++
 ArmPlatformPkg/PrePeiCore/PrePeiCore.h          | 1 +
 ArmPlatformPkg/PrePeiCore/MainMPCore.c          | 5 +++++
 ArmPlatformPkg/PrePeiCore/MainUniCore.c         | 5 +++++
 7 files changed, 23 insertions(+)

-- 
2.37.1


             reply	other threads:[~2022-07-26  7:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-26  7:28 Oliver Steffen [this message]
2022-07-26  7:28 ` [PATCH 1/3] ArmPlatformPkg: introduce fixed PCD for early hello message Oliver Steffen
2022-07-26  7:28 ` [PATCH 2/3] ArmPlatformPkg: PrePeiCore: write early hello message to the serial port Oliver Steffen
2022-07-26 10:42   ` Sami Mujawar
2022-07-26 15:50     ` Oliver Steffen
2022-07-26 16:22       ` Sami Mujawar
2022-07-28  9:53         ` Oliver Steffen
2022-08-04 13:20           ` [edk2-devel] " Ard Biesheuvel
2022-07-26  7:28 ` [PATCH 3/3] ArmVirtPkg: set early hello message Oliver Steffen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220726072848.640026-1-osteffen@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox