public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Oliver Steffen" <osteffen@redhat.com>
To: devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Chasel Chiu <chasel.chiu@intel.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Nate DeSimone <nathaniel.l.desimone@intel.com>,
	Sami Mujawar <sami.mujawar@arm.com>,
	Star Zeng <star.zeng@intel.com>, Andrew Fish <afish@apple.com>,
	Laszlo Ersek <lersek@redhat.com>,
	Oliver Steffen <osteffen@redhat.com>
Subject: [PATCH 1/3] ArmPlatformPkg: introduce fixed PCD for early hello message
Date: Tue, 26 Jul 2022 09:28:46 +0200	[thread overview]
Message-ID: <20220726072848.640026-2-osteffen@redhat.com> (raw)
In-Reply-To: <20220726072848.640026-1-osteffen@redhat.com>

From: Laszlo Ersek <lersek@redhat.com>

Add a PCD for defining a hello message that gets printed to the serial port
very early in the boot process, regardless of debug masks. This is useful
for debugging boot problems (especially in virtual machines) and informs
interactive users that the firmware is running.

If a platform doesn't want this feature, it should stick with the default
empty string.

Singed-off-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Oliver Steffen <osteffen@redhat.com>
---
 ArmPlatformPkg/ArmPlatformPkg.dec | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec
index dd6e78f62aa1..ac726417cbe7 100644
--- a/ArmPlatformPkg/ArmPlatformPkg.dec
+++ b/ArmPlatformPkg/ArmPlatformPkg.dec
@@ -122,6 +122,13 @@ [PcdsFixedAtBuild.common]
   ## If set, this will swap settings for HDLCD RED_SELECT and BLUE_SELECT registers
   gArmPlatformTokenSpaceGuid.PcdArmHdLcdSwapBlueRedSelect|FALSE|BOOLEAN|0x00000045
 
+  #
+  # Early hello message (ASCII string), printed to the serial port.
+  # If set to the empty string, nothing is printed.
+  # Otherwise, a trailing CRLF should be specified explicitly.
+  #
+  gArmPlatformTokenSpaceGuid.PcdEarlyHelloMessage|""|VOID*|0x00000100
+
 [PcdsFixedAtBuild.common,PcdsDynamic.common]
   ## PL031 RealTimeClock
   gArmPlatformTokenSpaceGuid.PcdPL031RtcBase|0x0|UINT32|0x00000024
-- 
2.37.1


  reply	other threads:[~2022-07-26  7:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-26  7:28 [PATCH 0/3] ArmPlatformPkg, ArmVirtPkg: Add early hello message Oliver Steffen
2022-07-26  7:28 ` Oliver Steffen [this message]
2022-07-26  7:28 ` [PATCH 2/3] ArmPlatformPkg: PrePeiCore: write early hello message to the serial port Oliver Steffen
2022-07-26 10:42   ` Sami Mujawar
2022-07-26 15:50     ` Oliver Steffen
2022-07-26 16:22       ` Sami Mujawar
2022-07-28  9:53         ` Oliver Steffen
2022-08-04 13:20           ` [edk2-devel] " Ard Biesheuvel
2022-07-26  7:28 ` [PATCH 3/3] ArmVirtPkg: set early hello message Oliver Steffen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220726072848.640026-2-osteffen@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox