From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web09.14922.1658885899203891583 for ; Tue, 26 Jul 2022 18:38:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=ftWlq7rP; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=0207a15765=nickle.wang@hpe.com) Received: from pps.filterd (m0148664.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26R0q5Uu030585; Wed, 27 Jul 2022 01:38:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pps0720; bh=DST+HqIARIo06V4KuaP4idkkrBjK7nBTtLHzKhewz9c=; b=ftWlq7rPb23uh3sa+q4HmSVMyqD8buKvprYx4/Cs4AaKvHUU1p8USl3gdIftjxUlb9Vz /ImWOmra2SXMEPvDY/x9aaQaDPfNs6C/nlfcw2049w9Qbee9LwZnsxMtpZg7/q5kNy5u ZIK6YoS1n68YHXjZVJf85kGNDhBF0sA3eNCzfE09HqFOEDB12oHDpInEF7da3Imqpa+l IzjcbYJzRrsZ9HGbbzaQEdk7mvnr5UhSYT1bx9syN1ndYqJxmCvBf64et1SN1ivZPp3X o7TVCXwNKB8dMkSqHqm9VPKvsNCE7g1vEATfqFBUdvo97PRBD5+nyTWmav+ucJJV0MJN /Q== Received: from p1lg14878.it.hpe.com (p1lg14878.it.hpe.com [16.230.97.204]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 3hjew9xsr7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Jul 2022 01:38:16 +0000 Received: from p1lg14885.dc01.its.hpecorp.net (unknown [10.119.18.236]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by p1lg14878.it.hpe.com (Postfix) with ESMTPS id BE29DD2C5; Wed, 27 Jul 2022 01:38:15 +0000 (UTC) Received: from WAFM3XJD5N.asiapacific.hpqcorp.net (unknown [16.231.227.36]) by p1lg14885.dc01.its.hpecorp.net (Postfix) with ESMTP id 7DE6A8052CC; Wed, 27 Jul 2022 01:38:14 +0000 (UTC) From: "Nickle Wang" To: devel@edk2.groups.io Cc: Abner Chang , Yang Atom , Nick Ramirez Subject: [edk2-staging][PATCH v3 07/15] edk2-staging/RedfishClientPkg: Update ETag driver Date: Wed, 27 Jul 2022 09:37:54 +0800 Message-Id: <20220727013802.247-8-nickle.wang@hpe.com> X-Mailer: git-send-email 2.32.0.windows.2 In-Reply-To: <20220727013802.247-1-nickle.wang@hpe.com> References: <20220727013802.247-1-nickle.wang@hpe.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: us3gKK6_xSkw9idYKijeNbfV9uZF-8EJ X-Proofpoint-GUID: us3gKK6_xSkw9idYKijeNbfV9uZF-8EJ X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-26_07,2022-07-26_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 mlxlogscore=757 phishscore=0 adultscore=0 lowpriorityscore=0 mlxscore=0 suspectscore=0 bulkscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207270002 Content-Transfer-Encoding: 8bit Update ETag driver and use specific variable GUID. Also fix the typo in comment. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- RedfishClientPkg/RedfishClientPkg.dec | 2 +- RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c | 10 +++++----- RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.h | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/RedfishClientPkg/RedfishClientPkg.dec b/RedfishClientPkg/RedfishClientPkg.dec index 7bdab5be0c..67929341df 100644 --- a/RedfishClientPkg/RedfishClientPkg.dec +++ b/RedfishClientPkg/RedfishClientPkg.dec @@ -36,7 +36,7 @@ gEdkIIRedfishFeatureProtocolGuid = { 0x785CC694, 0x4930, 0xEFBF, { 0x2A, 0xCB, 0xA4, 0xB6, 0xA1, 0xCC, 0xAA, 0x34 } } ## Include/Protocol/EdkIIRedfishResourceConfigProtocol.h gEdkIIRedfishResourceConfigProtocolGuid = { 0x6f164c68, 0xfb09, 0x4646, { 0xa8, 0xd3, 0x24, 0x11, 0x5d, 0xab, 0x3e, 0xe7 } } - ## Include/Protocol/EdkiiRedfishETagProtocol.h + ## Include/Protocol/EdkIIRedfishETagProtocol.h gEdkIIRedfishETagProtocolGuid = { 0x5706d368, 0xaf66, 0x48f5, { 0x89, 0xfc, 0xa6, 0x61, 0xce, 0xb5, 0xa6, 0xa9 } } ## Include/Protocol/EdkIIRedfishConfigLangMapProtocol.h gEdkIIRedfishConfigLangMapProtocolGuid = { 0x1d9ba9fe, 0x5d5a, 0x4b66, {0x83, 0x5b, 0xe2, 0x5d, 0x13, 0x93, 0x4a, 0x9c } } diff --git a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c index 73d3a8c39a..52015672f9 100644 --- a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c +++ b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c @@ -1,6 +1,6 @@ /** @file - (C) Copyright 2021 Hewlett Packard Enterprise Development LP
+ (C) Copyright 2021-2022 Hewlett Packard Enterprise Development LP
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -398,17 +398,17 @@ SaveETagList ( // Status = GetVariable2 ( VariableName, - &gEfiCallerIdGuid, + &mRedfishVariableGuid, (VOID *)&Data, NULL ); if (!EFI_ERROR (Status)) { FreePool (Data); - gRT->SetVariable (VariableName, &gEfiCallerIdGuid, VARIABLE_ATTRIBUTE_NV_BS, 0, NULL); + gRT->SetVariable (VariableName, &mRedfishVariableGuid, VARIABLE_ATTRIBUTE_NV_BS, 0, NULL); } - return gRT->SetVariable (VariableName, &gEfiCallerIdGuid, VARIABLE_ATTRIBUTE_NV_BS, VarSize, (VOID *)VarData); + return gRT->SetVariable (VariableName, &mRedfishVariableGuid, VARIABLE_ATTRIBUTE_NV_BS, VarSize, (VOID *)VarData); } /** @@ -444,7 +444,7 @@ InitialETagList ( // Status = GetVariable2 ( VariableName, - &gEfiCallerIdGuid, + &mRedfishVariableGuid, (VOID *)&VarData, &VariableSize ); diff --git a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.h b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.h index 58925b4a51..3deab377dc 100644 --- a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.h +++ b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.h @@ -1,7 +1,7 @@ /** @file Common header file for RedfishETagDxe driver. - (C) Copyright 2021 Hewlett Packard Enterprise Development LP
+ (C) Copyright 2021-2022 Hewlett Packard Enterprise Development LP
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -11,6 +11,7 @@ #define REDFISH_ETAG_DXE_H_ #include +#include // // Libraries @@ -30,7 +31,6 @@ #include #define ETAG_VARIABLE_NAME L"RedfishETag" -#define IS_EMPTY_STRING(a) ((a) == NULL || (a)[0] == '\0') #define ETAG_DEBUG_ENABLED 0x00 // -- 2.32.0.windows.2