From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.3847.1659063455931091447 for ; Thu, 28 Jul 2022 19:57:36 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=gEsTV6wN; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: chasel.chiu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659063455; x=1690599455; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=goISyo3x/kJd3B7sacZY9/HYGhqT5Z1VggKzoBrzxVs=; b=gEsTV6wNLvPCe5VjC6tUm0elpQ/Lg81knKFEBIfQJ64Dr3NIFxsJS+jz zrmZ6HWRMZ72fPfyT7POlVMS29V3BZyeC/wgkOIvp3ex+57BQgqwgLRTL /XMZB6/7uk9Mz5QhggRPHIOZFnnFj9bcOb95Tn48LXGLbT1f9Snys+wA0 0iho2/zkQKtL11liu51jRp/luwHQmxJtlsk46o2WCwItmESuq2/DP7Hw3 IvZTyoFSS5RlHLn9KZY5zvAdw0QA6RJkBbAkDQoK8dzIrRh77jjRu9yG6 W+kF5kEodPy7YpHpcRUp2ALhUP+t16wRvmCpSwxRr5rPwro7rwuXvxbUf w==; X-IronPort-AV: E=McAfee;i="6400,9594,10422"; a="350381176" X-IronPort-AV: E=Sophos;i="5.93,200,1654585200"; d="scan'208";a="350381176" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2022 19:57:35 -0700 X-IronPort-AV: E=Sophos;i="5.93,200,1654585200"; d="scan'208";a="601138185" Received: from cchiu4-mobl.gar.corp.intel.com ([10.212.196.229]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2022 19:57:35 -0700 From: "Chiu, Chasel" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Star Zeng Subject: [PATCH] IntelFsp2Pkg: Fix GenCfgOpt bug for FSPI_UPD support. Date: Thu, 28 Jul 2022 19:57:24 -0700 Message-Id: <20220729025724.2040-1-chasel.chiu@intel.com> X-Mailer: git-send-email 2.35.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3993 Fixed a logic bug in GenCfgOpt.py to skip FSPI_UPD when platforms do not support. Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu --- IntelFsp2Pkg/Tools/GenCfgOpt.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/IntelFsp2Pkg/Tools/GenCfgOpt.py b/IntelFsp2Pkg/Tools/GenCfgOpt= .py index 71c48f10e0..13be81ddbc 100644 --- a/IntelFsp2Pkg/Tools/GenCfgOpt.py +++ b/IntelFsp2Pkg/Tools/GenCfgOpt.py @@ -1301,7 +1301,7 @@ EndList elif '_S' in SignatureStr[6:6+2]:=0D TxtBody.append("#define FSPS_UPD_SIGNATURE = %s /* '%s' */\n\n" % (Item['value'], SignatureStr))=0D elif '_I' in SignatureStr[6:6+2]:=0D - if NoFSPI =3D=3D True:=0D + if NoFSPI =3D=3D False:=0D TxtBody.append("#define FSPI_UPD_SIGNATURE = %s /* '%s' */\n\n" % (Item['value'], SignatureStr))=0D TxtBody.append("\n")=0D =0D --=20 2.35.0.windows.1