[PATCH] [PATCH]MdeModulePkg/Ufs: Coverity scan flags multiple issues in edk2-stable202205 Signed-off-by: sivaparvathic@ami.com

[PATCH] [PATCH]MdeModulePkg/Ufs: Coverity scan flags multiple issues in edk2-stable202205 Signed-off-by: sivaparvathic@ami.com

[sivaparvathi C]

---
 MdeModulePkg/Bus/Ufs/UfsBlockIoPei/DmaMem.c   | 18 ++++++++++++------
 MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c |  3 +++
 2 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/DmaMem.c b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/DmaMem.c
index 62aeaf86c8..b4b0f07d5e 100644
--- a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/DmaMem.c
+++ b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/DmaMem.c
@@ -240,10 +240,16 @@ IoMmuInit (
   VOID

   )

 {

-  PeiServicesLocatePpi (

-    &gEdkiiIoMmuPpiGuid,

-    0,

-    NULL,

-    (VOID **)&mIoMmu

-    );

+    EFI_STATUS                Status;

+

+    Status =   PeiServicesLocatePpi (

+                    &gEdkiiIoMmuPpiGuid,

+                    0,

+                    NULL,

+                    (VOID **)&mIoMmu

+                    );

+

+    if (EFI_ERROR(Status)) {

+        DEBUG ((DEBUG_INFO, "Locate mIoMmu Ppi is failed!!!\n"));

+    }

 }

diff --git a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c
index b7dd9b6acd..b5f0324908 100644
--- a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c
+++ b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c
@@ -414,6 +414,9 @@ UfsPeimFreeMem (
   //

   ASSERT (Block != NULL);



+  if (Block == NULL) {

+      return;

+  }

   //

   // Release the current memory block if it is empty and not the head

   //

--
2.31.0.windows.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

Re: [edk2-devel] [PATCH] [PATCH]MdeModulePkg/Ufs: Coverity scan flags multiple issues in edk2-stable202205 Signed-off-by: sivaparvathic@ami.com

[sivaparvathi C]

[-- Attachment #1: Type: text/plain, Size: 99 bytes --]

Hi gaoliming@byosoft.com.cn ,

Could you please review the changes ?

Thanks,
Sivaparvathi C

[-- Attachment #2: Type: text/html, Size: 149 bytes --]

回复: [edk2-devel] [PATCH] [PATCH]MdeModulePkg/Ufs: Coverity scan flags multiple issues in edk2-stable202205 Signed-off-by: sivaparvathic@ami.com

[gaoliming]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 sivaparvathi
> C via groups.io
> 发送时间: 2022年8月2日 12:02
> 收件人: devel@edk2.groups.io; Sivaparvathi Chellaiah
> <sivaparvathic@ami.com>
> 抄送: Vasudevan Sambandan <vasudevans@ami.com>; Sundaresan S
> <sundaresans@ami.com>
> 主题: [edk2-devel] [PATCH] [PATCH]MdeModulePkg/Ufs: Coverity scan flags
> multiple issues in edk2-stable202205 Signed-off-by: sivaparvathic@ami.com
> 
> ---
>  MdeModulePkg/Bus/Ufs/UfsBlockIoPei/DmaMem.c   | 18
> ++++++++++++------
>  MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c |  3 +++
>  2 files changed, 15 insertions(+), 6 deletions(-)
> 
> diff --git a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/DmaMem.c
> b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/DmaMem.c
> index 62aeaf86c8..b4b0f07d5e 100644
> --- a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/DmaMem.c
> +++ b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/DmaMem.c
> @@ -240,10 +240,16 @@ IoMmuInit (
>    VOID
> 
>    )
> 
>  {
> 
> -  PeiServicesLocatePpi (
> 
> -    &gEdkiiIoMmuPpiGuid,
> 
> -    0,
> 
> -    NULL,
> 
> -    (VOID **)&mIoMmu
> 
> -    );
> 
> +    EFI_STATUS                Status;
> 
> +
> 
> +    Status =   PeiServicesLocatePpi (
> 
> +                    &gEdkiiIoMmuPpiGuid,
> 
> +                    0,
> 
> +                    NULL,
> 
> +                    (VOID **)&mIoMmu
> 
> +                    );
> 
> +
> 
> +    if (EFI_ERROR(Status)) {
> 
> +        DEBUG ((DEBUG_INFO, "Locate mIoMmu Ppi is failed!!!\n"));
> 
> +    }
> 
>  }
> 
> diff --git a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c
> b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c
> index b7dd9b6acd..b5f0324908 100644
> --- a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c
> +++ b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c
> @@ -414,6 +414,9 @@ UfsPeimFreeMem (
>    //
> 
>    ASSERT (Block != NULL);
> 
> 
> 
> +  if (Block == NULL) {
> 
> +      return;
> 
> +  }
> 
>    //
> 
>    // Release the current memory block if it is empty and not the head
> 
>    //
> 
> --
> 2.31.0.windows.1
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient, you
are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission.
> 
> 
> 
> 

Re: [edk2-devel] 回复: [edk2-devel] [PATCH] [PATCH]MdeModulePkg/Ufs: Coverity scan flags multiple issues in edk2-stable202205 Signed-off-by: sivaparvathic@ami.com

[sivaparvathi C]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

On Tue, Sep 13, 2022 at 10:44 AM, gaoliming wrote:

> 
> gaoliming

Hi GaoLiming,

Could you please review the changes?

Thanks,
Sivaparvathi

[-- Attachment #2: Type: text/html, Size: 200 bytes --]

回复: [edk2-devel] 回复: [edk2-devel] [PATCH] [PATCH]MdeModulePkg/Ufs: Coverity scan flags multiple issues in edk2-stable202205 Signed-off-by: sivaparvathic@ami.com

[gaoliming]

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

I have gave my reviewed-by https://edk2.groups.io/g/devel/message/93694. 

 

But, I can’t get this patch from the mail. Can you share this patch in Pull Request or your fork GitHub Edk2 repo branch?

 

Thanks

Liming

发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 sivaparvathi C via groups.io
发送时间: 2022年10月6日 16:17
收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
主题: Re: [edk2-devel] 回复: [edk2-devel] [PATCH] [PATCH]MdeModulePkg/Ufs: Coverity scan flags multiple issues in edk2-stable202205 Signed-off-by: sivaparvathic@ami.com

 

On Tue, Sep 13, 2022 at 10:44 AM, gaoliming wrote:

gaoliming

Hi GaoLiming,

Could you please review the changes?

Thanks,
Sivaparvathi  




[-- Attachment #2: Type: text/html, Size: 4542 bytes --]

Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [PATCH] [PATCH]MdeModulePkg/Ufs: Coverity scan flags multiple issues in edk2-stable202205 Signed-off-by: sivaparvathic@ami.com

[sivaparvathi C]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

Hi mikuback@linux.microsoft.com , gaoliming@byosoft.com.cn , michael.d.kinney@intel.com

Created PULL request for edk2_stable202205 coverity issue changes for Ufs driver.
https://github.com/tianocore/edk2/pull/3472

Thanks,
Sivaparvathi C

[-- Attachment #2: Type: text/html, Size: 1493 bytes --]

回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [PATCH] [PATCH]MdeModulePkg/Ufs: Coverity scan flags multiple issues in edk2-stable202205 Signed-off-by: sivaparvathic@ami.com

[gaoliming]

[-- Attachment #1: Type: text/plain, Size: 933 bytes --]

Sivaparvathi:

 You can check this wiki https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-Formatting to know how to check edk2 CI failures. 

 

Thanks

Liming

发件人: sivaparvathic via groups.io <sivaparvathic=ami.com@groups.io> 
发送时间: 2022年10月13日 19:18
收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
主题: Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [PATCH] [PATCH]MdeModulePkg/Ufs: Coverity scan flags multiple issues in edk2-stable202205 Signed-off-by: sivaparvathic@ami.com

 

Hi  <mailto:mikuback@linux.microsoft.com> mikuback@linux.microsoft.com,  <mailto:gaoliming@byosoft.com.cn> gaoliming@byosoft.com.cn, <mailto:michael.d.kinney@intel.com> michael.d.kinney@intel.com


Created PULL request for edk2_stable202205 coverity issue changes for Ufs driver.
https://github.com/tianocore/edk2/pull/3472

Thanks,
Sivaparvathi C 


[-- Attachment #2: Type: text/html, Size: 4688 bytes --]

Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [PATCH] [PATCH]MdeModulePkg/Ufs: Coverity scan flags multiple issues in edk2-stable202205 Signed-off-by: sivaparvathic@ami.com

[sivaparvathi C]

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

Hi mikuback@linux.microsoft.com, gaoliming@byosoft.com.cn,michael.d.kinney@intel.com, vasudevans@ami.com, sundaresans@ami.com

Created PULL request for Coverity Issue changes.

UFS PR: https://github.com/tianocore/edk2/pull/3552
BugZilla ID: https://bugzilla.tianocore.org/show_bug.cgi?id=3989 ( https://bugzilla.tianocore.org/show_bug.cgi?id=3994 )

All Checks are Passed.

Thanks,
Sivaparvathi C

[-- Attachment #2: Type: text/html, Size: 989 bytes --]

回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [PATCH] [PATCH]MdeModulePkg/Ufs: Coverity scan flags multiple issues in edk2-stable202205 Signed-off-by: sivaparvathic@ami.com

[gaoliming]

[-- Attachment #1: Type: text/plain, Size: 1182 bytes --]

Sivaparvathi:

 Thanks for your update. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

 I will merge this patch if no other comments. 

 

Thanks

Liming

发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 sivaparvathi C via groups.io
发送时间: 2022年10月28日 16:04
收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
主题: Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [PATCH] [PATCH]MdeModulePkg/Ufs: Coverity scan flags multiple issues in edk2-stable202205 Signed-off-by: sivaparvathic@ami.com

 

Hi mikuback@linux.microsoft.com <mailto:mikuback@linux.microsoft.com> , gaoliming@byosoft.com.cn,michael.d.kinney@intel.com, <mailto:gaoliming@byosoft.com.cn,michael.d.kinney@intel.com,>  vasudevans@ami.com, <mailto:vasudevans@ami.com,>  sundaresans@ami.com <mailto:sundaresans@ami.com> 

 

Created PULL request for Coverity Issue changes.

UFS PR: https://github.com/tianocore/edk2/pull/3552 

BugZilla ID: https://bugzilla.tianocore.org/show_bug.cgi?id=3989 <https://bugzilla.tianocore.org/show_bug.cgi?id=3994>  

All Checks are Passed.

Thanks,
Sivaparvathi C




[-- Attachment #2: Type: text/html, Size: 5080 bytes --]