public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "sivaparvathi C" <sivaparvathic@ami.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	Sivaparvathi Chellaiah <sivaparvathic@ami.com>
Cc: Vasudevan Sambandan <vasudevans@ami.com>,
	Sundaresan S <sundaresans@ami.com>
Subject: [PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line
Date: Tue, 2 Aug 2022 06:36:30 +0000	[thread overview]
Message-ID: <20220802063609.1183-1-sivaparvathic@ami.com> (raw)

     Added changes to clear the redundant symbol after using Hexedit cmd in
shell screen page.

      During ClearScreen(),first screen was cleared and cursor was set to
    new position(0,0) ,but the visible state of cursor is always 1. in
    setcursorposition(),cursor was disabled during that time,old cursor
    data is drawn to screen.

 Signed-off-by: sivaparvathic@ami.com
---
 .../Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c    | 2 ++
 .../Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c  | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c
index 58beaaf9c5..58df2e022b 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c
@@ -1627,6 +1627,7 @@ MainEditorCleanup (
     ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_EDIT_LIBEDITOR_FILEBUFFER_CLEANUP), gShellDebug1HiiHandle);

   }



+  gST->ConOut->EnableCursor (gST->ConOut, FALSE);

   //

   // restore old mode

   //

@@ -1644,6 +1645,7 @@ MainEditorCleanup (


   gST->ConOut->ClearScreen (gST->ConOut);



+  gST->ConOut->EnableCursor (gST->ConOut, TRUE);

   return EFI_SUCCESS;

 }



diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c
index 0eb917acf7..8b3d5225db 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c
@@ -1833,6 +1833,7 @@ HMainEditorCleanup (
     ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_HEXEDIT_LIBEDITOR_CLIPBOARD_CLEAN), gShellDebug1HiiHandle);

   }



+  gST->ConOut->EnableCursor (gST->ConOut, FALSE);

   //

   // restore old mode

   //

@@ -1845,6 +1846,7 @@ HMainEditorCleanup (
                  EFI_TEXT_ATTR (HOriginalColors.Foreground, HOriginalColors.Background)

                  );

   gST->ConOut->ClearScreen (gST->ConOut);

+  gST->ConOut->EnableCursor (gST->ConOut, TRUE);



   return EFI_SUCCESS;

 }

--
2.31.0.windows.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

             reply	other threads:[~2022-08-02  6:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-02  6:36 sivaparvathi C [this message]
2022-09-12  9:12 ` [edk2-devel] [PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line sivaparvathi C
2022-09-13  6:52   ` 回复: " gaoliming
2022-09-15  4:45     ` sivaparvathi C
2022-09-21  1:47       ` 回复: " gaoliming
2022-10-06  8:14       ` [edk2-devel] " sivaparvathi C

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220802063609.1183-1-sivaparvathic@ami.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox