public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line
@ 2022-08-02  6:36 sivaparvathi C
  2022-09-12  9:12 ` [edk2-devel] " sivaparvathi C
  0 siblings, 1 reply; 6+ messages in thread
From: sivaparvathi C @ 2022-08-02  6:36 UTC (permalink / raw)
  To: devel@edk2.groups.io, Sivaparvathi Chellaiah
  Cc: Vasudevan Sambandan, Sundaresan S

     Added changes to clear the redundant symbol after using Hexedit cmd in
shell screen page.

      During ClearScreen(),first screen was cleared and cursor was set to
    new position(0,0) ,but the visible state of cursor is always 1. in
    setcursorposition(),cursor was disabled during that time,old cursor
    data is drawn to screen.

 Signed-off-by: sivaparvathic@ami.com
---
 .../Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c    | 2 ++
 .../Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c  | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c
index 58beaaf9c5..58df2e022b 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c
@@ -1627,6 +1627,7 @@ MainEditorCleanup (
     ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_EDIT_LIBEDITOR_FILEBUFFER_CLEANUP), gShellDebug1HiiHandle);

   }



+  gST->ConOut->EnableCursor (gST->ConOut, FALSE);

   //

   // restore old mode

   //

@@ -1644,6 +1645,7 @@ MainEditorCleanup (


   gST->ConOut->ClearScreen (gST->ConOut);



+  gST->ConOut->EnableCursor (gST->ConOut, TRUE);

   return EFI_SUCCESS;

 }



diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c
index 0eb917acf7..8b3d5225db 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c
@@ -1833,6 +1833,7 @@ HMainEditorCleanup (
     ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_HEXEDIT_LIBEDITOR_CLIPBOARD_CLEAN), gShellDebug1HiiHandle);

   }



+  gST->ConOut->EnableCursor (gST->ConOut, FALSE);

   //

   // restore old mode

   //

@@ -1845,6 +1846,7 @@ HMainEditorCleanup (
                  EFI_TEXT_ATTR (HOriginalColors.Foreground, HOriginalColors.Background)

                  );

   gST->ConOut->ClearScreen (gST->ConOut);

+  gST->ConOut->EnableCursor (gST->ConOut, TRUE);



   return EFI_SUCCESS;

 }

--
2.31.0.windows.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-10-06  8:14 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-02  6:36 [PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line sivaparvathi C
2022-09-12  9:12 ` [edk2-devel] " sivaparvathi C
2022-09-13  6:52   ` 回复: " gaoliming
2022-09-15  4:45     ` sivaparvathi C
2022-09-21  1:47       ` 回复: " gaoliming
2022-10-06  8:14       ` [edk2-devel] " sivaparvathi C

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox