From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.9519.1659463487615594545 for ; Tue, 02 Aug 2022 11:04:47 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=Ef52ZT4p; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id E7F1B20FF4EF; Tue, 2 Aug 2022 11:04:46 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com E7F1B20FF4EF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1659463487; bh=/YBThUMWB2/pWnEOorOSCQtHaMTi0JRlnshhpSG35c8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ef52ZT4ptWD3aoq/IoroYc++XO0wR3TS/2lXO6husbqRzy4VqRtHSFiGfKCy6VsyD m8zxdgrKiUhxZVXZgbYCr9QMnV5FFz01TYISEnbTC3GHGjnFYbWVoKRzLlvCfAq83g Q7WlUGMrgwfnJnroQrFi1ZPICKDWNBGzINNr/a5k= From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel Subject: [PATCH v1 1/5] ArmPlatformPkg/NorFlashDxe: Remove unused debug print specifier Date: Tue, 2 Aug 2022 14:04:14 -0400 Message-Id: <20220802180418.880-2-mikuback@linux.microsoft.com> X-Mailer: git-send-email 2.28.0.windows.1 In-Reply-To: <20220802180418.880-1-mikuback@linux.microsoft.com> References: <20220802180418.880-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Kubacki These debug messages are repeated in both NorFlashBlockIoReadBlocks() and NorFlashBlockIoWriteBlocks(): "NorFlashBlockIoWriteBlocks(MediaId=3D0x%x, Lba=3D%ld, BufferSize=3D0x%= x" "bytes (%d kB), BufferPtr @ 0x%08x)\n" Although this requires 5 arguments, only 4 are provided. The kilobyte value was never given. This change removes that specifier so the 4 arguments match the 4 specifiers in the debug macro. Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Michael Kubacki --- ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c b/Ar= mPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c index 5afab0a79fa2..e671108e2bcf 100644 --- a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c +++ b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c @@ -54,7 +54,7 @@ NorFlashBlockIoReadBlocks ( Instance =3D INSTANCE_FROM_BLKIO_THIS (This); Media =3D This->Media; =20 - DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoReadBlocks(MediaId=3D0x%x, Lba=3D= %ld, BufferSize=3D0x%x bytes (%d kB), BufferPtr @ 0x%08x)\n", MediaId, Lb= a, BufferSizeInBytes, Buffer)); + DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoReadBlocks(MediaId=3D0x%x, Lba=3D= %ld, BufferSize=3D0x%x bytes, BufferPtr @ 0x%08x)\n", MediaId, Lba, Buffe= rSizeInBytes, Buffer)); =20 if (!Media) { Status =3D EFI_INVALID_PARAMETER; @@ -89,7 +89,7 @@ NorFlashBlockIoWriteBlocks ( =20 Instance =3D INSTANCE_FROM_BLKIO_THIS (This); =20 - DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoWriteBlocks(MediaId=3D0x%x, Lba=3D= %ld, BufferSize=3D0x%x bytes (%d kB), BufferPtr @ 0x%08x)\n", MediaId, Lb= a, BufferSizeInBytes, Buffer)); + DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoWriteBlocks(MediaId=3D0x%x, Lba=3D= %ld, BufferSize=3D0x%x bytes, BufferPtr @ 0x%08x)\n", MediaId, Lba, Buffe= rSizeInBytes, Buffer)); =20 if ( !This->Media->MediaPresent ) { Status =3D EFI_NO_MEDIA; --=20 2.28.0.windows.1