public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-platforms][PATCH v3 0/6] Resolving SecureBootVariableLib dependency
@ 2022-08-02 22:59 Kun Qin
  2022-08-02 22:59 ` [edk2-platforms][PATCH v3 1/6] RaspberryPi: Pipeline: Resolving newly introduced dependency Kun Qin
                   ` (6 more replies)
  0 siblings, 7 replies; 9+ messages in thread
From: Kun Qin @ 2022-08-02 22:59 UTC (permalink / raw)
  To: devel
  Cc: Ard Biesheuvel, Leif Lindholm, Graeme Gregory, Radoslaw Biernacki,
	Masami Hiramatsu, Nhi Pham, Vu Nguyen, Thang Nguyen, Chuong Tran,
	Thomas Abraham, Sami Mujawar, Abner Chang, Gilbert Chen,
	Daniel Schaefer, Jeremy Linton, Peng Xie, Ling Jia, Yiqi Shu

This v2 series is a follow up of previously submitted patches:
https://edk2.groups.io/g/devel/message/91669

The main update in v3 patches are:
- Updated a commit message to include Review-by tag
- Dumped a commit for Qemu platform as it was fixed by others

Patch v3 branch:https://github.com/kuqin12/edk2-platforms/tree/fix_sb_dep_v3

Cc: Ard Biesheuvel<ardb+tianocore@kernel.org>
Cc: Leif Lindholm<quic_llindhol@quicinc.com>
Cc: Graeme Gregory<graeme@nuviainc.com>
Cc: Radoslaw Biernacki<rad@semihalf.com>
Cc: Masami Hiramatsu<masami.hiramatsu@linaro.org>
Cc: Nhi Pham<nhi@os.amperecomputing.com>
Cc: Vu Nguyen<vunguyen@os.amperecomputing.com>
Cc: Thang Nguyen<thang@os.amperecomputing.com>
Cc: Chuong Tran<chuong@os.amperecomputing.com>
Cc: Thomas Abraham<thomas.abraham@arm.com>
Cc: Sami Mujawar<sami.mujawar@arm.com>
Cc: Abner Chang<abner.chang@hpe.com>
Cc: Gilbert Chen<gilbert.chen@hpe.com>
Cc: Daniel Schaefer<daniel.schaefer@hpe.com>
Cc: Jeremy Linton<jeremy.linton@arm.com>
Cc: Peng Xie<xiepeng@phytium.com.cn>
Cc: Ling Jia<jialing@phytium.com.cn>
Cc: Yiqi Shu<shuyiqi@phytium.com.cn>

Kun Qin (6):
  RaspberryPi: Pipeline: Resolving newly introduced dependency
  U5SeriesPkg: Pipeline: Resolving newly introduced dependency
  VExpressPkg: Pipeline: Resolving newly introduced dependency
  Socionext: Pipeline: Resolving newly introduced dependency
  AmpereAltraPkg: Pipeline: Resolving newly introduced dependency
  PhytiumCommonPkg: Pipeline: Resolving newly introduced dependency

 Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc                         | 1 +
 Platform/RaspberryPi/RPi3/RPi3.dsc                                   | 1 +
 Platform/RaspberryPi/RPi4/RPi4.dsc                                   | 1 +
 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc           | 1 +
 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 +
 Platform/Socionext/DeveloperBox/DeveloperBox.dsc                     | 1 +
 Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc                 | 1 +
 Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc            | 1 +
 8 files changed, 8 insertions(+)

-- 
2.37.1.windows.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [edk2-platforms][PATCH v3 1/6] RaspberryPi: Pipeline: Resolving newly introduced dependency
  2022-08-02 22:59 [edk2-platforms][PATCH v3 0/6] Resolving SecureBootVariableLib dependency Kun Qin
@ 2022-08-02 22:59 ` Kun Qin
  2022-08-02 22:59 ` [edk2-platforms][PATCH v3 2/6] U5SeriesPkg: " Kun Qin
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: Kun Qin @ 2022-08-02 22:59 UTC (permalink / raw)
  To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Jeremy Linton

The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
RaspberryPi platforms build.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Jeremy Linton <jeremy.linton@arm.com>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>
---

Notes:
    v2:
    - Add reviewed-by tag [Jeremy]

 Platform/RaspberryPi/RPi3/RPi3.dsc | 1 +
 Platform/RaspberryPi/RPi4/RPi4.dsc | 1 +
 2 files changed, 2 insertions(+)

diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
index 0eed03c097f8..4e7377a00036 100644
--- a/Platform/RaspberryPi/RPi3/RPi3.dsc
+++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
@@ -169,6 +169,7 @@ [LibraryClasses.common]
   PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 !else
   TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
   AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
index eabddd7382cf..8ba0ca61851e 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -166,6 +166,7 @@ [LibraryClasses.common]
   AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 
   # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree
   PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
-- 
2.37.1.windows.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [edk2-platforms][PATCH v3 2/6] U5SeriesPkg: Pipeline: Resolving newly introduced dependency
  2022-08-02 22:59 [edk2-platforms][PATCH v3 0/6] Resolving SecureBootVariableLib dependency Kun Qin
  2022-08-02 22:59 ` [edk2-platforms][PATCH v3 1/6] RaspberryPi: Pipeline: Resolving newly introduced dependency Kun Qin
@ 2022-08-02 22:59 ` Kun Qin
  2022-08-02 22:59 ` [edk2-platforms][PATCH v3 3/6] VExpressPkg: " Kun Qin
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: Kun Qin @ 2022-08-02 22:59 UTC (permalink / raw)
  To: devel; +Cc: Abner Chang, Gilbert Chen, Daniel Schaefer

The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
U5SeriesPkg platforms build.

Cc: Abner Chang <abner.chang@hpe.com>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
---

Notes:
    v2:
    - No review, no change

 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc           | 1 +
 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 +
 2 files changed, 2 insertions(+)

diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
index 7b36b2c885e0..fc1ed012a541 100644
--- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
+++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
@@ -127,6 +127,7 @@ [LibraryClasses]
   AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 !else
   TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
   AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
index 26895a75ec2f..e59955d09452 100644
--- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
+++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
@@ -127,6 +127,7 @@ [LibraryClasses]
   AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 !else
   TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
   AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
-- 
2.37.1.windows.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [edk2-platforms][PATCH v3 3/6] VExpressPkg: Pipeline: Resolving newly introduced dependency
  2022-08-02 22:59 [edk2-platforms][PATCH v3 0/6] Resolving SecureBootVariableLib dependency Kun Qin
  2022-08-02 22:59 ` [edk2-platforms][PATCH v3 1/6] RaspberryPi: Pipeline: Resolving newly introduced dependency Kun Qin
  2022-08-02 22:59 ` [edk2-platforms][PATCH v3 2/6] U5SeriesPkg: " Kun Qin
@ 2022-08-02 22:59 ` Kun Qin
  2022-08-02 22:59 ` [edk2-platforms][PATCH v3 4/6] Socionext: " Kun Qin
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: Kun Qin @ 2022-08-02 22:59 UTC (permalink / raw)
  To: devel; +Cc: Ard Biesheuvel, Thomas Abraham, Sami Mujawar

The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
ArmVExpress platforms build.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Thomas Abraham <thomas.abraham@arm.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
---

Notes:
    v2:
    - Added reviewed-by tag [Sami]

 Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
index e637f8933f79..17e4a3fd13d7 100644
--- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
+++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
@@ -143,6 +143,7 @@ [LibraryClasses.common]
   AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 
   # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree
   PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
-- 
2.37.1.windows.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [edk2-platforms][PATCH v3 4/6] Socionext: Pipeline: Resolving newly introduced dependency
  2022-08-02 22:59 [edk2-platforms][PATCH v3 0/6] Resolving SecureBootVariableLib dependency Kun Qin
                   ` (2 preceding siblings ...)
  2022-08-02 22:59 ` [edk2-platforms][PATCH v3 3/6] VExpressPkg: " Kun Qin
@ 2022-08-02 22:59 ` Kun Qin
  2022-08-02 22:59 ` [edk2-platforms][PATCH v3 5/6] AmpereAltraPkg: " Kun Qin
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: Kun Qin @ 2022-08-02 22:59 UTC (permalink / raw)
  To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Masami Hiramatsu

The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
DeveloperBox platforms build.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Masami Hiramatsu <masami.hiramatsu@linaro.org>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
---

Notes:
    v2:
    - No review, no change.

 Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
index 8419c89318fb..917c1532fb3c 100644
--- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
+++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
@@ -55,6 +55,7 @@ [LibraryClasses]
 !if $(SECURE_BOOT_ENABLE) == TRUE
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 !endif
 
 [LibraryClasses.common.SEC]
-- 
2.37.1.windows.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [edk2-platforms][PATCH v3 5/6] AmpereAltraPkg: Pipeline: Resolving newly introduced dependency
  2022-08-02 22:59 [edk2-platforms][PATCH v3 0/6] Resolving SecureBootVariableLib dependency Kun Qin
                   ` (3 preceding siblings ...)
  2022-08-02 22:59 ` [edk2-platforms][PATCH v3 4/6] Socionext: " Kun Qin
@ 2022-08-02 22:59 ` Kun Qin
  2022-08-02 22:59 ` [edk2-platforms][PATCH v3 6/6] PhytiumCommonPkg: " Kun Qin
  2022-08-04 10:26 ` [edk2-platforms][PATCH v3 0/6] Resolving SecureBootVariableLib dependency Ard Biesheuvel
  6 siblings, 0 replies; 9+ messages in thread
From: Kun Qin @ 2022-08-02 22:59 UTC (permalink / raw)
  To: devel; +Cc: Nhi Pham, Vu Nguyen, Thang Nguyen, Chuong Tran, Leif Lindholm

The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
AmpereAltraPkg platforms build.

Cc: Nhi Pham <nhi@os.amperecomputing.com>
Cc: Vu Nguyen <vunguyen@os.amperecomputing.com>
Cc: Thang Nguyen <thang@os.amperecomputing.com>
Cc: Chuong Tran <chuong@os.amperecomputing.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
Reviewed-by: Nhi Pham <nhi@os.amperecomputing.com>
---

Notes:
    v2:
    - Added reviewed-by tag [Nhi]

 Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
index d4c29c3c338c..1e378e37e2b8 100644
--- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
+++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
@@ -144,6 +144,7 @@ [LibraryClasses.common]
   BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 
   #
   # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree
-- 
2.37.1.windows.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [edk2-platforms][PATCH v3 6/6] PhytiumCommonPkg: Pipeline: Resolving newly introduced dependency
  2022-08-02 22:59 [edk2-platforms][PATCH v3 0/6] Resolving SecureBootVariableLib dependency Kun Qin
                   ` (4 preceding siblings ...)
  2022-08-02 22:59 ` [edk2-platforms][PATCH v3 5/6] AmpereAltraPkg: " Kun Qin
@ 2022-08-02 22:59 ` Kun Qin
  2022-08-04 10:26 ` [edk2-platforms][PATCH v3 0/6] Resolving SecureBootVariableLib dependency Ard Biesheuvel
  6 siblings, 0 replies; 9+ messages in thread
From: Kun Qin @ 2022-08-02 22:59 UTC (permalink / raw)
  To: devel; +Cc: Leif Lindholm, Peng Xie, Ling Jia, Yiqi Shu, Sami Mujawar

The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
PhytiumCommonPkg platforms build.

Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Peng Xie <xiepeng@phytium.com.cn>
Cc: Ling Jia <jialing@phytium.com.cn>
Cc: Yiqi Shu <shuyiqi@phytium.com.cn>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
---

Notes:
    v2:
    - No review, no change.
    
    v3:
    - Added reviewed-by tag [Sami].

 Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc b/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
index a7ca630be7b9..3c4440dac5f0 100644
--- a/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
+++ b/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
@@ -83,6 +83,7 @@ [LibraryClasses.common]
   SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 
   TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf
   TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
-- 
2.37.1.windows.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [edk2-platforms][PATCH v3 0/6] Resolving SecureBootVariableLib dependency
  2022-08-02 22:59 [edk2-platforms][PATCH v3 0/6] Resolving SecureBootVariableLib dependency Kun Qin
                   ` (5 preceding siblings ...)
  2022-08-02 22:59 ` [edk2-platforms][PATCH v3 6/6] PhytiumCommonPkg: " Kun Qin
@ 2022-08-04 10:26 ` Ard Biesheuvel
  2022-08-05  0:40   ` Kun Qin
  6 siblings, 1 reply; 9+ messages in thread
From: Ard Biesheuvel @ 2022-08-04 10:26 UTC (permalink / raw)
  To: Kun Qin
  Cc: edk2-devel-groups-io, Ard Biesheuvel, Leif Lindholm,
	Graeme Gregory, Radoslaw Biernacki, Masami Hiramatsu, Nhi Pham,
	Vu Nguyen, Thang Nguyen, Chuong Tran, Thomas Abraham,
	Sami Mujawar, Abner Chang, Gilbert Chen, Daniel Schaefer,
	Jeremy Linton, Peng Xie, Ling Jia, Yiqi Shu

On Wed, 3 Aug 2022 at 00:59, Kun Qin <kuqin12@gmail.com> wrote:
>
> This v2 series is a follow up of previously submitted patches:
> https://edk2.groups.io/g/devel/message/91669
>
> The main update in v3 patches are:
> - Updated a commit message to include Review-by tag
> - Dumped a commit for Qemu platform as it was fixed by others
>
> Patch v3 branch:https://github.com/kuqin12/edk2-platforms/tree/fix_sb_dep_v3

The patches look fine to me, but what does 'Pipeline' mean?

>
> Cc: Ard Biesheuvel<ardb+tianocore@kernel.org>
> Cc: Leif Lindholm<quic_llindhol@quicinc.com>
> Cc: Graeme Gregory<graeme@nuviainc.com>
> Cc: Radoslaw Biernacki<rad@semihalf.com>
> Cc: Masami Hiramatsu<masami.hiramatsu@linaro.org>
> Cc: Nhi Pham<nhi@os.amperecomputing.com>
> Cc: Vu Nguyen<vunguyen@os.amperecomputing.com>
> Cc: Thang Nguyen<thang@os.amperecomputing.com>
> Cc: Chuong Tran<chuong@os.amperecomputing.com>
> Cc: Thomas Abraham<thomas.abraham@arm.com>
> Cc: Sami Mujawar<sami.mujawar@arm.com>
> Cc: Abner Chang<abner.chang@hpe.com>
> Cc: Gilbert Chen<gilbert.chen@hpe.com>
> Cc: Daniel Schaefer<daniel.schaefer@hpe.com>
> Cc: Jeremy Linton<jeremy.linton@arm.com>
> Cc: Peng Xie<xiepeng@phytium.com.cn>
> Cc: Ling Jia<jialing@phytium.com.cn>
> Cc: Yiqi Shu<shuyiqi@phytium.com.cn>
>
> Kun Qin (6):
>   RaspberryPi: Pipeline: Resolving newly introduced dependency
>   U5SeriesPkg: Pipeline: Resolving newly introduced dependency
>   VExpressPkg: Pipeline: Resolving newly introduced dependency
>   Socionext: Pipeline: Resolving newly introduced dependency
>   AmpereAltraPkg: Pipeline: Resolving newly introduced dependency
>   PhytiumCommonPkg: Pipeline: Resolving newly introduced dependency
>
>  Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc                         | 1 +
>  Platform/RaspberryPi/RPi3/RPi3.dsc                                   | 1 +
>  Platform/RaspberryPi/RPi4/RPi4.dsc                                   | 1 +
>  Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc           | 1 +
>  Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 +
>  Platform/Socionext/DeveloperBox/DeveloperBox.dsc                     | 1 +
>  Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc                 | 1 +
>  Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc            | 1 +
>  8 files changed, 8 insertions(+)
>
> --
> 2.37.1.windows.1
>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [edk2-platforms][PATCH v3 0/6] Resolving SecureBootVariableLib dependency
  2022-08-04 10:26 ` [edk2-platforms][PATCH v3 0/6] Resolving SecureBootVariableLib dependency Ard Biesheuvel
@ 2022-08-05  0:40   ` Kun Qin
  0 siblings, 0 replies; 9+ messages in thread
From: Kun Qin @ 2022-08-05  0:40 UTC (permalink / raw)
  To: Ard Biesheuvel
  Cc: edk2-devel-groups-io, Ard Biesheuvel, Leif Lindholm,
	Graeme Gregory, Radoslaw Biernacki, Masami Hiramatsu, Nhi Pham,
	Vu Nguyen, Thang Nguyen, Chuong Tran, Thomas Abraham,
	Sami Mujawar, Abner Chang, Gilbert Chen, Daniel Schaefer,
	Jeremy Linton, Peng Xie, Ling Jia, Yiqi Shu

Hi Ard,

The term "Pipeline" is not applicable in the scope of edk2-platforms. 
Thanks for catching it.

A new version was sent for this fix: 
https://edk2.groups.io/g/devel/message/92128. Please let
me know if there is any other feedback.

Regards,
Kun

On 8/4/2022 3:26 AM, Ard Biesheuvel wrote:
> On Wed, 3 Aug 2022 at 00:59, Kun Qin <kuqin12@gmail.com> wrote:
>> This v2 series is a follow up of previously submitted patches:
>> https://edk2.groups.io/g/devel/message/91669
>>
>> The main update in v3 patches are:
>> - Updated a commit message to include Review-by tag
>> - Dumped a commit for Qemu platform as it was fixed by others
>>
>> Patch v3 branch:https://github.com/kuqin12/edk2-platforms/tree/fix_sb_dep_v3
> The patches look fine to me, but what does 'Pipeline' mean?
>
>> Cc: Ard Biesheuvel<ardb+tianocore@kernel.org>
>> Cc: Leif Lindholm<quic_llindhol@quicinc.com>
>> Cc: Graeme Gregory<graeme@nuviainc.com>
>> Cc: Radoslaw Biernacki<rad@semihalf.com>
>> Cc: Masami Hiramatsu<masami.hiramatsu@linaro.org>
>> Cc: Nhi Pham<nhi@os.amperecomputing.com>
>> Cc: Vu Nguyen<vunguyen@os.amperecomputing.com>
>> Cc: Thang Nguyen<thang@os.amperecomputing.com>
>> Cc: Chuong Tran<chuong@os.amperecomputing.com>
>> Cc: Thomas Abraham<thomas.abraham@arm.com>
>> Cc: Sami Mujawar<sami.mujawar@arm.com>
>> Cc: Abner Chang<abner.chang@hpe.com>
>> Cc: Gilbert Chen<gilbert.chen@hpe.com>
>> Cc: Daniel Schaefer<daniel.schaefer@hpe.com>
>> Cc: Jeremy Linton<jeremy.linton@arm.com>
>> Cc: Peng Xie<xiepeng@phytium.com.cn>
>> Cc: Ling Jia<jialing@phytium.com.cn>
>> Cc: Yiqi Shu<shuyiqi@phytium.com.cn>
>>
>> Kun Qin (6):
>>    RaspberryPi: Pipeline: Resolving newly introduced dependency
>>    U5SeriesPkg: Pipeline: Resolving newly introduced dependency
>>    VExpressPkg: Pipeline: Resolving newly introduced dependency
>>    Socionext: Pipeline: Resolving newly introduced dependency
>>    AmpereAltraPkg: Pipeline: Resolving newly introduced dependency
>>    PhytiumCommonPkg: Pipeline: Resolving newly introduced dependency
>>
>>   Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc                         | 1 +
>>   Platform/RaspberryPi/RPi3/RPi3.dsc                                   | 1 +
>>   Platform/RaspberryPi/RPi4/RPi4.dsc                                   | 1 +
>>   Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc           | 1 +
>>   Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 +
>>   Platform/Socionext/DeveloperBox/DeveloperBox.dsc                     | 1 +
>>   Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc                 | 1 +
>>   Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc            | 1 +
>>   8 files changed, 8 insertions(+)
>>
>> --
>> 2.37.1.windows.1
>>

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2022-08-05  0:40 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-02 22:59 [edk2-platforms][PATCH v3 0/6] Resolving SecureBootVariableLib dependency Kun Qin
2022-08-02 22:59 ` [edk2-platforms][PATCH v3 1/6] RaspberryPi: Pipeline: Resolving newly introduced dependency Kun Qin
2022-08-02 22:59 ` [edk2-platforms][PATCH v3 2/6] U5SeriesPkg: " Kun Qin
2022-08-02 22:59 ` [edk2-platforms][PATCH v3 3/6] VExpressPkg: " Kun Qin
2022-08-02 22:59 ` [edk2-platforms][PATCH v3 4/6] Socionext: " Kun Qin
2022-08-02 22:59 ` [edk2-platforms][PATCH v3 5/6] AmpereAltraPkg: " Kun Qin
2022-08-02 22:59 ` [edk2-platforms][PATCH v3 6/6] PhytiumCommonPkg: " Kun Qin
2022-08-04 10:26 ` [edk2-platforms][PATCH v3 0/6] Resolving SecureBootVariableLib dependency Ard Biesheuvel
2022-08-05  0:40   ` Kun Qin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox