From: "Sami Mujawar" <sami.mujawar@arm.com>
To: <devel@edk2.groups.io>
Cc: Sami Mujawar <sami.mujawar@arm.com>, <ardb+tianocore@kernel.org>,
<mikuback@linux.microsoft.com>, <nathaniel.l.desimone@intel.com>,
<ankit.sinha@intel.com>, <npham@amperecomputing.com>,
<loc.ho@amperecomputing.com>, <jose.marinho@arm.com>,
<Samer.El-Haj-Mahmoud@arm.com>, <Matteo.Carlini@arm.com>,
<Akanksha.Jain2@arm.com>, <Ben.Adderson@arm.com>, <nd@arm.com>
Subject: [PATCH v1 1/5] Basetools/GenFw: Allow AARCH64 builds to use the --prm flag
Date: Wed, 3 Aug 2022 15:35:43 +0100 [thread overview]
Message-ID: <20220803143547.27772-2-sami.mujawar@arm.com> (raw)
In-Reply-To: <20220803143547.27772-1-sami.mujawar@arm.com>
From: Jose Marinho <jose.marinho@arm.com>
The GenFw invocation with the --prm flag was previously reserved for
X64.
AArch64 platforms, built with GCC5, can also deploy PRM modules, hence
the --prm flag is also applicable in builds targeting the AARCH64
architecture.
This commit enables the --prm flag to be used for EDK2 builds targeting
AARCH64.
Signed-off-by: Jose Marinho <jose.marinho@arm.com>
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
BaseTools/Source/C/GenFw/Elf64Convert.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/BaseTools/Source/C/GenFw/Elf64Convert.c b/BaseTools/Source/C/GenFw/Elf64Convert.c
index 2aa9bfcc9460c0a68208808e036fc631ae14f90e..35e96dd05bc26f7212d0f80af1ecb998bcb993dd 100644
--- a/BaseTools/Source/C/GenFw/Elf64Convert.c
+++ b/BaseTools/Source/C/GenFw/Elf64Convert.c
@@ -2,7 +2,7 @@
Elf64 convert solution
Copyright (c) 2010 - 2021, Intel Corporation. All rights reserved.<BR>
-Portions copyright (c) 2013-2014, ARM Ltd. All rights reserved.<BR>
+Portions copyright (c) 2013-2022, ARM Ltd. All rights reserved.<BR>
Portions Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -186,8 +186,8 @@ InitializeElf64 (
}
if (mExportFlag) {
- if (mEhdr->e_machine != EM_X86_64) {
- Error (NULL, 0, 3000, "Unsupported", "--prm option currently only supports X64 arch.");
+ if ((mEhdr->e_machine != EM_X86_64) && (mEhdr->e_machine != EM_AARCH64)) {
+ Error (NULL, 0, 3000, "Unsupported", "--prm option currently only supports X64 and AArch64 archs.");
return FALSE;
}
}
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
next prev parent reply other threads:[~2022-08-03 14:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 14:35 [PATCH v1 0/5] Add support to build PRM for AARCH64 using GCC Sami Mujawar
2022-08-03 14:35 ` Sami Mujawar [this message]
2022-08-03 14:35 ` [PATCH v1 2/5] PrmPkg: Enable external visibility on PRM symbols Sami Mujawar
2022-08-03 14:35 ` [PATCH v1 3/5] PrmPkg: Build Prm Samples with GCC for AARCH64 Sami Mujawar
2022-08-03 14:35 ` [PATCH v1 4/5] PrmPkg: Support AArch64 builds using GCC Sami Mujawar
2022-08-03 14:35 ` [PATCH v1 5/5] PrmPkg: Add details on AArch64 build to the Readme Sami Mujawar
2022-08-04 4:09 ` [PATCH v1 0/5] Add support to build PRM for AARCH64 using GCC Michael Kubacki
2022-08-08 10:35 ` Sami Mujawar
2022-08-08 22:47 ` [edk2-devel] " Michael Kubacki
2022-08-04 10:32 ` Ard Biesheuvel
2022-08-05 15:08 ` Michael Kubacki
2022-08-08 10:34 ` Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220803143547.27772-2-sami.mujawar@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox