[edk2-platforms][PATCH v4 0/6] Resolving SecureBootVariableLib dependency

[edk2-platforms][PATCH v4 0/6] Resolving SecureBootVariableLib dependency

[Kun Qin]

This v4 series is a follow up of previously submitted patches:
https://edk2.groups.io/g/devel/message/92063

The only update in v4 patches is to update the commit titles to remove
"pipeline" references as this is not applicable to edk2-platforms.

Patch v4 branch:https://github.com/kuqin12/edk2-platforms/tree/fix_sb_dep_v4

Cc: Ard Biesheuvel<ardb+tianocore@kernel.org>
Cc: Leif Lindholm<quic_llindhol@quicinc.com>
Cc: Graeme Gregory<graeme@nuviainc.com>
Cc: Radoslaw Biernacki<rad@semihalf.com>
Cc: Masami Hiramatsu<masami.hiramatsu@linaro.org>
Cc: Nhi Pham<nhi@os.amperecomputing.com>
Cc: Vu Nguyen<vunguyen@os.amperecomputing.com>
Cc: Thang Nguyen<thang@os.amperecomputing.com>
Cc: Chuong Tran<chuong@os.amperecomputing.com>
Cc: Thomas Abraham<thomas.abraham@arm.com>
Cc: Sami Mujawar<sami.mujawar@arm.com>
Cc: Abner Chang<abner.chang@hpe.com>
Cc: Gilbert Chen<gilbert.chen@hpe.com>
Cc: Daniel Schaefer<daniel.schaefer@hpe.com>
Cc: Jeremy Linton<jeremy.linton@arm.com>
Cc: Peng Xie<xiepeng@phytium.com.cn>
Cc: Ling Jia<jialing@phytium.com.cn>
Cc: Yiqi Shu<shuyiqi@phytium.com.cn>

Kun Qin (6):
  RaspberryPi: Platform Build: Resolving newly introduced dependency
  U5SeriesPkg: Platform Build: Resolving newly introduced dependency
  VExpressPkg: Platform Build: Resolving newly introduced dependency
  Socionext: Platform Build: Resolving newly introduced dependency
  AmpereAltraPkg: Platform Build: Resolving newly introduced dependency
  PhytiumCommonPkg: Platform Build: Resolving newly introduced
    dependency

 Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc                         | 1 +
 Platform/RaspberryPi/RPi3/RPi3.dsc                                   | 1 +
 Platform/RaspberryPi/RPi4/RPi4.dsc                                   | 1 +
 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc           | 1 +
 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 +
 Platform/Socionext/DeveloperBox/DeveloperBox.dsc                     | 1 +
 Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc                 | 1 +
 Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc            | 1 +
 8 files changed, 8 insertions(+)

-- 
2.37.1.windows.1

[edk2-platforms][PATCH v4 1/6] RaspberryPi: Platform Build: Resolving newly introduced dependency

[Kun Qin]

The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
RaspberryPi platforms build.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Jeremy Linton <jeremy.linton@arm.com>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>
---

Notes:
    v2:
    - Add reviewed-by tag [Jeremy]
    
    v4:
    - Updated commit title.

 Platform/RaspberryPi/RPi3/RPi3.dsc | 1 +
 Platform/RaspberryPi/RPi4/RPi4.dsc | 1 +
 2 files changed, 2 insertions(+)

diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
index 0eed03c097f8..4e7377a00036 100644
--- a/Platform/RaspberryPi/RPi3/RPi3.dsc
+++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
@@ -169,6 +169,7 @@ [LibraryClasses.common]
   PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 !else
   TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
   AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
index eabddd7382cf..8ba0ca61851e 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -166,6 +166,7 @@ [LibraryClasses.common]
   AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 
   # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree
   PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
-- 
2.37.1.windows.1

[edk2-platforms][PATCH v4 2/6] U5SeriesPkg: Platform Build: Resolving newly introduced dependency

[Kun Qin]

The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
U5SeriesPkg platforms build.

Cc: Abner Chang <abner.chang@hpe.com>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
---

Notes:
    v2:
    - No review, no change
    
    v4:
    - Updated commit title.

 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc           | 1 +
 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 +
 2 files changed, 2 insertions(+)

diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
index 7b36b2c885e0..fc1ed012a541 100644
--- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
+++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
@@ -127,6 +127,7 @@ [LibraryClasses]
   AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 !else
   TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
   AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
index 26895a75ec2f..e59955d09452 100644
--- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
+++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
@@ -127,6 +127,7 @@ [LibraryClasses]
   AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 !else
   TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
   AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
-- 
2.37.1.windows.1

[edk2-platforms][PATCH v4 3/6] VExpressPkg: Platform Build: Resolving newly introduced dependency

[Kun Qin]

The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
ArmVExpress platforms build.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Thomas Abraham <thomas.abraham@arm.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
---

Notes:
    v2:
    - Added reviewed-by tag [Sami]
    
    v4:
    - Updated commits title

 Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
index e637f8933f79..17e4a3fd13d7 100644
--- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
+++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
@@ -143,6 +143,7 @@ [LibraryClasses.common]
   AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 
   # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree
   PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
-- 
2.37.1.windows.1

[edk2-platforms][PATCH v4 4/6] Socionext: Platform Build: Resolving newly introduced dependency

[Kun Qin]

The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
DeveloperBox platforms build.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Masami Hiramatsu <masami.hiramatsu@linaro.org>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
---

Notes:
    v2:
    - No review, no change.
    
    v4:
    - Updated commit title.

 Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
index 8419c89318fb..917c1532fb3c 100644
--- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
+++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
@@ -55,6 +55,7 @@ [LibraryClasses]
 !if $(SECURE_BOOT_ENABLE) == TRUE
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 !endif
 
 [LibraryClasses.common.SEC]
-- 
2.37.1.windows.1

[edk2-platforms][PATCH v4 5/6] AmpereAltraPkg: Platform Build: Resolving newly introduced dependency

[Kun Qin]

The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
AmpereAltraPkg platforms build.

Cc: Nhi Pham <nhi@os.amperecomputing.com>
Cc: Vu Nguyen <vunguyen@os.amperecomputing.com>
Cc: Thang Nguyen <thang@os.amperecomputing.com>
Cc: Chuong Tran <chuong@os.amperecomputing.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
Reviewed-by: Nhi Pham <nhi@os.amperecomputing.com>
---

Notes:
    v2:
    - Added reviewed-by tag [Nhi]
    
    v4:
    - Updated commit title

 Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
index d4c29c3c338c..1e378e37e2b8 100644
--- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
+++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
@@ -144,6 +144,7 @@ [LibraryClasses.common]
   BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 
   #
   # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree
-- 
2.37.1.windows.1

[edk2-platforms][PATCH v4 6/6] PhytiumCommonPkg: Platform Build: Resolving newly introduced dependency

[Kun Qin]

The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
PhytiumCommonPkg platforms build.

Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Peng Xie <xiepeng@phytium.com.cn>
Cc: Ling Jia <jialing@phytium.com.cn>
Cc: Yiqi Shu <shuyiqi@phytium.com.cn>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
---

Notes:
    v2:
    - No review, no change.
    
    v3:
    - Added reviewed-by tag [Sami].
    
    v4:
    - Updated commit title.

 Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc b/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
index a7ca630be7b9..3c4440dac5f0 100644
--- a/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
+++ b/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
@@ -83,6 +83,7 @@ [LibraryClasses.common]
   SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 
   TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf
   TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
-- 
2.37.1.windows.1

Re: [edk2-devel] [edk2-platforms][PATCH v4 2/6] U5SeriesPkg: Platform Build: Resolving newly introduced dependency

[Kun Qin]

Hi U5SeriesPkg maintainers,

Can you please review the patch below and let me know if any feedback?
Platform build could be broken without this change.

Any input is appreciated.

Regards,
Kun

On 8/4/2022 5:35 PM, Kun Qin via groups.io wrote:
> The new changes in SecureBootVariableLib brought in a new dependency
> of PlatformPKProtectionLib.
>
> This change added the new library instance from SecurityPkg to resolve
> U5SeriesPkg platforms build.
>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Gilbert Chen <gilbert.chen@hpe.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
>
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> ---
>
> Notes:
>      v2:
>      - No review, no change
>      
>      v4:
>      - Updated commit title.
>
>   Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc           | 1 +
>   Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> index 7b36b2c885e0..fc1ed012a541 100644
> --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> @@ -127,6 +127,7 @@ [LibraryClasses]
>     AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
>
>     SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
>
>     SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
>
> +  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
>
>   !else
>
>     TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
>
>     AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
>
> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
> index 26895a75ec2f..e59955d09452 100644
> --- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
> @@ -127,6 +127,7 @@ [LibraryClasses]
>     AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
>
>     SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
>
>     SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
>
> +  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
>
>   !else
>
>     TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
>
>     AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
>

Re: [edk2-devel] [edk2-platforms][PATCH v4 2/6] U5SeriesPkg: Platform Build: Resolving newly introduced dependency

[Daniel Schaefer]

Hi Kun,

sorry for the late reply.
The change is okay - thanks for making sure to change this platform, too!

Reviewed-by: Daniel Schaefer <daniel.schaefer@hpe.com>

Thanks,
Daniel

On 8/11/22 06:52, Kun Qin wrote:
> Hi U5SeriesPkg maintainers,
> 
> Can you please review the patch below and let me know if any feedback?
> Platform build could be broken without this change.
> 
> Any input is appreciated.
> 
> Regards,
> Kun
> 
> On 8/4/2022 5:35 PM, Kun Qin via groups.io wrote:
>> The new changes in SecureBootVariableLib brought in a new dependency
>> of PlatformPKProtectionLib.
>>
>> This change added the new library instance from SecurityPkg to resolve
>> U5SeriesPkg platforms build.
>>
>> Cc: Abner Chang <abner.chang@hpe.com>
>> Cc: Gilbert Chen <gilbert.chen@hpe.com>
>> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
>>
>> Signed-off-by: Kun Qin <kuqin12@gmail.com>
>> ---
>>
>> Notes:
>>      v2:
>>      - No review, no change
>>           v4:
>>      - Updated commit title.
>>
>>   Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc           | 1 +
>>   Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 +
>>   2 files changed, 2 insertions(+)
>>
>> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
>> index 7b36b2c885e0..fc1ed012a541 100644
>> --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
>> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
>> @@ -127,6 +127,7 @@ [LibraryClasses]
>>     AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
>>
>>     SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
>>
>>     SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
>>
>> +  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
>>
>>   !else
>>
>>     TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
>>
>>     AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
>>
>> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
>> index 26895a75ec2f..e59955d09452 100644
>> --- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
>> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
>> @@ -127,6 +127,7 @@ [LibraryClasses]
>>     AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
>>
>>     SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
>>
>>     SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
>>
>> +  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
>>
>>   !else
>>
>>     TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
>>
>>     AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
>>

Re: [edk2-devel] [edk2-platforms][PATCH v4 2/6] U5SeriesPkg: Platform Build: Resolving newly introduced dependency

[Kun Qin]

Thank you for the review, Daniel!

Regards,
Kun

On 8/10/2022 8:02 PM, Daniel Schaefer wrote:
> Hi Kun,
>
> sorry for the late reply.
> The change is okay - thanks for making sure to change this platform, too!
>
> Reviewed-by: Daniel Schaefer <daniel.schaefer@hpe.com>
>
> Thanks,
> Daniel
>
> On 8/11/22 06:52, Kun Qin wrote:
>> Hi U5SeriesPkg maintainers,
>>
>> Can you please review the patch below and let me know if any feedback?
>> Platform build could be broken without this change.
>>
>> Any input is appreciated.
>>
>> Regards,
>> Kun
>>
>> On 8/4/2022 5:35 PM, Kun Qin via groups.io wrote:
>>> The new changes in SecureBootVariableLib brought in a new dependency
>>> of PlatformPKProtectionLib.
>>>
>>> This change added the new library instance from SecurityPkg to resolve
>>> U5SeriesPkg platforms build.
>>>
>>> Cc: Abner Chang <abner.chang@hpe.com>
>>> Cc: Gilbert Chen <gilbert.chen@hpe.com>
>>> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
>>>
>>> Signed-off-by: Kun Qin <kuqin12@gmail.com>
>>> ---
>>>
>>> Notes:
>>>       v2:
>>>       - No review, no change
>>>            v4:
>>>       - Updated commit title.
>>>
>>>    Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc           | 1 +
>>>    Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 +
>>>    2 files changed, 2 insertions(+)
>>>
>>> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
>>> index 7b36b2c885e0..fc1ed012a541 100644
>>> --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
>>> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
>>> @@ -127,6 +127,7 @@ [LibraryClasses]
>>>      AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
>>>
>>>      SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
>>>
>>>      SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
>>>
>>> +  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
>>>
>>>    !else
>>>
>>>      TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
>>>
>>>      AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
>>>
>>> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
>>> index 26895a75ec2f..e59955d09452 100644
>>> --- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
>>> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
>>> @@ -127,6 +127,7 @@ [LibraryClasses]
>>>      AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
>>>
>>>      SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
>>>
>>>      SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
>>>
>>> +  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
>>>
>>>    !else
>>>
>>>      TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
>>>
>>>      AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
>>>

Re: [edk2-devel] [edk2-platforms][PATCH v4 4/6] Socionext: Platform Build: Resolving newly introduced dependency

[Kun Qin]

Hi Ard,

Could you please help review this patch? Any feedback in appreciated.

Regards,
Kun

On 8/4/2022 5:35 PM, Kun Qin via groups.io wrote:
> The new changes in SecureBootVariableLib brought in a new dependency
> of PlatformPKProtectionLib.
>
> This change added the new library instance from SecurityPkg to resolve
> DeveloperBox platforms build.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Masami Hiramatsu <masami.hiramatsu@linaro.org>
>
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> ---
>
> Notes:
>      v2:
>      - No review, no change.
>      
>      v4:
>      - Updated commit title.
>
>   Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> index 8419c89318fb..917c1532fb3c 100644
> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> @@ -55,6 +55,7 @@ [LibraryClasses]
>   !if $(SECURE_BOOT_ENABLE) == TRUE
>
>     SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
>
>     SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
>
> +  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
>
>   !endif
>
>   
>
>   [LibraryClasses.common.SEC]
>

Re: [edk2-devel] [edk2-platforms][PATCH v4 4/6] Socionext: Platform Build: Resolving newly introduced dependency

[Ard Biesheuvel]

On Thu, 11 Aug 2022 at 00:54, Kun Qin <kuqin12@gmail.com> wrote:
>
> Hi Ard,
>
> Could you please help review this patch? Any feedback in appreciated.
>

Thanks for the fix

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

Pushed as 01e3a8877180..9675047d7245
>

> On 8/4/2022 5:35 PM, Kun Qin via groups.io wrote:
> > The new changes in SecureBootVariableLib brought in a new dependency
> > of PlatformPKProtectionLib.
> >
> > This change added the new library instance from SecurityPkg to resolve
> > DeveloperBox platforms build.
> >
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > Cc: Masami Hiramatsu <masami.hiramatsu@linaro.org>
> >
> > Signed-off-by: Kun Qin <kuqin12@gmail.com>
> > ---
> >
> > Notes:
> >      v2:
> >      - No review, no change.
> >
> >      v4:
> >      - Updated commit title.
> >
> >   Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> > index 8419c89318fb..917c1532fb3c 100644
> > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> > @@ -55,6 +55,7 @@ [LibraryClasses]
> >   !if $(SECURE_BOOT_ENABLE) == TRUE
> >
> >     SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
> >
> >     SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
> >
> > +  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
> >
> >   !endif
> >
> >
> >
> >   [LibraryClasses.common.SEC]
> >