* [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Prevent modification of HOB data
@ 2022-08-05 17:15 Michael Kubacki
2022-08-05 20:29 ` Oram, Isaac W
[not found] ` <17088CED31060862.21918@groups.io>
0 siblings, 2 replies; 3+ messages in thread
From: Michael Kubacki @ 2022-08-05 17:15 UTC (permalink / raw)
To: devel; +Cc: Chasel Chiu, Nate DeSimone, Isaac Oram, Liming Gao, Eric Dong
From: Michael Kubacki <michael.kubacki@microsoft.com>
DumpMemoryTypeInfoSummary() is used to dump information about the
MemoryTypeInformation HOB. The dump function currently modifies the
data which can corrupt the data for later HOB consumers in the DXE
phase.
This change makes DumpMemoryTypeInfoSummary() treat the data as
read-only.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c
index 9ee9dd252c7e..a30b69dd787c 100644
--- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c
+++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c
@@ -22,8 +22,8 @@ ShortNameOfMemoryType(
VOID
DumpMemoryTypeInfoSummary (
- IN EFI_MEMORY_TYPE_INFORMATION *CurrentMemoryTypeInformation,
- IN EFI_MEMORY_TYPE_INFORMATION *PreviousMemoryTypeInformation
+ IN CONST EFI_MEMORY_TYPE_INFORMATION *CurrentMemoryTypeInformation,
+ IN CONST EFI_MEMORY_TYPE_INFORMATION *PreviousMemoryTypeInformation
)
{
UINTN Index;
@@ -83,7 +83,6 @@ DumpMemoryTypeInfoSummary (
}
if (Next != Previous) {
- PreviousMemoryTypeInformation[Index].NumberOfPages = Next;
MemoryTypeInformationModified = TRUE;
}
@@ -110,7 +109,7 @@ TestPointCheckMemoryTypeInformation (
VOID *CurrentMemoryTypeInformation;
VOID *PreviousMemoryTypeInformation;
VOID *VariableMemoryTypeInformation;
-
+
DEBUG ((DEBUG_INFO, "==== TestPointCheckMemoryTypeInformation - Enter\n"));
CurrentMemoryTypeInformation = NULL;
PreviousMemoryTypeInformation = NULL;
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Prevent modification of HOB data 2022-08-05 17:15 [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Prevent modification of HOB data Michael Kubacki @ 2022-08-05 20:29 ` Oram, Isaac W [not found] ` <17088CED31060862.21918@groups.io> 1 sibling, 0 replies; 3+ messages in thread From: Oram, Isaac W @ 2022-08-05 20:29 UTC (permalink / raw) To: mikuback@linux.microsoft.com, devel@edk2.groups.io Cc: Chiu, Chasel, Desimone, Nathaniel L, Gao, Liming, Dong, Eric Reviewed-by: Isaac Oram <isaac.w.oram@intel.com> -----Original Message----- From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com> Sent: Friday, August 5, 2022 10:16 AM To: devel@edk2.groups.io Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com> Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Prevent modification of HOB data From: Michael Kubacki <michael.kubacki@microsoft.com> DumpMemoryTypeInfoSummary() is used to dump information about the MemoryTypeInformation HOB. The dump function currently modifies the data which can corrupt the data for later HOB consumers in the DXE phase. This change makes DumpMemoryTypeInfoSummary() treat the data as read-only. Cc: Chasel Chiu <chasel.chiu@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Isaac Oram <isaac.w.oram@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Eric Dong <eric.dong@intel.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> --- Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c index 9ee9dd252c7e..a30b69dd787c 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCh +++ eckMemoryTypeInformation.c @@ -22,8 +22,8 @@ ShortNameOfMemoryType( VOID DumpMemoryTypeInfoSummary ( - IN EFI_MEMORY_TYPE_INFORMATION *CurrentMemoryTypeInformation, - IN EFI_MEMORY_TYPE_INFORMATION *PreviousMemoryTypeInformation + IN CONST EFI_MEMORY_TYPE_INFORMATION *CurrentMemoryTypeInformation, + IN CONST EFI_MEMORY_TYPE_INFORMATION *PreviousMemoryTypeInformation ) { UINTN Index; @@ -83,7 +83,6 @@ DumpMemoryTypeInfoSummary ( } if (Next != Previous) { - PreviousMemoryTypeInformation[Index].NumberOfPages = Next; MemoryTypeInformationModified = TRUE; } @@ -110,7 +109,7 @@ TestPointCheckMemoryTypeInformation ( VOID *CurrentMemoryTypeInformation; VOID *PreviousMemoryTypeInformation; VOID *VariableMemoryTypeInformation; - + DEBUG ((DEBUG_INFO, "==== TestPointCheckMemoryTypeInformation - Enter\n")); CurrentMemoryTypeInformation = NULL; PreviousMemoryTypeInformation = NULL; -- 2.28.0.windows.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <17088CED31060862.21918@groups.io>]
* Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Prevent modification of HOB data [not found] ` <17088CED31060862.21918@groups.io> @ 2022-08-08 19:02 ` Oram, Isaac W 0 siblings, 0 replies; 3+ messages in thread From: Oram, Isaac W @ 2022-08-08 19:02 UTC (permalink / raw) To: devel@edk2.groups.io, Oram, Isaac W, mikuback@linux.microsoft.com Cc: Chiu, Chasel, Desimone, Nathaniel L, Gao, Liming, Dong, Eric Pushed as 436a8612ae..ea2a520c83 -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oram, Isaac W Sent: Friday, August 5, 2022 1:30 PM To: mikuback@linux.microsoft.com; devel@edk2.groups.io Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Prevent modification of HOB data Reviewed-by: Isaac Oram <isaac.w.oram@intel.com> -----Original Message----- From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com> Sent: Friday, August 5, 2022 10:16 AM To: devel@edk2.groups.io Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com> Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Prevent modification of HOB data From: Michael Kubacki <michael.kubacki@microsoft.com> DumpMemoryTypeInfoSummary() is used to dump information about the MemoryTypeInformation HOB. The dump function currently modifies the data which can corrupt the data for later HOB consumers in the DXE phase. This change makes DumpMemoryTypeInfoSummary() treat the data as read-only. Cc: Chasel Chiu <chasel.chiu@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Isaac Oram <isaac.w.oram@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Eric Dong <eric.dong@intel.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> --- Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c index 9ee9dd252c7e..a30b69dd787c 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemoryTypeInformation.c +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCh +++ eckMemoryTypeInformation.c @@ -22,8 +22,8 @@ ShortNameOfMemoryType( VOID DumpMemoryTypeInfoSummary ( - IN EFI_MEMORY_TYPE_INFORMATION *CurrentMemoryTypeInformation, - IN EFI_MEMORY_TYPE_INFORMATION *PreviousMemoryTypeInformation + IN CONST EFI_MEMORY_TYPE_INFORMATION *CurrentMemoryTypeInformation, + IN CONST EFI_MEMORY_TYPE_INFORMATION *PreviousMemoryTypeInformation ) { UINTN Index; @@ -83,7 +83,6 @@ DumpMemoryTypeInfoSummary ( } if (Next != Previous) { - PreviousMemoryTypeInformation[Index].NumberOfPages = Next; MemoryTypeInformationModified = TRUE; } @@ -110,7 +109,7 @@ TestPointCheckMemoryTypeInformation ( VOID *CurrentMemoryTypeInformation; VOID *PreviousMemoryTypeInformation; VOID *VariableMemoryTypeInformation; - + DEBUG ((DEBUG_INFO, "==== TestPointCheckMemoryTypeInformation - Enter\n")); CurrentMemoryTypeInformation = NULL; PreviousMemoryTypeInformation = NULL; -- 2.28.0.windows.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-08 19:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-05 17:15 [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Prevent modification of HOB data Michael Kubacki
2022-08-05 20:29 ` Oram, Isaac W
[not found] ` <17088CED31060862.21918@groups.io>
2022-08-08 19:02 ` [edk2-devel] " Oram, Isaac W
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox