From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.919.1659722567661892432 for ; Fri, 05 Aug 2022 11:02:47 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=hA56g9mt; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 5F8E620FFE14; Fri, 5 Aug 2022 11:02:46 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5F8E620FFE14 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1659722567; bh=a1UP0slhmDZ+wvciF6NETddIAxjq7Ku4xsZnWlmwMSo=; h=From:To:Cc:Subject:Date:From; b=hA56g9mtTSoO9+5bjF59OHjuH1o3J7g5VRTnlv0zfPk0vLA1eh8bVDzeskNtXPdMh CBBPP4g+aAE6sz0YG3mg7aIUEYJx3ALn9GheT68+Od7OdSug+BpDeUPP5wKkItTEek QlNwSqEnLe2y/gNzlmw0GRPmoBMzttzcrm4LtSZc= From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Isaac Oram , Liming Gao , Eric Dong Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Remove unnecessary GetVariable2() call Date: Fri, 5 Aug 2022 14:02:13 -0400 Message-Id: <20220805180213.944-1-mikuback@linux.microsoft.com> X-Mailer: git-send-email 2.28.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Kubacki The data buffer returned from the GetVariable2() call in TestPointCheckMemoryTypeInformation() is not actually used or freed. This change removes the unnecessary function call. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki --- Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMem= oryTypeInformation.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib= /DxeCheckMemoryTypeInformation.c b/Platform/Intel/MinPlatformPkg/Test/Lib= rary/TestPointCheckLib/DxeCheckMemoryTypeInformation.c index 9ee9dd252c7e..0ff6789ac621 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeChe= ckMemoryTypeInformation.c +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeChe= ckMemoryTypeInformation.c @@ -109,7 +109,6 @@ TestPointCheckMemoryTypeInformation ( EFI_HOB_GUID_TYPE *GuidHob; VOID *CurrentMemoryTypeInformation; VOID *PreviousMemoryTypeInformation; - VOID *VariableMemoryTypeInformation; =20 DEBUG ((DEBUG_INFO, "=3D=3D=3D=3D TestPointCheckMemoryTypeInformation = - Enter\n")); CurrentMemoryTypeInformation =3D NULL; @@ -128,13 +127,6 @@ TestPointCheckMemoryTypeInformation ( goto Done; } =20 - GetVariable2 ( - EFI_MEMORY_TYPE_INFORMATION_VARIABLE_NAME, - &gEfiMemoryTypeInformationGuid, - &VariableMemoryTypeInformation, - NULL - ); - if ((CurrentMemoryTypeInformation !=3D NULL) && (PreviousMemoryTypeInf= ormation !=3D NULL)) { DumpMemoryTypeInfoSummary(CurrentMemoryTypeInformation, PreviousMemo= ryTypeInformation); } --=20 2.28.0.windows.1