public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sainadh Nagolu" <sainadhn@ami.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	Sainadh Nagolu <sainadhn@ami.com>
Cc: Sundaresan S <sundaresans@ami.com>,
	Vasudevan Sambandan <vasudevans@ami.com>,
	"gaoliming@byosoft.com.cn" <gaoliming@byosoft.com.cn>
Subject: [PATCH] ShellPkg:Improved Smbios Type 9 table changes in PrintInfo.c
Date: Tue, 9 Aug 2022 10:51:50 +0000	[thread overview]
Message-ID: <20220809105100.2081-1-sainadhn@ami.com> (raw)

Since PeerGroups has a variable number of entries, new fields added after PeerGroups are defined in a extended structure. Done changes in PrintInfo.c to access those fields using SMBIOS_TABLE_TYPE9_EXTENDED structure from SmBios.h.

Signed-off-by: Sainadh Nagolu <sainadhn@ami.com>

CC: Vasudevan Sambandan <vasudevans@ami.com>
CC: Sundaresan S <sundaresans@ami.com>

---
 .../SmbiosView/PrintInfo.c                        | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
index a0ee286c9a..e1acb1e288 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
@@ -2,6 +2,7 @@
   Module for clarifying the content of the smbios structure element information.



   Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.<BR>

+  Copyright (c) 1985 - 2022, American Megatrends International LLC.<BR>

   (C) Copyright 2014 Hewlett-Packard Development Company, L.P.<BR>

   (C) Copyright 2015-2019 Hewlett Packard Enterprise Development LP<BR>

   SPDX-License-Identifier: BSD-2-Clause-Patent

@@ -597,8 +598,9 @@ SmbiosPrintStructure (
     //

     case 9:

     {

-      MISC_SLOT_PEER_GROUP  *PeerGroupPtr;

-      UINT8                 PeerGroupCount;

+      MISC_SLOT_PEER_GROUP         *PeerGroupPtr;

+         SMBIOS_TABLE_TYPE9_EXTENDED  *Type9ExtendedStruct;

+      UINT8                        PeerGroupCount;



       PRINT_PENDING_STRING (Struct, Type9, SlotDesignation);

       DisplaySystemSlotType (Struct->Type9->SlotType, Option);

@@ -636,9 +638,12 @@ SmbiosPrintStructure (
             ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_DATA_BUS_WIDTH), gShellDebug1HiiHandle, PeerGroupPtr[Index].DataBusWidth);

           }



-          DisplaySystemSlotHeight (Struct->Type9->SlotHeight, Option);

-          DisplaySystemSlotPhysicalWidth (Struct->Type9->SlotPhysicalWidth, Option);

-          DisplaySystemSlotInformation (Struct->Type9->SlotInformation, Option);

+          //Since PeerGroups has a variable number of entries, new fields added after PeerGroups are defined in

+          //a extended structure. Those fields can be referenced using SMBIOS_TABLE_TYPE9_EXTENDED structure.

+                 Type9ExtendedStruct = (SMBIOS_TABLE_TYPE9_EXTENDED*)((UINT8*)PeerGroupPtr + (PeerGroupCount * sizeof(MISC_SLOT_PEER_GROUP)));

+                 DisplaySystemSlotHeight (Type9ExtendedStruct->SlotHeight, Option);

+          DisplaySystemSlotPhysicalWidth (Type9ExtendedStruct->SlotPhysicalWidth, Option);

+          DisplaySystemSlotInformation (Type9ExtendedStruct->SlotInformation, Option);

         }

       }



--
2.36.0.windows.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

             reply	other threads:[~2022-08-09 10:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09 10:51 Sainadh Nagolu [this message]
2022-08-11 11:44 ` [edk2-devel] [PATCH] ShellPkg:Improved Smbios Type 9 table changes in PrintInfo.c Sainadh Nagolu
2022-08-12  4:47   ` 回复: " gaoliming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220809105100.2081-1-sainadhn@ami.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox