public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch 1/1] MdePkg/Library/UefiDevicePathLib: Add back StandaloneMm INF file
@ 2022-08-10  4:37 Michael D Kinney
  2022-08-10  5:45 ` 回复: " gaoliming
  0 siblings, 1 reply; 2+ messages in thread
From: Michael D Kinney @ 2022-08-10  4:37 UTC (permalink / raw)
  To: devel; +Cc: Liming Gao, Zhiguang Liu, Mateusz Albecki, Yanbo Huang

REF: https://github.com/tianocore/edk2/pull/3130

The above PR removed UefiDevicePathLibStandaloneMm.inf, which is
a non-backwards compatible change and does not provide time for
downstream platforms to use the UefiDevicePathLibBase.inf.

Add UefiDevicePathLibStandaloneMm.inf back, but add comments that
it is deprecated and that UefiDevicePathLibBase.inf should be used
instead.

Cc: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
Cc: Zhiguang Liu <zhiguang.liu@intel.com> [LiuZhiguang001]
Cc: Mateusz Albecki <mateusz.albecki@intel.com>
Cc: Yanbo Huang <yanbo.huang@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 .../UefiDevicePathLibStandaloneMm.inf         | 78 +++++++++++++++++++
 MdePkg/MdePkg.dsc                             |  1 +
 2 files changed, 79 insertions(+)
 create mode 100644 MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf

diff --git a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
new file mode 100644
index 000000000000..97db485e23f8
--- /dev/null
+++ b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
@@ -0,0 +1,78 @@
+## @file
+# Instance of Device Path Library based on Memory Allocation Library.
+#
+# Device Path Library that layers on top of the Memory Allocation Library.
+#
+# This library instances is deprecated and should no longer be used.  Ue
+# MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf instead.
+#
+# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) Microsoft Corporation.
+#
+#  SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+#
+##
+
+[Defines]
+  INF_VERSION                    = 0x00010005
+  BASE_NAME                      = UefiDevicePathLibStandaloneMm
+  MODULE_UNI_FILE                = UefiDevicePathLib.uni
+  FILE_GUID                      = 7B60A2BC-9259-48A8-8279-971412EECAB3
+  MODULE_TYPE                    = BASE
+  PI_SPECIFICATION_VERSION       = 0x00010032
+  VERSION_STRING                 = 1.0
+  LIBRARY_CLASS                  = DevicePathLib
+
+
+#
+#  VALID_ARCHITECTURES           = IA32 X64 EBC
+#
+
+[Sources]
+  DevicePathUtilities.c
+  DevicePathUtilitiesBase.c
+  DevicePathToText.c
+  DevicePathFromText.c
+  UefiDevicePathLib.c
+  UefiDevicePathLib.h
+
+[Packages]
+  MdePkg/MdePkg.dec
+
+[LibraryClasses]
+  BaseLib
+  MemoryAllocationLib
+  DebugLib
+  BaseMemoryLib
+  PcdLib
+  PrintLib
+
+[Guids]
+  ## SOMETIMES_CONSUMES  ## GUID
+  gEfiVTUTF8Guid
+  ## SOMETIMES_CONSUMES  ## GUID
+  gEfiVT100Guid
+  ## SOMETIMES_CONSUMES  ## GUID
+  gEfiVT100PlusGuid
+  ## SOMETIMES_CONSUMES  ## GUID
+  gEfiPcAnsiGuid
+  ## SOMETIMES_CONSUMES  ## GUID
+  gEfiUartDevicePathGuid
+  ## SOMETIMES_CONSUMES  ## GUID
+  gEfiSasDevicePathGuid
+  ## SOMETIMES_CONSUMES  ## GUID
+  gEfiVirtualDiskGuid
+  ## SOMETIMES_CONSUMES  ## GUID
+  gEfiVirtualCdGuid
+  ## SOMETIMES_CONSUMES  ## GUID
+  gEfiPersistentVirtualDiskGuid
+  ## SOMETIMES_CONSUMES  ## GUID
+  gEfiPersistentVirtualCdGuid
+
+[Protocols]
+  gEfiDevicePathProtocolGuid                    ## SOMETIMES_CONSUMES
+  gEfiDebugPortProtocolGuid                     ## UNDEFINED
+
+[Pcd]
+  gEfiMdePkgTokenSpaceGuid.PcdMaximumDevicePathNodeCount    ## SOMETIMES_CONSUMES
diff --git a/MdePkg/MdePkg.dsc b/MdePkg/MdePkg.dsc
index 9daee93523e5..cc1ac196a931 100644
--- a/MdePkg/MdePkg.dsc
+++ b/MdePkg/MdePkg.dsc
@@ -112,6 +112,7 @@ [Components]
   MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
   MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
   MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
+  MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
   MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibOptionalDevicePathProtocol.inf
   MdePkg/Library/UefiDevicePathLibDevicePathProtocol/UefiDevicePathLibDevicePathProtocol.inf
   MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
-- 
2.37.1.windows.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* 回复: [Patch 1/1] MdePkg/Library/UefiDevicePathLib: Add back StandaloneMm INF file
  2022-08-10  4:37 [Patch 1/1] MdePkg/Library/UefiDevicePathLib: Add back StandaloneMm INF file Michael D Kinney
@ 2022-08-10  5:45 ` gaoliming
  0 siblings, 0 replies; 2+ messages in thread
From: gaoliming @ 2022-08-10  5:45 UTC (permalink / raw)
  To: 'Michael D Kinney', devel
  Cc: 'Zhiguang Liu', 'Mateusz Albecki',
	'Yanbo Huang'

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: Michael D Kinney <michael.d.kinney@intel.com>
> 发送时间: 2022年8月10日 12:38
> 收件人: devel@edk2.groups.io
> 抄送: Liming Gao <gaoliming@byosoft.com.cn>; Zhiguang Liu
> <zhiguang.liu@intel.com>; Mateusz Albecki <mateusz.albecki@intel.com>;
> Yanbo Huang <yanbo.huang@intel.com>
> 主题: [Patch 1/1] MdePkg/Library/UefiDevicePathLib: Add back
> StandaloneMm INF file
> 
> REF: https://github.com/tianocore/edk2/pull/3130
> 
> The above PR removed UefiDevicePathLibStandaloneMm.inf, which is
> a non-backwards compatible change and does not provide time for
> downstream platforms to use the UefiDevicePathLibBase.inf.
> 
> Add UefiDevicePathLibStandaloneMm.inf back, but add comments that
> it is deprecated and that UefiDevicePathLibBase.inf should be used
> instead.
> 
> Cc: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
> Cc: Zhiguang Liu <zhiguang.liu@intel.com> [LiuZhiguang001]
> Cc: Mateusz Albecki <mateusz.albecki@intel.com>
> Cc: Yanbo Huang <yanbo.huang@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  .../UefiDevicePathLibStandaloneMm.inf         | 78
> +++++++++++++++++++
>  MdePkg/MdePkg.dsc                             |  1 +
>  2 files changed, 79 insertions(+)
>  create mode 100644
> MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> 
> diff --git
> a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> new file mode 100644
> index 000000000000..97db485e23f8
> --- /dev/null
> +++
> b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> @@ -0,0 +1,78 @@
> +## @file
> +# Instance of Device Path Library based on Memory Allocation Library.
> +#
> +# Device Path Library that layers on top of the Memory Allocation
Library.
> +#
> +# This library instances is deprecated and should no longer be used.  Ue
> +# MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf instead.
> +#
> +# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) Microsoft Corporation.
> +#
> +#  SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +#
> +##
> +
> +[Defines]
> +  INF_VERSION                    = 0x00010005
> +  BASE_NAME                      =
> UefiDevicePathLibStandaloneMm
> +  MODULE_UNI_FILE                = UefiDevicePathLib.uni
> +  FILE_GUID                      =
> 7B60A2BC-9259-48A8-8279-971412EECAB3
> +  MODULE_TYPE                    = BASE
> +  PI_SPECIFICATION_VERSION       = 0x00010032
> +  VERSION_STRING                 = 1.0
> +  LIBRARY_CLASS                  = DevicePathLib
> +
> +
> +#
> +#  VALID_ARCHITECTURES           = IA32 X64 EBC
> +#
> +
> +[Sources]
> +  DevicePathUtilities.c
> +  DevicePathUtilitiesBase.c
> +  DevicePathToText.c
> +  DevicePathFromText.c
> +  UefiDevicePathLib.c
> +  UefiDevicePathLib.h
> +
> +[Packages]
> +  MdePkg/MdePkg.dec
> +
> +[LibraryClasses]
> +  BaseLib
> +  MemoryAllocationLib
> +  DebugLib
> +  BaseMemoryLib
> +  PcdLib
> +  PrintLib
> +
> +[Guids]
> +  ## SOMETIMES_CONSUMES  ## GUID
> +  gEfiVTUTF8Guid
> +  ## SOMETIMES_CONSUMES  ## GUID
> +  gEfiVT100Guid
> +  ## SOMETIMES_CONSUMES  ## GUID
> +  gEfiVT100PlusGuid
> +  ## SOMETIMES_CONSUMES  ## GUID
> +  gEfiPcAnsiGuid
> +  ## SOMETIMES_CONSUMES  ## GUID
> +  gEfiUartDevicePathGuid
> +  ## SOMETIMES_CONSUMES  ## GUID
> +  gEfiSasDevicePathGuid
> +  ## SOMETIMES_CONSUMES  ## GUID
> +  gEfiVirtualDiskGuid
> +  ## SOMETIMES_CONSUMES  ## GUID
> +  gEfiVirtualCdGuid
> +  ## SOMETIMES_CONSUMES  ## GUID
> +  gEfiPersistentVirtualDiskGuid
> +  ## SOMETIMES_CONSUMES  ## GUID
> +  gEfiPersistentVirtualCdGuid
> +
> +[Protocols]
> +  gEfiDevicePathProtocolGuid                    ##
> SOMETIMES_CONSUMES
> +  gEfiDebugPortProtocolGuid                     ## UNDEFINED
> +
> +[Pcd]
> +  gEfiMdePkgTokenSpaceGuid.PcdMaximumDevicePathNodeCount    ##
> SOMETIMES_CONSUMES
> diff --git a/MdePkg/MdePkg.dsc b/MdePkg/MdePkg.dsc
> index 9daee93523e5..cc1ac196a931 100644
> --- a/MdePkg/MdePkg.dsc
> +++ b/MdePkg/MdePkg.dsc
> @@ -112,6 +112,7 @@ [Components]
>    MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
>    MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>    MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> +  MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> 
> MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibOptionalDevicePathPro
> tocol.inf
> 
> MdePkg/Library/UefiDevicePathLibDevicePathProtocol/UefiDevicePathLibDe
> vicePathProtocol.inf
>    MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
> --
> 2.37.1.windows.1




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-08-10  5:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-10  4:37 [Patch 1/1] MdePkg/Library/UefiDevicePathLib: Add back StandaloneMm INF file Michael D Kinney
2022-08-10  5:45 ` 回复: " gaoliming

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox