* [PATCH v1 0/1] OvmfPkg: increase max debug message length to 512
@ 2022-08-10 8:11 Oliver Steffen
2022-08-10 8:11 ` [PATCH v1 1/1] " Oliver Steffen
0 siblings, 1 reply; 4+ messages in thread
From: Oliver Steffen @ 2022-08-10 8:11 UTC (permalink / raw)
To: devel
Cc: Oliver Steffen, Ard Biesheuvel, Eric Dong, Gerd Hoffmann,
Jiewen Yao, Jordan Justen, Rahul Kumar, Ray Ni
Increase the maximum line length for debug messages.
While log messages should be short, they can still
get quite long, for example when printing device paths
or config strings in HII routing.
512 chars is an empirically good value.
This change has been proposed aleady a few years ago.
I am reposting this becasue I find it useful.
PR: https://github.com/tianocore/edk2/pull/3189
Laszlo Ersek (1):
OvmfPkg: increase max debug message length to 512
OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.37.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1 1/1] OvmfPkg: increase max debug message length to 512
2022-08-10 8:11 [PATCH v1 0/1] OvmfPkg: increase max debug message length to 512 Oliver Steffen
@ 2022-08-10 8:11 ` Oliver Steffen
2022-08-15 14:47 ` Gerd Hoffmann
0 siblings, 1 reply; 4+ messages in thread
From: Oliver Steffen @ 2022-08-10 8:11 UTC (permalink / raw)
To: devel
Cc: Laszlo Ersek, Ard Biesheuvel, Eric Dong, Gerd Hoffmann,
Jiewen Yao, Jordan Justen, Rahul Kumar, Ray Ni, Oliver Steffen
From: Laszlo Ersek <lersek@redhat.com>
Increase the maximum line length for debug messages.
While log messages should be short, they can still
get quite long, for example when printing device paths
or config strings in HII routing.
512 chars is an empirically good value.
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Oliver Steffen <osteffen@redhat.com>
---
OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c
index 4e25f198aa76..640627f38b72 100644
--- a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c
+++ b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c
@@ -21,7 +21,7 @@
//
// Define the maximum debug and assert message length that this library supports
//
-#define MAX_DEBUG_MESSAGE_LENGTH 0x100
+#define MAX_DEBUG_MESSAGE_LENGTH 0x200
//
// VA_LIST can not initialize to NULL for all compiler, so we use this to
--
2.37.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] OvmfPkg: increase max debug message length to 512
2022-08-10 8:11 ` [PATCH v1 1/1] " Oliver Steffen
@ 2022-08-15 14:47 ` Gerd Hoffmann
2022-09-05 13:55 ` Ard Biesheuvel
0 siblings, 1 reply; 4+ messages in thread
From: Gerd Hoffmann @ 2022-08-15 14:47 UTC (permalink / raw)
To: Oliver Steffen
Cc: devel, Laszlo Ersek, Ard Biesheuvel, Eric Dong, Jiewen Yao,
Jordan Justen, Rahul Kumar, Ray Ni
On Wed, Aug 10, 2022 at 10:11:40AM +0200, Oliver Steffen wrote:
> From: Laszlo Ersek <lersek@redhat.com>
>
> Increase the maximum line length for debug messages.
> While log messages should be short, they can still
> get quite long, for example when printing device paths
> or config strings in HII routing.
> 512 chars is an empirically good value.
>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> ---
> OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c
> index 4e25f198aa76..640627f38b72 100644
> --- a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c
> +++ b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c
> @@ -21,7 +21,7 @@
> //
> // Define the maximum debug and assert message length that this library supports
> //
> -#define MAX_DEBUG_MESSAGE_LENGTH 0x100
> +#define MAX_DEBUG_MESSAGE_LENGTH 0x200
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
take care,
Gerd
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] OvmfPkg: increase max debug message length to 512
2022-08-15 14:47 ` Gerd Hoffmann
@ 2022-09-05 13:55 ` Ard Biesheuvel
0 siblings, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2022-09-05 13:55 UTC (permalink / raw)
To: Gerd Hoffmann
Cc: Oliver Steffen, devel, Laszlo Ersek, Ard Biesheuvel, Eric Dong,
Jiewen Yao, Jordan Justen, Rahul Kumar, Ray Ni
On Mon, 15 Aug 2022 at 16:47, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> On Wed, Aug 10, 2022 at 10:11:40AM +0200, Oliver Steffen wrote:
> > From: Laszlo Ersek <lersek@redhat.com>
> >
> > Increase the maximum line length for debug messages.
> > While log messages should be short, they can still
> > get quite long, for example when printing device paths
> > or config strings in HII routing.
> > 512 chars is an empirically good value.
> >
> > Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> > Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> > ---
> > OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c
> > index 4e25f198aa76..640627f38b72 100644
> > --- a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c
> > +++ b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c
> > @@ -21,7 +21,7 @@
> > //
> > // Define the maximum debug and assert message length that this library supports
> > //
> > -#define MAX_DEBUG_MESSAGE_LENGTH 0x100
> > +#define MAX_DEBUG_MESSAGE_LENGTH 0x200
>
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
>
Merged as #3287
> take care,
> Gerd
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-05 13:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-10 8:11 [PATCH v1 0/1] OvmfPkg: increase max debug message length to 512 Oliver Steffen
2022-08-10 8:11 ` [PATCH v1 1/1] " Oliver Steffen
2022-08-15 14:47 ` Gerd Hoffmann
2022-09-05 13:55 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox