From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mx.groups.io with SMTP id smtpd.web09.990.1660170539055088306 for ; Wed, 10 Aug 2022 15:28:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=E6i8bK+c; spf=pass (domain: gmail.com, ip: 209.85.214.179, mailfrom: kuqin12@gmail.com) Received: by mail-pl1-f179.google.com with SMTP id z19so15478603plb.1 for ; Wed, 10 Aug 2022 15:28:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=hu5Dw9C1d7jQf9qCIcgsKt5xWLt7HdsDqmM88g/Yyos=; b=E6i8bK+ciCtkHPXBnMpMyEjfH6nGZbZaoka6L2IeN4JHs4R7VO5AlmDQGAlMRFMRu0 q6ATgrznRnzv/CKHfnSBFQT/CeJRI+FfGdkv3rNSkdCmz62r/AB3dPvZK0of7ndC5oBl 27TTHZXXnbL4ZMZHemskMhpcxiu1GTzVGoI/nYt0lZUD/gUa1vvi6qMmWoME/qrRdoA9 jyiVi+FY1qLffEcb2BHp475fKaMapfbdwp6J5HQ08fHpSNDD5mPBDZ5v41BLv1UQNzQF RfOLecEoaWcXrov785vzc1lBwwpIxdJEVRKcqsS3qLEW8w9oYHtMvnoObkQod1FQ2uQS 0W/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=hu5Dw9C1d7jQf9qCIcgsKt5xWLt7HdsDqmM88g/Yyos=; b=LDCDwkOKj2RGIEwqDQdFMDn/sF5+BErdQlUxO8ZsbnHC6XHdpkVFQCQWJiGkgGTEON Eb3j7cq5Fifze2tXQqxmp4kQOUO65k3zCNXbdlrfY76kNIqRCzGdY9oiwd5VM16Cx79m wKk4dXeVrxZAa9a40BRMAbBiBEOEDQSs9XPKS/wU+ICDAXkOF94UdwGyqmmlGWX78LZZ dAVBVeYGPHZ+54vM3OeHYTXAFdkg4BRFJ5Y7eQuZxhexAwDcYf7C0lpFkOAZU58DjJ1M LKDwu/pm/sZ9RyufoV6qVmjZfuKvdKv80V9jBJPt1JNDTmubq/QBPLe0qXwlfg61aVB3 P+Yw== X-Gm-Message-State: ACgBeo1LIwKeE5ooLBhsTlnnOCRf6+PHZbGOVhr1At5pnk97LFKWzmoc qF3RSufCVjZGA628rWUAz7UxI293UaY= X-Google-Smtp-Source: AA6agR7dCQ/hjHugCdBP7ZL3A8OJMOrEUk82xlc8fxzBTNNpYjv4f8/fB63HMIpjufq4KhVax4xX+w== X-Received: by 2002:a17:902:760c:b0:16d:e87:ce93 with SMTP id k12-20020a170902760c00b0016d0e87ce93mr29378131pll.79.1660170538425; Wed, 10 Aug 2022 15:28:58 -0700 (PDT) Return-Path: Received: from MININT-0U7P5GU.redmond.corp.microsoft.com ([2001:4898:80e8:38:b518:f1a8:aef2:7dc4]) by smtp.gmail.com with ESMTPSA id h11-20020a170902f70b00b0016d66d49b85sm13309701plo.239.2022.08.10.15.28.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Aug 2022 15:28:58 -0700 (PDT) From: "Kun Qin" To: devel@edk2.groups.io Cc: Sami Mujawar , Alexei Fedorov , Joe Lopez , Sami Mujawar , Pierre Gondois Subject: [PATCH v4 2/6] DynamicTablesPkg: DynamicPlatRepoLib: Fix incorrect dereferencing Date: Wed, 10 Aug 2022 15:28:49 -0700 Message-Id: <20220810222853.1916-3-kuqin12@gmail.com> X-Mailer: git-send-email 2.37.1.windows.1 In-Reply-To: <20220810222853.1916-1-kuqin12@gmail.com> References: <20220810222853.1916-1-kuqin12@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3996 The content of token should be derived from the data section of the `CmObject` instead of the object itself. This change fixed the issue by dereferencing the token value from the data buffer of input CmObject. Cc: Sami Mujawar Cc: Alexei Fedorov Co-authored-by: Joe Lopez Signed-off-by: Kun Qin Reviewed-by: Sami Mujawar Reviewed-by: Pierre Gondois --- Notes: v2: - Added Reviewed-by tag [Sami] - Added Reviewed-by tag [Pierre] =20=20=20=20 v3: - No change. =20=20=20=20 v4: - No change. DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c | = 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTok= enFixer.c b/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectToke= nFixer.c index 80d0aa17bc1a..84e4bb7e3bc8 100644 --- a/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer= .c +++ b/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer= .c @@ -60,7 +60,7 @@ TokenFixerItsGroup ( )=0D {=0D ASSERT (CmObject !=3D NULL);=0D - ((CM_ARM_ITS_GROUP_NODE *)CmObject)->Token =3D Token;=0D + ((CM_ARM_ITS_GROUP_NODE *)CmObject->Data)->Token =3D Token;=0D return EFI_SUCCESS;=0D }=0D =0D --=20 2.37.1.windows.1