From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.3634.1660200854871999493 for ; Wed, 10 Aug 2022 23:54:16 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=do6zM1+C; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: judah.vang@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660200856; x=1691736856; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0TVp1YhBJXHH2lBf1n6OuDeNPEHXtT1vTMuo6zQJLKI=; b=do6zM1+CpklkxVcbuvDqKjHWykJclQLFgd/JszksqIwSohYm+NFo0hsr /g/S/34KzbPoanG0jnOhQ/LnPBfnzgHi789Xgnnw9L56FAEJMebXACwsG TWmCaqVokU5/OMDJ+MNNlBfp4eo/DPbxIHw3ZzYgBLwT53AcgDNDft1Va 4hXqJkUF6CoKfBzeBj7C6/Jk/QC9b6yEd5+3StHBP/2QvlOp1wiXRHS/3 ZIyh8Id2O45UeF0LJvb9/ZxbqAVQDq5OtFG2+IeZBfuRRYEmoq85MT6yi UUaruTyql1OysGs0+uCtrKjiLD7CVOEwLOOw5R/vM4Dto0aGK4TJvUUfa w==; X-IronPort-AV: E=McAfee;i="6400,9594,10435"; a="377565815" X-IronPort-AV: E=Sophos;i="5.93,228,1654585200"; d="scan'208";a="377565815" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2022 23:54:16 -0700 X-IronPort-AV: E=Sophos;i="5.93,228,1654585200"; d="scan'208";a="673586382" Received: from moisespe-mobl.amr.corp.intel.com (HELO jvang-mobl.amr.corp.intel.com) ([10.212.171.64]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2022 23:54:15 -0700 From: "Judah Vang" To: devel@edk2.groups.io Cc: Jian J Wang , Jiewen Yao , Nishant C Mistry Subject: [PATCH v4 14/28] SecurityPkg: Fix GetVariableKey API Date: Wed, 10 Aug 2022 23:53:23 -0700 Message-Id: <20220811065337.2068-15-judah.vang@intel.com> X-Mailer: git-send-email 2.35.1.windows.2 In-Reply-To: <20220811065337.2068-1-judah.vang@intel.com> References: <20220811065337.2068-1-judah.vang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 V4: Applied code review - function comments need to match function prototype. V1: Fix GetVariableKey API to match changes in header files. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c b/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c index a08def767b5f..2cf4b3cbf9f6 100644 --- a/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c +++ b/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c @@ -1,7 +1,7 @@ /** @file Null version of VariableKeyLib for build purpose. Don't use it in real product. -Copyright (c) 2020, Intel Corporation. All rights reserved.
+Copyright (c) 2020 - 2022, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent Retrieves the key for integrity and/or confidentiality of variables. @param[out] VariableKey A pointer to pointer for the variable key buffer. - @param[in,out] VariableKeySize The size in bytes of the variable key. + @param[in] VariableKeySize The size in bytes of the variable key. @retval EFI_SUCCESS The variable key was returned. @retval EFI_DEVICE_ERROR An error occurred while attempting to get the variable key. @@ -22,8 +22,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent EFI_STATUS EFIAPI GetVariableKey ( - OUT VOID **VariableKey, - IN OUT UINTN *VariableKeySize + OUT VOID *VariableKey, + IN UINTN VariableKeySize ) { ASSERT (FALSE); -- 2.35.1.windows.2